Patch Detail
Show a patch.
GET /api/patches/8547/?format=api
{ "id": 8547, "url": "https://patchwork.libcamera.org/api/patches/8547/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8547/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200701210948.999363-3-niklas.soderlund@ragnatech.se>", "date": "2020-07-01T21:09:48", "name": "[libcamera-devel,v2,2/2] libcamera: ipu3: cio2: Make use of utils::map_keys() helper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f4fbf1b12cd0bc8b1d561d429873aec0e1ecb600", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8547/mbox/", "series": [ { "id": 1069, "url": "https://patchwork.libcamera.org/api/series/1069/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1069", "date": "2020-07-01T21:09:46", "name": "libcamera: utils: Add map_keys() function", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1069/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8547/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8547/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27A6ABFFE2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Jul 2020 21:10:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0166160C53;\n\tWed, 1 Jul 2020 23:10:08 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8956560C53\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Jul 2020 23:10:04 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 3ab62c72-bbdf-11ea-933e-005056917a89;\n\tWed, 01 Jul 2020 23:10:02 +0200 (CEST)" ], "X-Halon-ID": "3ab62c72-bbdf-11ea-933e-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 1 Jul 2020 23:09:48 +0200", "Message-Id": "<20200701210948.999363-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200701210948.999363-1-niklas.soderlund@ragnatech.se>", "References": "<20200701210948.999363-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/2] libcamera: ipu3: cio2: Make use of\n\tutils::map_keys() helper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use a helper instead of local code to retrieve all keys from a map.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 19 +++----------------\n 1 file changed, 3 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex aa1459fb3599283b..7941c6845cbc9a9a 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -95,11 +95,7 @@ int CIO2Device::init(const MediaDevice *media, unsigned int index)\n \t * utils::set_overlap requires the ranges to be sorted, keep the\n \t * cio2Codes vector sorted in ascending order.\n \t */\n-\tstd::vector<unsigned int> cio2Codes;\n-\tcio2Codes.reserve(mbusCodesToInfo.size());\n-\tstd::transform(mbusCodesToInfo.begin(), mbusCodesToInfo.end(),\n-\t\t std::back_inserter(cio2Codes),\n-\t\t [](auto &pair) { return pair.first; });\n+\tstd::vector<unsigned int> cio2Codes = utils::map_keys(mbusCodesToInfo);\n \tconst std::vector<unsigned int> &sensorCodes = sensor_->mbusCodes();\n \tif (!utils::set_overlap(sensorCodes.begin(), sensorCodes.end(),\n \t\t\t\tcio2Codes.begin(), cio2Codes.end())) {\n@@ -145,12 +141,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n \t * Apply the selected format to the sensor, the CSI-2 receiver and\n \t * the CIO2 output device.\n \t */\n-\tstd::vector<unsigned int> mbusCodes;\n-\tmbusCodes.reserve(mbusCodesToInfo.size());\n-\tstd::transform(mbusCodesToInfo.begin(), mbusCodesToInfo.end(),\n-\t\t std::back_inserter(mbusCodes),\n-\t\t [](auto &pair) { return pair.first; });\n-\n+\tstd::vector<unsigned int> mbusCodes = utils::map_keys(mbusCodesToInfo);\n \tsensorFormat = sensor_->getFormat(mbusCodes, size);\n \tret = sensor_->setFormat(&sensorFormat);\n \tif (ret)\n@@ -189,11 +180,7 @@ CIO2Device::generateConfiguration(Size size) const\n \t\tsize = sensor_->resolution();\n \n \t/* Query the sensor static information for closest match. */\n-\tstd::vector<unsigned int> mbusCodes;\n-\tstd::transform(mbusCodesToInfo.begin(), mbusCodesToInfo.end(),\n-\t\t std::back_inserter(mbusCodes),\n-\t\t [](auto &pair) { return pair.first; });\n-\n+\tstd::vector<unsigned int> mbusCodes = utils::map_keys(mbusCodesToInfo);\n \tV4L2SubdeviceFormat sensorFormat = sensor_->getFormat(mbusCodes, size);\n \tif (!sensorFormat.mbus_code) {\n \t\tLOG(IPU3, Error) << \"Sensor does not support mbus code\";\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }