Patch Detail
Show a patch.
GET /api/patches/8524/?format=api
{ "id": 8524, "url": "https://patchwork.libcamera.org/api/patches/8524/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8524/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200630145808.2976956-6-paul.elder@ideasonboard.com>", "date": "2020-06-30T14:58:07", "name": "[libcamera-devel,v2,5/6] libcamera: pipeline: raspberrypi: Simplify format fetching", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "412f8bb9478c23dc0944a406e7696c03e91a1087", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8524/mbox/", "series": [ { "id": 1064, "url": "https://patchwork.libcamera.org/api/series/1064/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1064", "date": "2020-06-30T14:58:02", "name": "Move formats from v4l2-compat into libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1064/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8524/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8524/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF36BBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Jun 2020 14:58:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99EE060C60;\n\tTue, 30 Jun 2020 16:58:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 334A960C55\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Jun 2020 16:58:33 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70B5829F;\n\tTue, 30 Jun 2020 16:58:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XWV46s2f\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593529113;\n\tbh=dg5QwoN437Ij7WTk5xjQ+AYAq638k9q1jSWYqj4UC+0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XWV46s2f9VGUdMtFwCUVcU6TAX/wtevzvkeJh3WtzMs+wsTcj5CZB+5xKT7e0S03D\n\tGqLsb57O3a3QBCYxLt3nFBYCZQ6EynMY6y767d9yCdlsHIvEbXsDSI1PYYudlCQGRO\n\t0dPmpdqAb30RX6ihIVXLnmns02LKTKR21cLxqb4o=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Jun 2020 23:58:07 +0900", "Message-Id": "<20200630145808.2976956-6-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200630145808.2976956-1-paul.elder@ideasonboard.com>", "References": "<20200630145808.2976956-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 5/6] libcamera: pipeline: raspberrypi:\n\tSimplify format fetching", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Simplify code for looking up PixelFormatInfo using a V4L2 format by\nusing the new PixelFormatInfo lookup function based on V4L2 format.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v2:\n- just a few words in the commit message\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 9d887b7..4d9ec9c 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -81,8 +81,7 @@ V4L2DeviceFormat findBestMode(V4L2PixFmtMap &formatsMap, const Size &req)\n \t/* Calculate the closest/best mode from the user requested size. */\n \tfor (const auto &iter : formatsMap) {\n \t\tV4L2PixelFormat v4l2Format = iter.first;\n-\t\tPixelFormat pixelFormat = v4l2Format.toPixelFormat();\n-\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(v4l2Format);\n \n \t\tfor (const SizeRange &sz : iter.second) {\n \t\t\tdouble modeWidth = sz.contains(req) ? req.width : sz.max.width;\n", "prefixes": [ "libcamera-devel", "v2", "5/6" ] }