Patch Detail
Show a patch.
GET /api/patches/8522/?format=api
{ "id": 8522, "url": "https://patchwork.libcamera.org/api/patches/8522/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8522/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200630145808.2976956-4-paul.elder@ideasonboard.com>", "date": "2020-06-30T14:58:05", "name": "[libcamera-devel,v2,3/6] libcamera: formats: PixelFormatInfo: Add v4l2 lookup function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "93de082eab115c378ebd36a08a9cd0e8ebc3e4f5", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8522/mbox/", "series": [ { "id": 1064, "url": "https://patchwork.libcamera.org/api/series/1064/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1064", "date": "2020-06-30T14:58:02", "name": "Move formats from v4l2-compat into libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1064/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8522/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8522/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B8BBBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Jun 2020 14:58:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD38260C5C;\n\tTue, 30 Jun 2020 16:58:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4725A60C56\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Jun 2020 16:58:29 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A546A29F;\n\tTue, 30 Jun 2020 16:58:27 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FbTsWXWa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593529109;\n\tbh=mDfv4gVQq4n7zh6dVF0MMtT5tfS6pZG/kWQ0ES64DEI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FbTsWXWaLRDbRCaE0OETdInreEPSPjyRxV20/GzIjFEijMO7fj2DfWOqPbP9N24Xs\n\tmQbHW8uOtetZH4P15edVdR4LsO60ttBebevvNSmPgOpR7gHJc1L3nLElAcD/bnJYCd\n\tj2Z0yZn34jv4vZ6Uxsd6YAUjnoI3BY06l7PCRR7c=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Jun 2020 23:58:05 +0900", "Message-Id": "<20200630145808.2976956-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200630145808.2976956-1-paul.elder@ideasonboard.com>", "References": "<20200630145808.2976956-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 3/6] libcamera: formats:\n\tPixelFormatInfo: Add v4l2 lookup function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a lookup function for PixelFormatInfo that takes a V4L2PixelFormat.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- move invalid PixelFormatInfo instance to anonymous namespace\n- add documentation\n---\n include/libcamera/internal/formats.h | 1 +\n src/libcamera/formats.cpp | 23 +++++++++++++++++++++--\n 2 files changed, 22 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex dc19492..3c7440a 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -44,6 +44,7 @@ public:\n \tbool isValid() const { return format.isValid(); }\n \n \tstatic const PixelFormatInfo &info(const PixelFormat &format);\n+\tstatic const PixelFormatInfo &info(const V4L2PixelFormat &format);\n \n \tconst char *name;\n \tPixelFormat format;\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 8076c39..4d18825 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -7,6 +7,7 @@\n \n #include \"libcamera/internal/formats.h\"\n \n+#include <algorithm>\n #include <errno.h>\n \n #include <libcamera/formats.h>\n@@ -190,6 +191,8 @@ const std::map<unsigned int, std::vector<SizeRange>> &ImageFormats::data() const\n \n namespace {\n \n+const PixelFormatInfo invalid{};\n+\n const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t/* RGB formats. */\n \t{ formats::BGR888, {\n@@ -661,8 +664,6 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n */\n const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n {\n-\tstatic const PixelFormatInfo invalid{};\n-\n \tconst auto iter = pixelFormatInfo.find(format);\n \tif (iter == pixelFormatInfo.end()) {\n \t\tLOG(Formats, Warning)\n@@ -674,4 +675,22 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n \treturn iter->second;\n }\n \n+/**\n+ * \\brief Retrieve information about a pixel format\n+ * \\param[in] format The V4L2 pixel format\n+ * \\return The PixelFormatInfo describing the V4L2 \\a format if known, or an\n+ * invalid PixelFormatInfo otherwise\n+ */\n+const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n+{\n+\tauto info = std::find_if(pixelFormatInfo.begin(), pixelFormatInfo.end(),\n+\t\t\t\t [format](auto pair) {\n+\t\t\t\t\t return pair.second.v4l2Format == format;\n+\t\t\t\t });\n+\tif (info == pixelFormatInfo.end())\n+\t\treturn invalid;\n+\n+\treturn info->second;\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v2", "3/6" ] }