Patch Detail
Show a patch.
GET /api/patches/850/?format=api
{ "id": 850, "url": "https://patchwork.libcamera.org/api/patches/850/?format=api", "web_url": "https://patchwork.libcamera.org/patch/850/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190402162134.3894-9-jacopo@jmondi.org>", "date": "2019-04-02T16:21:30", "name": "[libcamera-devel,v6,08/12] libcamera: ipu3: Queue requests to ImgU", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8d6106a9d2ed7fe78bb604465273b2d62c267d0a", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/850/mbox/", "series": [ { "id": 229, "url": "https://patchwork.libcamera.org/api/series/229/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=229", "date": "2019-04-02T16:21:22", "name": "libcamera: ipu3: Add ImgU support", "version": 6, "mbox": "https://patchwork.libcamera.org/series/229/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/850/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/850/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3499611B9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Apr 2019 18:21:00 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1D70F20004;\n\tTue, 2 Apr 2019 16:20:59 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 2 Apr 2019 18:21:30 +0200", "Message-Id": "<20190402162134.3894-9-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190402162134.3894-1-jacopo@jmondi.org>", "References": "<20190402162134.3894-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 08/12] libcamera: ipu3: Queue requests\n\tto ImgU", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 02 Apr 2019 16:21:01 -0000" }, "content": "Implement queueRequest for the IPU3 pipeline manager. When a request is\nqueued, a new buffer is queued to the ImgU output for capture.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 7061f36b4495..9bceb8bfab35 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -398,9 +398,10 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n {\n \tIPU3CameraData *data = cameraData(camera);\n-\tV4L2Device *cio2 = data->cio2_.output_;\n+\tV4L2Device *output = data->imgu_->output_.dev;\n \tStream *stream = &data->stream_;\n \n+\t/* Queue a buffer to the ImgU output for capture. */\n \tBuffer *buffer = request->findBuffer(stream);\n \tif (!buffer) {\n \t\tLOG(IPU3, Error)\n@@ -408,7 +409,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n \t\treturn -ENOENT;\n \t}\n \n-\tint ret = cio2->queueBuffer(buffer);\n+\tint ret = output->queueBuffer(buffer);\n \tif (ret < 0)\n \t\treturn ret;\n \n", "prefixes": [ "libcamera-devel", "v6", "08/12" ] }