Patch Detail
Show a patch.
GET /api/patches/8485/?format=api
{ "id": 8485, "url": "https://patchwork.libcamera.org/api/patches/8485/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8485/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200628231934.29025-2-laurent.pinchart@ideasonboard.com>", "date": "2020-06-28T23:19:26", "name": "[libcamera-devel,v1,1/9] libcamera: ipa: Document the parameters of the IPA C configure function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "be3e808660b2731ffdf08c9ada80a01804dfafc0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8485/mbox/", "series": [ { "id": 1054, "url": "https://patchwork.libcamera.org/api/series/1054/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1054", "date": "2020-06-28T23:19:25", "name": "Support passing custom data to IPA configure()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1054/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8485/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8485/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12AB6C2E66\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Jun 2020 23:19:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C789660AF5;\n\tMon, 29 Jun 2020 01:19:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97CFD609C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2020 01:19:41 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E80E556;\n\tMon, 29 Jun 2020 01:19:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jn3/8GdY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593386381;\n\tbh=flOhzyMpDQg8Bjhw/dwaBl4oLmvP5c+29sCfnu0Z970=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jn3/8GdYN+NVkDuQOJ0fn5m/XLS7MfCu/bFUlpCnk/8m39TIdoNd7GdTSD67LaJjh\n\tfKwpcseIXihPGyDUZYEfJc5nIbFmZn687EWRe7IqpJvH5n/CddjlLlo+cMSv7ylJVK\n\tQgPYK2HkExPKXrL9vjBBblVqUcndGn5E8uGi97gI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Jun 2020 02:19:26 +0300", "Message-Id": "<20200628231934.29025-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>", "References": "<20200628231934.29025-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v1 1/9] libcamera: ipa: Document the\n\tparameters of the IPA C configure function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The parameters to the configure() function part of the ipa_context_ops\nare not documented. Fix that.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/ipa_interface.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\nindex 69835e63ab46..ebe47e1233a5 100644\n--- a/src/libcamera/ipa_interface.cpp\n+++ b/src/libcamera/ipa_interface.cpp\n@@ -340,6 +340,11 @@\n * \\var ipa_context_ops::configure\n * \\brief Configure the IPA stream and sensor settings\n * \\param[in] ctx The IPA context\n+ * \\param[in] sensor_info Camera sensor information\n+ * \\param[in] streams Configuration of all active streams\n+ * \\param[in] num_streams The number of entries in the \\a streams array\n+ * \\param[in] maps Controls provided by the pipeline entities\n+ * \\param[in] num_maps The number of entries in the \\a maps array\n *\n * \\sa libcamera::IPAInterface::configure()\n */\n", "prefixes": [ "libcamera-devel", "v1", "1/9" ] }