Patch Detail
Show a patch.
GET /api/patches/8483/?format=api
{ "id": 8483, "url": "https://patchwork.libcamera.org/api/patches/8483/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8483/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200628190920.3206340-3-niklas.soderlund@ragnatech.se>", "date": "2020-06-28T19:09:20", "name": "[libcamera-devel,v3,2/2] libcamera: ipu3: cio2: Use Size::isNull()", "commit_ref": "6bc4af7d0b6b203cc98ad617bf0a39e11eec8a2b", "pull_url": null, "state": "accepted", "archived": false, "hash": "2be3d1c78cb31cee049bb4f65a9bd78d7d265e65", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8483/mbox/", "series": [ { "id": 1053, "url": "https://patchwork.libcamera.org/api/series/1053/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1053", "date": "2020-06-28T19:09:18", "name": "libcamera: geometry: Add isNull() function to Size class", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1053/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8483/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8483/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A5FCC2E69\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Jun 2020 19:09:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE96760AF6;\n\tSun, 28 Jun 2020 21:09:30 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4B43603B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Jun 2020 21:09:29 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid cf0f774c-b972-11ea-86ee-0050569116f7;\n\tSun, 28 Jun 2020 21:08:54 +0200 (CEST)" ], "X-Halon-ID": "cf0f774c-b972-11ea-86ee-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 28 Jun 2020 21:09:20 +0200", "Message-Id": "<20200628190920.3206340-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200628190920.3206340-1-niklas.soderlund@ragnatech.se>", "References": "<20200628190920.3206340-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 2/2] libcamera: ipu3: cio2: Use\n\tSize::isNull()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the Size::isNull() helper instead of using local code.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex 885e2ca0d9677364..aa1459fb3599283b 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -185,7 +185,7 @@ CIO2Device::generateConfiguration(Size size) const\n \tStreamConfiguration cfg;\n \n \t/* If no desired size use the sensor resolution. */\n-\tif (!size.width && !size.height)\n+\tif (size.isNull())\n \t\tsize = sensor_->resolution();\n \n \t/* Query the sensor static information for closest match. */\n", "prefixes": [ "libcamera-devel", "v3", "2/2" ] }