Patch Detail
Show a patch.
GET /api/patches/8475/?format=api
{ "id": 8475, "url": "https://patchwork.libcamera.org/api/patches/8475/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8475/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200628155539.29498-3-jacopo@jmondi.org>", "date": "2020-06-28T15:55:38", "name": "[libcamera-devel,2/3] libcamera: ipu3: Accept an empty roles list", "commit_ref": "5267ca8e0209c08ba2b022543f291985c4cfeaf5", "pull_url": null, "state": "accepted", "archived": false, "hash": "bf30ca3a6b9fb709937e12e72ec2698fb88e2798", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8475/mbox/", "series": [ { "id": 1051, "url": "https://patchwork.libcamera.org/api/series/1051/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1051", "date": "2020-06-28T15:55:36", "name": "ipu3: Accept empty roles list in generateConfiguration()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1051/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8475/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8475/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDA2AC2E69\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Jun 2020 15:52:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A52A5609DB;\n\tSun, 28 Jun 2020 17:52:20 +0200 (CEST)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 548F4609C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Jun 2020 17:52:17 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D4561C0004;\n\tSun, 28 Jun 2020 15:52:16 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 28 Jun 2020 17:55:38 +0200", "Message-Id": "<20200628155539.29498-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200628155539.29498-1-jacopo@jmondi.org>", "References": "<20200628155539.29498-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: ipu3: Accept an empty\n\troles list", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPU3 pipeline handler that does not support receiving an empty list\nof roles at generateConfiguration() time. This contradicts the camera\nAPI which allows application to generate empty CameraConfiguration to\nbe later manually filled.\n\nFix this by returning an empty CameraConfiguration if the list of\nrequested roles is empty. While at it, align the style with the other\npipeline handlers.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex ef57196c32da..cbf19793c43e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -292,14 +292,15 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n \tconst StreamRoles &roles)\n {\n \tIPU3CameraData *data = cameraData(camera);\n-\tIPU3CameraConfiguration *config;\n+\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);\n \tstd::set<Stream *> streams = {\n \t\t&data->outStream_,\n \t\t&data->vfStream_,\n \t\t&data->rawStream_,\n \t};\n \n-\tconfig = new IPU3CameraConfiguration(camera, data);\n+\tif (roles.empty())\n+\t\treturn config;\n \n \tfor (const StreamRole role : roles) {\n \t\tStreamConfiguration cfg = {};\n", "prefixes": [ "libcamera-devel", "2/3" ] }