Patch Detail
Show a patch.
GET /api/patches/8448/?format=api
{ "id": 8448, "url": "https://patchwork.libcamera.org/api/patches/8448/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8448/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200627030043.2088585-7-niklas.soderlund@ragnatech.se>", "date": "2020-06-27T03:00:36", "name": "[libcamera-devel,06/13] libcamera: ipu3: imgu: Do not cache index", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4225987e96fc55a62aec25d067fee2b215af0c44", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8448/mbox/", "series": [ { "id": 1046, "url": "https://patchwork.libcamera.org/api/series/1046/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1046", "date": "2020-06-27T03:00:30", "name": "libcamera: ipu3: Refactoring of ImgU", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1046/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8448/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8448/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3D88C2E67\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 27 Jun 2020 03:00:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A34AE60B09;\n\tSat, 27 Jun 2020 05:00:58 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 060F260A16\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Jun 2020 05:00:54 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 56ea8c4c-b822-11ea-86ee-0050569116f7;\n\tSat, 27 Jun 2020 05:00:21 +0200 (CEST)" ], "X-Halon-ID": "56ea8c4c-b822-11ea-86ee-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 27 Jun 2020 05:00:36 +0200", "Message-Id": "<20200627030043.2088585-7-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>", "References": "<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 06/13] libcamera: ipu3: imgu: Do not cache\n\tindex", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The numerical index of the imgu is only used to create its name in\nstring form. There is no need to keep it around after that, remove it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 3 +--\n src/libcamera/pipeline/ipu3/imgu.h | 1 -\n 2 files changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex 26a95979d0c7735a..5d11539605f26303 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -37,8 +37,7 @@ int ImgUDevice::init(MediaDevice *media, unsigned int index)\n {\n \tint ret;\n \n-\tindex_ = index;\n-\tname_ = \"ipu3-imgu \" + std::to_string(index_);\n+\tname_ = \"ipu3-imgu \" + std::to_string(index);\n \tmedia_ = media;\n \n \t/*\ndiff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex 9bb1b88e2ca8ea2d..ad5aabf134e2099d 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -69,7 +69,6 @@ public:\n \t\t bool enable);\n \tint enableLinks(bool enable);\n \n-\tunsigned int index_;\n \tstd::string name_;\n \tMediaDevice *media_;\n \n", "prefixes": [ "libcamera-devel", "06/13" ] }