Patch Detail
Show a patch.
GET /api/patches/8439/?format=api
{ "id": 8439, "url": "https://patchwork.libcamera.org/api/patches/8439/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8439/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200626102531.1187650-2-naush@raspberrypi.com>", "date": "2020-06-26T10:25:28", "name": "[libcamera-devel,1/4] libcamera: controls: Add focus Figure of Merit (FoM) control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "823eb2ccd1b67a58d9531bd51750b2c0041422e5", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8439/mbox/", "series": [ { "id": 1044, "url": "https://patchwork.libcamera.org/api/series/1044/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1044", "date": "2020-06-26T10:25:27", "name": "Focus feedback control", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1044/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8439/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8439/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 604C2C0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2020 10:25:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A863609DF;\n\tFri, 26 Jun 2020 12:25:55 +0200 (CEST)", "from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9F9F609C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2020 12:25:51 +0200 (CEST)", "by mail-wm1-x341.google.com with SMTP id t194so8866375wmt.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2020 03:25:51 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tr8sm21959679wrp.40.2020.06.26.03.25.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2020 03:25:48 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"McLarQn+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ssrOPFUZVLpjswytpOgwcHjf0cjPo3Sc5g8pdExedpw=;\n\tb=McLarQn+MguUonMzzXQeNRIf8dU1OQFhpyWJgqOI+Kp7lWvEWdUUEg012Q95OWjsqY\n\todhNYSfrYyP0IkwKQjlDCTFrgo/RlFa0fwI68FfFbGJ/b3mRcAChRYL6d4FwM55sgHST\n\tIeuuOh3IRlCdGeF/1ZJ03Lx5npBImC8bmbTD2Y4snPxa560nHtZuIIA0tiIRtQJouAXQ\n\tPmvK0hxPq45mnwHnHJpB1Bnx/hCdRRQ0MJKcgzWbynDdQSMvbDCKmFXs2eyAd/oWYBAY\n\tna5gdSln8Ax8H9213s2F1SClrusj4MKr6rzbgVhNf4zS04jAV3eA3F8S/6JzSu95Fy5u\n\tDnLQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ssrOPFUZVLpjswytpOgwcHjf0cjPo3Sc5g8pdExedpw=;\n\tb=sCqyk272VrEXApypOGMemC71o2r53mD3La5XJWp23RJj1rUwFLnXcZDle/i1NuldFq\n\trhW2LvsrzkR9qqM5AKPZIx4lnmb0w3i8Bq5lK51KXLss0XpCKLnvQFVHsUyVf/wlAuyg\n\tL6NuH3jOz9TRZeIZZZ7wzF0a1cACTY5AzbzCNf4HubO5X5BvyRxavUKQsKtjwdGopWag\n\tW8frHaFLgSSzbbKEgyoTdfRqLvjqAd0NsxWi3Vh/3MIfPDL77FXbFEXjY3bW1uUJadli\n\tkxo7PSbm07KbXp9ZanQNPVUAUtw/h7DQD4+vSXRpjzKXZ+YIAllR2K2BId/1GiJTvy/g\n\tutmQ==", "X-Gm-Message-State": "AOAM532iNwZ1Vy5kVyOmmS1l4JNadcTBshjezp2xLs4wlKinkZb1O6G4\n\tWVoRxYVWteu/XhCl0V/trvV0Sx1Lio0=", "X-Google-Smtp-Source": "ABdhPJyNLbclmQ41bWTCWFi2oNMOcLPzqLghWX27RGxEhzEGI0j1ImY9C0p5Wv9e1ENN1VSOdWGxeg==", "X-Received": "by 2002:a1c:4185:: with SMTP id o127mr2639525wma.8.1593167148975;\n\tFri, 26 Jun 2020 03:25:48 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Jun 2020 11:25:28 +0100", "Message-Id": "<20200626102531.1187650-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200626102531.1187650-1-naush@raspberrypi.com>", "References": "<20200626102531.1187650-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/4] libcamera: controls: Add focus Figure\n\tof Merit (FoM) control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a control to allow the IPA to return a FoM to indicate how\nin-focus a scene is. Note, this is not to be used as a means to\nimplement a focus algorithm by the application, rather an indication of\nhow in-focus a scene is.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 8c3e4c72..b46693ec 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -251,4 +251,15 @@ controls:\n higher than anyone could reasonably want. Negative values are\n not allowed. Note also that sharpening is not applied to raw\n streams.\n+\n+ - FocusFoM:\n+ type: int32_t\n+ description: |\n+ Reports a Figure of Merit (FoM) to indicate how in-focus the frame is.\n+ A larger FocusFoM value indicates a more in-focus frame. This control\n+ depends on the IPA to gather ISP statistics from the defined focus\n+ region, and combine them in a suitable way to generate a FocusFoM value.\n+ In this respect, it is not necessarily aimed a providing a way to\n+ implement a focus algorithm by the application, rather an indication of\n+ how in-focus a frame is.\n ...\n", "prefixes": [ "libcamera-devel", "1/4" ] }