Patch Detail
Show a patch.
GET /api/patches/805/?format=api
{ "id": 805, "url": "https://patchwork.libcamera.org/api/patches/805/?format=api", "web_url": "https://patchwork.libcamera.org/patch/805/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190326083902.26121-11-jacopo@jmondi.org>", "date": "2019-03-26T08:38:53", "name": "[libcamera-devel,v5,10/19] libcamera: ipu3: Create CIO2Device class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "15041ef62a1629ef97803af522456574476e77e7", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/805/mbox/", "series": [ { "id": 219, "url": "https://patchwork.libcamera.org/api/series/219/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=219", "date": "2019-03-26T08:38:43", "name": "libcamera: ipu3: Add ImgU support", "version": 5, "mbox": "https://patchwork.libcamera.org/series/219/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/805/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/805/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA0AB6110D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Mar 2019 09:38:36 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 3BEFC240005;\n\tTue, 26 Mar 2019 08:38:36 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Mar 2019 09:38:53 +0100", "Message-Id": "<20190326083902.26121-11-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190326083902.26121-1-jacopo@jmondi.org>", "References": "<20190326083902.26121-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 10/19] libcamera: ipu3: Create\n\tCIO2Device class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 Mar 2019 08:38:36 -0000" }, "content": "Group CIO2 components (cio2, csi2 and image sensor) in a class\nassociated with the CameraData, to ease management and initialization of\nCIO2 unit at camera registration time. A CIO2 unit will always be associated\nwith a single Camera only.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 320 +++++++++++++++------------\n 1 file changed, 175 insertions(+), 145 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 04cd02653711..21205b39afee 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -44,6 +44,32 @@ static int mediaBusToCIO2Format(unsigned int code)\n \t}\n }\n \n+class CIO2Device\n+{\n+public:\n+\tCIO2Device()\n+\t\t: output_(nullptr), csi2_(nullptr), sensor_(nullptr)\n+\t{\n+\t}\n+\n+\t~CIO2Device()\n+\t{\n+\t\tdelete output_;\n+\t\tdelete csi2_;\n+\t\tdelete sensor_;\n+\t}\n+\n+\tconst std::string &name() const;\n+\tint init(const MediaDevice *media, unsigned int index);\n+\n+\tV4L2Device *output_;\n+\tV4L2Subdevice *csi2_;\n+\tV4L2Subdevice *sensor_;\n+\n+\t/* Maximum sizes and the mbus code used to produce them. */\n+\tstd::pair<unsigned int, SizeRange> maxSizes_;\n+};\n+\n class PipelineHandlerIPU3 : public PipelineHandler\n {\n public:\n@@ -67,36 +93,23 @@ public:\n \tbool match(DeviceEnumerator *enumerator);\n \n private:\n+\tstatic constexpr unsigned int IPU3_BUFFER_COUNT = 4;\n+\n \tclass IPU3CameraData : public CameraData\n \t{\n \tpublic:\n \t\tIPU3CameraData(PipelineHandler *pipe)\n-\t\t\t: CameraData(pipe), cio2_(nullptr), csi2_(nullptr),\n-\t\t\t sensor_(nullptr)\n-\t\t{\n-\t\t}\n-\n-\t\t~IPU3CameraData()\n+\t\t\t: CameraData(pipe)\n \t\t{\n-\t\t\tdelete cio2_;\n-\t\t\tdelete csi2_;\n-\t\t\tdelete sensor_;\n \t\t}\n \n \t\tvoid bufferReady(Buffer *buffer);\n \n-\t\tV4L2Device *cio2_;\n-\t\tV4L2Subdevice *csi2_;\n-\t\tV4L2Subdevice *sensor_;\n+\t\tCIO2Device cio2_;\n \n \t\tStream stream_;\n-\n-\t\t/* Maximum sizes and the mbus code used to produce them. */\n-\t\tstd::pair<unsigned int, SizeRange> maxSizes_;\n \t};\n \n-\tstatic constexpr unsigned int IPU3_BUFFER_COUNT = 4;\n-\n \tIPU3CameraData *cameraData(const Camera *camera)\n \t{\n \t\treturn static_cast<IPU3CameraData *>(\n@@ -105,22 +118,22 @@ private:\n \n \tvoid registerCameras();\n \n-\tstd::shared_ptr<MediaDevice> cio2_;\n-\tstd::shared_ptr<MediaDevice> imgu_;\n+\tstd::shared_ptr<MediaDevice> cio2MediaDev_;\n+\tstd::shared_ptr<MediaDevice> imguMediaDev_;\n };\n \n PipelineHandlerIPU3::PipelineHandlerIPU3(CameraManager *manager)\n-\t: PipelineHandler(manager), cio2_(nullptr), imgu_(nullptr)\n+\t: PipelineHandler(manager), cio2MediaDev_(nullptr), imguMediaDev_(nullptr)\n {\n }\n \n PipelineHandlerIPU3::~PipelineHandlerIPU3()\n {\n-\tif (cio2_)\n-\t\tcio2_->release();\n+\tif (cio2MediaDev_)\n+\t\tcio2MediaDev_->release();\n \n-\tif (imgu_)\n-\t\timgu_->release();\n+\tif (imguMediaDev_)\n+\t\timguMediaDev_->release();\n }\n \n std::map<Stream *, StreamConfiguration>\n@@ -130,11 +143,12 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n \tstd::map<Stream *, StreamConfiguration> configs;\n \tIPU3CameraData *data = cameraData(camera);\n \tStreamConfiguration *config = &configs[&data->stream_];\n-\tSizeRange &maxRange = data->maxSizes_.second;\n+\tCIO2Device *cio2 = &data->cio2_;\n+\tSizeRange &maxRange = cio2->maxSizes_.second;\n \n \tconfig->width = maxRange.maxWidth;\n \tconfig->height = maxRange.maxHeight;\n-\tconfig->pixelFormat = data->maxSizes_.first;\n+\tconfig->pixelFormat = cio2->maxSizes_.first;\n \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n \n \tLOG(IPU3, Debug)\n@@ -150,9 +164,9 @@ int PipelineHandlerIPU3::configureStreams(Camera *camera,\n {\n \tIPU3CameraData *data = cameraData(camera);\n \tStreamConfiguration *cfg = &config[&data->stream_];\n-\tV4L2Subdevice *sensor = data->sensor_;\n-\tV4L2Subdevice *csi2 = data->csi2_;\n-\tV4L2Device *cio2 = data->cio2_;\n+\tV4L2Subdevice *sensor = data->cio2_.sensor_;\n+\tV4L2Subdevice *csi2 = data->cio2_.csi2_;\n+\tV4L2Device *cio2 = data->cio2_.output_;\n \tV4L2SubdeviceFormat subdevFormat = {};\n \tV4L2DeviceFormat devFormat = {};\n \tint ret;\n@@ -209,13 +223,14 @@ int PipelineHandlerIPU3::configureStreams(Camera *camera,\n \n int PipelineHandlerIPU3::allocateBuffers(Camera *camera, Stream *stream)\n {\n-\tIPU3CameraData *data = cameraData(camera);\n \tconst StreamConfiguration &cfg = stream->configuration();\n+\tIPU3CameraData *data = cameraData(camera);\n+\tV4L2Device *cio2 = data->cio2_.output_;\n \n \tif (!cfg.bufferCount)\n \t\treturn -EINVAL;\n \n-\tint ret = data->cio2_->exportBuffers(&stream->bufferPool());\n+\tint ret = cio2->exportBuffers(&stream->bufferPool());\n \tif (ret) {\n \t\tLOG(IPU3, Error) << \"Failed to request memory\";\n \t\treturn ret;\n@@ -227,8 +242,9 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera, Stream *stream)\n int PipelineHandlerIPU3::freeBuffers(Camera *camera, Stream *stream)\n {\n \tIPU3CameraData *data = cameraData(camera);\n+\tV4L2Device *cio2 = data->cio2_.output_;\n \n-\tint ret = data->cio2_->releaseBuffers();\n+\tint ret = cio2->releaseBuffers();\n \tif (ret) {\n \t\tLOG(IPU3, Error) << \"Failed to release memory\";\n \t\treturn ret;\n@@ -240,9 +256,10 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera, Stream *stream)\n int PipelineHandlerIPU3::start(Camera *camera)\n {\n \tIPU3CameraData *data = cameraData(camera);\n+\tV4L2Device *cio2 = data->cio2_.output_;\n \tint ret;\n \n-\tret = data->cio2_->streamOn();\n+\tret = cio2->streamOn();\n \tif (ret) {\n \t\tLOG(IPU3, Info) << \"Failed to start camera \" << camera->name();\n \t\treturn ret;\n@@ -254,8 +271,9 @@ int PipelineHandlerIPU3::start(Camera *camera)\n void PipelineHandlerIPU3::stop(Camera *camera)\n {\n \tIPU3CameraData *data = cameraData(camera);\n+\tV4L2Device *cio2 = data->cio2_.output_;\n \n-\tif (data->cio2_->streamOff())\n+\tif (cio2->streamOff())\n \t\tLOG(IPU3, Info) << \"Failed to stop camera \" << camera->name();\n \n \tPipelineHandler::stop(camera);\n@@ -264,6 +282,7 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n {\n \tIPU3CameraData *data = cameraData(camera);\n+\tV4L2Device *cio2 = data->cio2_.output_;\n \tStream *stream = &data->stream_;\n \n \tBuffer *buffer = request->findBuffer(stream);\n@@ -273,7 +292,7 @@ int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n \t\treturn -ENOENT;\n \t}\n \n-\tint ret = data->cio2_->queueBuffer(buffer);\n+\tint ret = cio2->queueBuffer(buffer);\n \tif (ret < 0)\n \t\treturn ret;\n \n@@ -312,17 +331,17 @@ bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n \t * It is safe to acquire both media devices at this point as\n \t * DeviceEnumerator::search() skips the busy ones for us.\n \t */\n-\tcio2_ = enumerator->search(cio2_dm);\n-\tif (!cio2_)\n+\tcio2MediaDev_ = enumerator->search(cio2_dm);\n+\tif (!cio2MediaDev_)\n \t\treturn false;\n \n-\tcio2_->acquire();\n+\tcio2MediaDev_->acquire();\n \n-\timgu_ = enumerator->search(imgu_dm);\n-\tif (!imgu_)\n+\timguMediaDev_ = enumerator->search(imgu_dm);\n+\tif (!imguMediaDev_)\n \t\treturn false;\n \n-\timgu_->acquire();\n+\timguMediaDev_->acquire();\n \n \t/*\n \t * Disable all links that are enabled by default on CIO2, as camera\n@@ -331,17 +350,17 @@ bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n \t * Close the CIO2 media device after, as links are enabled and should\n \t * not need to be changed after.\n \t */\n-\tif (cio2_->open())\n+\tif (cio2MediaDev_->open())\n \t\treturn false;\n \n-\tif (cio2_->disableLinks()) {\n-\t\tcio2_->close();\n+\tif (cio2MediaDev_->disableLinks()) {\n+\t\tcio2MediaDev_->close();\n \t\treturn false;\n \t}\n \n \tregisterCameras();\n \n-\tcio2_->close();\n+\tcio2MediaDev_->close();\n \n \treturn true;\n }\n@@ -355,115 +374,28 @@ void PipelineHandlerIPU3::registerCameras()\n {\n \t/*\n \t * For each CSI-2 receiver on the IPU3, create a Camera if an\n-\t * image sensor is connected to it.\n+\t * image sensor is connected to it and it can produce images in\n+\t * a compatible format.\n \t */\n \tunsigned int numCameras = 0;\n \tfor (unsigned int id = 0; id < 4; ++id) {\n-\t\tstd::string csi2Name = \"ipu3-csi2 \" + std::to_string(id);\n-\t\tMediaEntity *csi2 = cio2_->getEntityByName(csi2Name);\n-\t\tint ret;\n-\n-\t\t/*\n-\t\t * This shall not happen, as the device enumerator matched\n-\t\t * all entities described in the cio2_dm DeviceMatch.\n-\t\t *\n-\t\t * As this check is basically free, better stay safe than sorry.\n-\t\t */\n-\t\tif (!csi2)\n-\t\t\tcontinue;\n-\n-\t\tconst std::vector<MediaPad *> &pads = csi2->pads();\n-\t\tif (pads.empty())\n-\t\t\tcontinue;\n-\n-\t\t/* IPU3 CSI-2 receivers have a single sink pad at index 0. */\n-\t\tMediaPad *sink = pads[0];\n-\t\tconst std::vector<MediaLink *> &links = sink->links();\n-\t\tif (links.empty())\n-\t\t\tcontinue;\n-\n-\t\t/*\n-\t\t * Verify that the receiver is connected to a sensor, enable\n-\t\t * the media link between the two, and create a Camera with\n-\t\t * a unique name.\n-\t\t */\n-\t\tMediaLink *link = links[0];\n-\t\tMediaEntity *sensor = link->source()->entity();\n-\t\tif (sensor->function() != MEDIA_ENT_F_CAM_SENSOR)\n-\t\t\tcontinue;\n-\n-\t\tif (link->setEnabled(true))\n-\t\t\tcontinue;\n-\n-\t\tstd::unique_ptr<IPU3CameraData> data = utils::make_unique<IPU3CameraData>(this);\n-\n-\t\tstd::string cameraName = sensor->name() + \" \" + std::to_string(id);\n+\t\tstd::unique_ptr<IPU3CameraData> data =\n+\t\t\tutils::make_unique<IPU3CameraData>(this);\n \t\tstd::set<Stream *> streams{ &data->stream_ };\n-\t\tstd::shared_ptr<Camera> camera = Camera::create(this, cameraName, streams);\n-\n-\t\t/*\n-\t\t * Create and open video devices and subdevices associated with\n-\t\t * the camera.\n-\t\t *\n-\t\t * If any of these operations fails, the Camera instance won't\n-\t\t * be registered. The 'camera' shared pointer and the 'data'\n-\t\t * unique pointers go out of scope and delete the objects they\n-\t\t * manage.\n-\t\t */\n-\t\tstd::string cio2Name = \"ipu3-cio2 \" + std::to_string(id);\n-\t\tMediaEntity *cio2 = cio2_->getEntityByName(cio2Name);\n-\t\tif (!cio2) {\n-\t\t\tLOG(IPU3, Error)\n-\t\t\t\t<< \"Failed to get entity '\" << cio2Name << \"'\";\n-\t\t\tcontinue;\n-\t\t}\n-\n-\t\tdata->cio2_ = new V4L2Device(cio2);\n-\t\tret = data->cio2_->open();\n-\t\tif (ret)\n-\t\t\tcontinue;\n+\t\tCIO2Device *cio2 = &data->cio2_;\n \n-\t\t/*\n-\t\t * Make sure the sensor produces at least one image format\n-\t\t * compatible with IPU3 CIO2 requirements and cache the camera\n-\t\t * maximum sizes.\n-\t\t */\n-\t\tdata->sensor_ = new V4L2Subdevice(sensor);\n-\t\tret = data->sensor_->open();\n+\t\tint ret = cio2->init(cio2MediaDev_.get(), id);\n \t\tif (ret)\n \t\t\tcontinue;\n \n-\t\tfor (auto it : data->sensor_->formats(0)) {\n-\t\t\tint mbusCode = mediaBusToCIO2Format(it.first);\n-\t\t\tif (mbusCode < 0)\n-\t\t\t\tcontinue;\n-\n-\t\t\tfor (const SizeRange &size : it.second) {\n-\t\t\t\tSizeRange &maxSize = data->maxSizes_.second;\n-\n-\t\t\t\tif (maxSize.maxWidth < size.maxWidth &&\n-\t\t\t\t maxSize.maxHeight < size.maxHeight) {\n-\t\t\t\t\tmaxSize.maxWidth = size.maxWidth;\n-\t\t\t\t\tmaxSize.maxHeight = size.maxHeight;\n-\t\t\t\t\tdata->maxSizes_.first = mbusCode;\n-\t\t\t\t}\n-\t\t\t}\n-\t\t}\n-\t\tif (data->maxSizes_.second.maxWidth == 0) {\n-\t\t\tLOG(IPU3, Info)\n-\t\t\t\t<< \"Sensor '\" << data->sensor_->entityName()\n-\t\t\t\t<< \"' detected, but no supported image format \"\n-\t\t\t\t<< \" found: skip camera creation\";\n-\t\t\tcontinue;\n-\t\t}\n-\n-\t\tdata->csi2_ = new V4L2Subdevice(csi2);\n-\t\tret = data->csi2_->open();\n-\t\tif (ret)\n-\t\t\tcontinue;\n+\t\tstd::string cameraName = cio2->name() + \" \"\n+\t\t\t\t + std::to_string(id);\n+\t\tstd::shared_ptr<Camera> camera = Camera::create(this,\n+\t\t\t\t\t\t\t\tcameraName,\n+\t\t\t\t\t\t\t\tstreams);\n \n-\t\tdata->cio2_->bufferReady.connect(data.get(),\n-\t\t\t\t\t\t &IPU3CameraData::bufferReady);\n+\t\tcio2->output_->bufferReady.connect(data.get(),\n+\t\t\t\t\t\t &IPU3CameraData::bufferReady);\n \n \t\tregisterCamera(std::move(camera), std::move(data));\n \n@@ -484,6 +416,104 @@ void PipelineHandlerIPU3::IPU3CameraData::bufferReady(Buffer *buffer)\n \tpipe_->completeRequest(camera_, request);\n }\n \n+/*------------------------------------------------------------------------------\n+ * CIO2 Device\n+ */\n+\n+const std::string &CIO2Device::name() const\n+{\n+\treturn sensor_->entityName();\n+}\n+\n+/**\n+ * \\brief Initialize components of the CIO2 device with \\a index\n+ * \\param[in] media The CIO2 media device\n+ * \\param[in] index The CIO2 device index\n+ *\n+ * Create and open the device and subdevices in the CIO2 instance at \\a index,\n+ * if an image sensor is connected to the CSI-2 receiver of this CIO2 instance.\n+ * Enable the media links connecting the CIO2 components to prepare for capture\n+ * operations and cache the sensor maximum sizes.\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ * \\retval -ENODEV No image sensor is connected to this CIO2 instance\n+ */\n+int CIO2Device::init(const MediaDevice *media, unsigned int index)\n+{\n+\tint ret;\n+\n+\t/* Verify that a sensor subdevice is connected to this CIO2 instance. */\n+\tstd::string csi2Name = \"ipu3-csi2 \" + std::to_string(index);\n+\tMediaEntity *csi2Entity = media->getEntityByName(csi2Name);\n+\tconst std::vector<MediaPad *> &pads = csi2Entity->pads();\n+\tif (pads.empty())\n+\t\treturn -ENODEV;\n+\n+\t/* IPU3 CSI-2 receivers have a single sink pad at index 0. */\n+\tMediaPad *sink = pads[0];\n+\tconst std::vector<MediaLink *> &links = sink->links();\n+\tif (links.empty())\n+\t\treturn -ENODEV;\n+\n+\tMediaLink *link = links[0];\n+\tMediaEntity *sensorEntity = link->source()->entity();\n+\tif (sensorEntity->function() != MEDIA_ENT_F_CAM_SENSOR)\n+\t\treturn -ENODEV;\n+\n+\tret = link->setEnabled(true);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\t/*\n+\t * Now that we're sure a sensor subdevice is connected, make sure it\n+\t * produces at least one image format compatible with CIO2 requirements\n+\t * and cache the camera maximum sizes.\n+\t *\n+\t * \\todo Define when to open and close video device nodes, as they\n+\t * might impact on power consumption.\n+\t */\n+\tsensor_ = new V4L2Subdevice(sensorEntity);\n+\tret = sensor_->open();\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tfor (auto it : sensor_->formats(0)) {\n+\t\tint mbusCode = mediaBusToCIO2Format(it.first);\n+\t\tif (mbusCode < 0)\n+\t\t\tcontinue;\n+\n+\t\tfor (const SizeRange &size : it.second) {\n+\t\t\tSizeRange &maxRange = maxSizes_.second;\n+\n+\t\t\tif (maxRange.maxWidth < size.maxWidth &&\n+\t\t\t maxRange.maxHeight < size.maxHeight) {\n+\t\t\t\tmaxRange.maxWidth = size.maxWidth;\n+\t\t\t\tmaxRange.maxHeight = size.maxHeight;\n+\t\t\t\tmaxSizes_.first = mbusCode;\n+\t\t\t}\n+\t\t}\n+\t}\n+\tif (maxSizes_.second.maxWidth == 0) {\n+\t\tLOG(IPU3, Info) << \"Sensor '\" << sensor_->entityName()\n+\t\t\t\t<< \"' detected, but no supported image format \"\n+\t\t\t\t<< \" found: skip camera creation\";\n+\t\treturn -ENODEV;\n+\t}\n+\n+\tcsi2_ = new V4L2Subdevice(csi2Entity);\n+\tret = csi2_->open();\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tstd::string cio2Name = \"ipu3-cio2 \" + std::to_string(index);\n+\toutput_ = V4L2Device::fromEntityName(media, cio2Name);\n+\tret = output_->open();\n+\tif (ret)\n+\t\treturn ret;\n+\n+\treturn 0;\n+}\n+\n REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v5", "10/19" ] }