Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 72,
    "url": "https://patchwork.libcamera.org/api/patches/72/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/72/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20181221090804.8208-1-kieran.bingham@ideasonboard.com>",
    "date": "2018-12-21T09:08:04",
    "name": "[libcamera-devel] test: Use foreach iterators to simplify definitions",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "b8b3f62e79649250a579256dde40d92b89ff0473",
    "submitter": {
        "id": 4,
        "url": "https://patchwork.libcamera.org/api/people/4/?format=api",
        "name": "Kieran Bingham",
        "email": "kieran.bingham@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/72/mbox/",
    "series": [
        {
            "id": 36,
            "url": "https://patchwork.libcamera.org/api/series/36/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=36",
            "date": "2018-12-21T09:08:04",
            "name": "[libcamera-devel] test: Use foreach iterators to simplify definitions",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/36/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/72/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/72/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<kieran.bingham@ideasonboard.com>",
        "Received": [
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCD8760B0C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Dec 2018 10:08:07 +0100 (CET)",
            "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D305558;\n\tFri, 21 Dec 2018 10:08:07 +0100 (CET)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1545383287;\n\tbh=taOlGqXBiSWxM+kNjAzxBgZcpQ6gwla1N2uM7UUBJUE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=KJQdic0rCZAZIkcEs1bLbXtaTiFPkLMlFyfIskpW1HqfNYuWvULwEPmDTKdxverj8\n\tUwA46dtFKpp6MetbFic9BSpMIHlTScRex7Yx5kkNNypdyQpK6GuJuUm+9HEOM2eDh5\n\t1g1RZ5d9hGfQdTqmcgU6n+g96zoEDEpX2jBA22/g=",
        "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>",
        "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>",
        "Date": "Fri, 21 Dec 2018 09:08:04 +0000",
        "Message-Id": "<20181221090804.8208-1-kieran.bingham@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[libcamera-devel] [PATCH] test: Use foreach iterators to simplify\n\tdefinitions",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.23",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Fri, 21 Dec 2018 09:08:08 -0000"
    },
    "content": "Create two arrays, to contain public and internal test targets, and use\nthe foreach iterators to automatically generate test output targets for\neach entry in each array.\n\nThe public tests array is linked only against public libcamera headers,\nwhile tests declared in the internal_tests will have access to\nnon-public API headers from within the libcamera sources.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nThis patch applies on top of the series \"[PATCH 0/5] test: Define\nlibtest\" just posted.\n\n\n test/meson.build | 26 ++++++++++++++++++++++----\n 1 file changed, 22 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/test/meson.build b/test/meson.build\nindex 50ec11853203..754527324c7d 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -12,8 +12,26 @@ test_includes_internal = [\n   libcamera_internal_includes,\n ]\n \n-test_init = executable('test_init', 'init.cpp',\n-                       link_with : test_libraries,\n-                       include_directories : test_includes_public)\n+public_tests = [\n+  [ 'test_init',      'init.cpp' ],\n+]\n+\n+internal_tests = [\n+\n+]\n+\n+foreach t : public_tests\n+  exe = executable(t[0], t[1],\n+                   link_with : test_libraries,\n+                   include_directories : test_includes_public)\n+\n+  test(t[0], exe)\n+endforeach\n+\n+foreach t : internal_tests\n+  exe = executable(t[0], t[1],\n+                   link_with : test_libraries,\n+                   include_directories : test_includes_internal)\n \n-test('Initialisation test', test_init)\n+  test(t[0], exe)\n+endforeach\n",
    "prefixes": [
        "libcamera-devel"
    ]
}