Patch Detail
Show a patch.
GET /api/patches/634/?format=api
{ "id": 634, "url": "https://patchwork.libcamera.org/api/patches/634/?format=api", "web_url": "https://patchwork.libcamera.org/patch/634/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190226162641.12116-5-jacopo@jmondi.org>", "date": "2019-02-26T16:26:37", "name": "[libcamera-devel,v3,4/8] libcamera: v4l2_subdevice: Update crop/compose rectangle", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "919e24a57ca410eb704f63f323cf4d31676401f4", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/634/mbox/", "series": [ { "id": 193, "url": "https://patchwork.libcamera.org/api/series/193/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=193", "date": "2019-02-26T16:26:33", "name": "v4l2_(sub)dev: improvements and tests", "version": 3, "mbox": "https://patchwork.libcamera.org/series/193/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/634/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/634/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABC9D610B7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Feb 2019 17:26:20 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3E6F26000D;\n\tTue, 26 Feb 2019 16:26:20 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Feb 2019 17:26:37 +0100", "Message-Id": "<20190226162641.12116-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190226162641.12116-1-jacopo@jmondi.org>", "References": "<20190226162641.12116-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 4/8] libcamera: v4l2_subdevice: Update\n\tcrop/compose rectangle", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 Feb 2019 16:26:21 -0000" }, "content": "Update the crop/compose rectangle provided to setCrop()/setCompose()\nmethods with the rectangle sizes set by the device driver after a\nS_SELECTION ioctl operation.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_subdevice.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex f81a521f9e2a..a043a07ff156 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -385,6 +385,11 @@ int V4L2Subdevice::setSelection(unsigned int pad, unsigned int target,\n \t\treturn ret;\n \t}\n \n+\trect->y = sel.r.left;\n+\trect->x = sel.r.top;\n+\trect->w = sel.r.width;\n+\trect->h = sel.r.height;\n+\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "v3", "4/8" ] }