Patch Detail
Show a patch.
GET /api/patches/629/?format=api
{ "id": 629, "url": "https://patchwork.libcamera.org/api/patches/629/?format=api", "web_url": "https://patchwork.libcamera.org/patch/629/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190226021857.28255-9-niklas.soderlund@ragnatech.se>", "date": "2019-02-26T02:18:57", "name": "[libcamera-devel,8/8] libcamera: camera: make sure camera is configured before starting", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7b7e0e4e67cf1ba8ce91babdf47f53dc7646455b", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/629/mbox/", "series": [ { "id": 192, "url": "https://patchwork.libcamera.org/api/series/192/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=192", "date": "2019-02-26T02:18:50", "name": "libcamera: improve validation of camera operations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/192/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/629/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/629/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1ED0610B7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Feb 2019 03:19:30 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid f22da30a-396c-11e9-985a-005056917f90;\n\tTue, 26 Feb 2019 03:19:29 +0100 (CET)" ], "X-Halon-ID": "f22da30a-396c-11e9-985a-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Feb 2019 03:18:57 +0100", "Message-Id": "<20190226021857.28255-9-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190226021857.28255-1-niklas.soderlund@ragnatech.se>", "References": "<20190226021857.28255-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 8/8] libcamera: camera: make sure camera\n\tis configured before starting", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 Feb 2019 02:19:30 -0000" }, "content": "If the camera is not configured there is little use to start it. Add a\ncheck to make sure the camera is configured before it's started.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/camera.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex ba8638009992170f..cbc34599d25e5ed5 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -423,12 +423,19 @@ int Camera::queueRequest(Request *request)\n *\n * \\return 0 on success or a negative error code\n * \\retval -EACCES The camera is not in a state where it can be started.\n+ * \\retval -EINVAL The camera is not configured.\n */\n int Camera::start()\n {\n \tif (!stateIs(Acquired))\n \t\treturn -EACCES;\n \n+\tif (activeStreams_.empty()) {\n+\t\tLOG(Camera, Error)\n+\t\t\t<< \"Can't start camera without configuration\";\n+\t\treturn -EINVAL;\n+\t}\n+\n \tLOG(Camera, Debug) << \"Starting capture\";\n \n \tint ret = pipe_->start(this);\n", "prefixes": [ "libcamera-devel", "8/8" ] }