Patch Detail
Show a patch.
GET /api/patches/607/?format=api
{ "id": 607, "url": "https://patchwork.libcamera.org/api/patches/607/?format=api", "web_url": "https://patchwork.libcamera.org/patch/607/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190224171407.7856-4-niklas.soderlund@ragnatech.se>", "date": "2019-02-24T17:14:06", "name": "[libcamera-devel,v2,3/4] cam: fix printing of camera name", "commit_ref": "71e84c22dafbc45836c971f2154463ccf20077fc", "pull_url": null, "state": "accepted", "archived": false, "hash": "f918140e52daa03c35ddf0e84403a9b76e4c91a7", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/607/mbox/", "series": [ { "id": 189, "url": "https://patchwork.libcamera.org/api/series/189/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=189", "date": "2019-02-24T17:14:03", "name": "cam: improve error paths", "version": 2, "mbox": "https://patchwork.libcamera.org/series/189/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/607/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/607/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D142B610B7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Feb 2019 18:14:27 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid a32c588e-3857-11e9-a58a-005056917f90;\n\tSun, 24 Feb 2019 18:14:26 +0100 (CET)" ], "X-Halon-ID": "a32c588e-3857-11e9-a58a-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 24 Feb 2019 18:14:06 +0100", "Message-Id": "<20190224171407.7856-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190224171407.7856-1-niklas.soderlund@ragnatech.se>", "References": "<20190224171407.7856-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/4] cam: fix printing of camera name", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 24 Feb 2019 17:14:28 -0000" }, "content": "Since commit c8c546fe99a343c1 (\"cam: options: Add option type handling\nto options parser\") introduced type handling for options the context the\noption is read became important. When reading the camera option for\nprinting there is no explicit context to print it as a string and\ninstead the int context was chosen resulting in:\n\n $ cam --camera foo\n Camera 0 not found\n\nWhile the expected output is:\n\n $ cam --camera foo\n Camera foo not found\n\nFix this by providing the correct context for the camera option when\nprinting it.\n\nFixes: c8c546fe99a343c1 (\"cam: options: Add option type handling to options parser\")\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/main.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 30267970a2c8485f..522d2f0d3373dc25 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -233,7 +233,8 @@ int main(int argc, char **argv)\n \tif (options.isSet(OptCamera)) {\n \t\tcamera = cm->get(options[OptCamera]);\n \t\tif (!camera) {\n-\t\t\tstd::cout << \"Camera \" << options[OptCamera]\n+\t\t\tstd::cout << \"Camera \"\n+\t\t\t\t << std::string(options[OptCamera])\n \t\t\t\t << \" not found\" << std::endl;\n \t\t\tgoto out;\n \t\t}\n", "prefixes": [ "libcamera-devel", "v2", "3/4" ] }