Patch Detail
Show a patch.
GET /api/patches/605/?format=api
{ "id": 605, "url": "https://patchwork.libcamera.org/api/patches/605/?format=api", "web_url": "https://patchwork.libcamera.org/patch/605/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190224171407.7856-2-niklas.soderlund@ragnatech.se>", "date": "2019-02-24T17:14:04", "name": "[libcamera-devel,v2,1/4] cam: free allocated buffers when done capturing", "commit_ref": "24cb5638533d19f77dd2f7f629f05eb07484ab97", "pull_url": null, "state": "accepted", "archived": false, "hash": "078f908e483f0845608f29547fb735c3be41968e", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/605/mbox/", "series": [ { "id": 189, "url": "https://patchwork.libcamera.org/api/series/189/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=189", "date": "2019-02-24T17:14:03", "name": "cam: improve error paths", "version": 2, "mbox": "https://patchwork.libcamera.org/series/189/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/605/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/605/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A82B4601E2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Feb 2019 18:14:26 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid a2404782-3857-11e9-a58a-005056917f90;\n\tSun, 24 Feb 2019 18:14:25 +0100 (CET)" ], "X-Halon-ID": "a2404782-3857-11e9-a58a-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 24 Feb 2019 18:14:04 +0100", "Message-Id": "<20190224171407.7856-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190224171407.7856-1-niklas.soderlund@ragnatech.se>", "References": "<20190224171407.7856-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/4] cam: free allocated buffers when\n\tdone capturing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 24 Feb 2019 17:14:26 -0000" }, "content": "The allocated buffers needs to be freed once the application is done\nwith them.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/main.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 9b67ab75a6a1663e..b034eb25429abeb3 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -163,7 +163,8 @@ static int capture()\n \t\tRequest *request = camera->createRequest();\n \t\tif (!request) {\n \t\t\tstd::cerr << \"Can't create request\" << std::endl;\n-\t\t\treturn -ENOMEM;\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto out;\n \t\t}\n \n \t\tstd::map<Stream *, Buffer *> map;\n@@ -171,13 +172,13 @@ static int capture()\n \t\tret = request->setBuffers(map);\n \t\tif (ret < 0) {\n \t\t\tstd::cerr << \"Can't set buffers for request\" << std::endl;\n-\t\t\treturn ret;\n+\t\t\tgoto out;\n \t\t}\n \n \t\tret = camera->queueRequest(request);\n \t\tif (ret < 0) {\n \t\t\tstd::cerr << \"Can't queue request\" << std::endl;\n-\t\t\treturn ret;\n+\t\t\tgoto out;\n \t\t}\n \t}\n \n@@ -187,6 +188,9 @@ static int capture()\n \tret = loop->exec();\n \n \tcamera->stop();\n+out:\n+\tcamera->freeBuffers();\n+\n \treturn ret;\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }