Patch Detail
Show a patch.
GET /api/patches/600/?format=api
{ "id": 600, "url": "https://patchwork.libcamera.org/api/patches/600/?format=api", "web_url": "https://patchwork.libcamera.org/patch/600/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190220235939.25147-2-niklas.soderlund@ragnatech.se>", "date": "2019-02-20T23:59:36", "name": "[libcamera-devel,1/4] libcamera: pipeline_handler: extend documentation for configureStreams()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "949900004cff3981f68be306d4195e8e5bb3e665", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/600/mbox/", "series": [ { "id": 188, "url": "https://patchwork.libcamera.org/api/series/188/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=188", "date": "2019-02-20T23:59:35", "name": "libcamera: enforce stream configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/188/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/600/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/600/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C067660100\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Feb 2019 00:59:53 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 9b8396a3-356b-11e9-b530-005056917a89;\n\tThu, 21 Feb 2019 00:59:50 +0100 (CET)" ], "X-Halon-ID": "9b8396a3-356b-11e9-b530-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Feb 2019 00:59:36 +0100", "Message-Id": "<20190220235939.25147-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190220235939.25147-1-niklas.soderlund@ragnatech.se>", "References": "<20190220235939.25147-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/4] libcamera: pipeline_handler: extend\n\tdocumentation for configureStreams()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 20 Feb 2019 23:59:54 -0000" }, "content": "Extend the documentation to explicitly state that the pipeline handler\nimplementations are responsible to validate the requested configuration\ncan be exactly satisfied by the hardware.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline_handler.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 616838fed702fec7..991674b34286ab16 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -136,6 +136,15 @@ PipelineHandler::~PipelineHandler()\n * is the Camera class which will receive configuration to apply from the\n * application.\n *\n+ * Each pipeline handler implementation is responsible to validate that the\n+ * configuration requested in \\a config is exactly the same that is actually\n+ * programmed and accepted by the hardware itself. If the format programmed\n+ * differers from the one requested the pipeline handler shall return the\n+ * error -EINVAL. If one streams configuration can't be satisfied by the\n+ * hardware the pipeline handler does not need to try and program any other\n+ * streams in \\a config and the whole operation shall be consider to have\n+ * failed.\n+ *\n * \\return 0 on success or a negative error code on error.\n */\n \n", "prefixes": [ "libcamera-devel", "1/4" ] }