Patch Detail
Show a patch.
GET /api/patches/574/?format=api
{ "id": 574, "url": "https://patchwork.libcamera.org/api/patches/574/?format=api", "web_url": "https://patchwork.libcamera.org/patch/574/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190213151027.6376-6-kieran.bingham@ideasonboard.com>", "date": "2019-02-13T15:10:24", "name": "[libcamera-devel,v2,5/8] libcamera: v4l2_device: Use non-interlaced frames", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f153a2205c6ba3de3a62dffcb0b3716a6a380708", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/574/mbox/", "series": [ { "id": 181, "url": "https://patchwork.libcamera.org/api/series/181/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=181", "date": "2019-02-13T15:10:19", "name": "libcamera: v4l2_device buffer sharing", "version": 2, "mbox": "https://patchwork.libcamera.org/series/181/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/574/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/574/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0DA8610C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 16:10:33 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F97385;\n\tWed, 13 Feb 2019 16:10:33 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550070633;\n\tbh=dYjG83c6VptCUqY7LhSBvNFMu+c2KNqlfTY7UWDl0ZI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jya/kPrL4POq3FyiM4ogNrEvQO2r0kxrB+tbbQK4AGSyWsqJfPF+BvLbTDuj/Me5T\n\t/nPW9VkvhglgNQSZhQZAwT/7rrO3vSxKLWjmIVAH3eIvC0VEgzEKqEbQ1mqmLUcB6u\n\tgiuJoMwoIS1QNPV2d9GP1ecnWif7xaUdqH4DXmGA=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 13 Feb 2019 15:10:24 +0000", "Message-Id": "<20190213151027.6376-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20190213151027.6376-1-kieran.bingham@ideasonboard.com>", "References": "<20190213151027.6376-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 5/8] libcamera: v4l2_device: Use\n\tnon-interlaced frames", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 13 Feb 2019 15:10:35 -0000" }, "content": "Use V4L2_FIELD_NONE where applicable to disable support for interlaced frames.\nWe are unlikely to support interlaced frames on cameras so hardcode this field\ntype for now. If we decide to support interlacing later it can be revisited.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/v4l2_device.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 8c038239cf24..d690be9823f5 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -423,6 +423,7 @@ int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format)\n \tpix->height = format->height;\n \tpix->pixelformat = format->fourcc;\n \tpix->bytesperline = format->planes[0].bpl;\n+\tpix->field = V4L2_FIELD_NONE;\n \n \tret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Format);\n \tif (ret) {\n@@ -483,6 +484,7 @@ int V4L2Device::setFormatMultiplane(V4L2DeviceFormat *format)\n \tpix->height = format->height;\n \tpix->pixelformat = format->fourcc;\n \tpix->num_planes = format->planesCount;\n+\tpix->field = V4L2_FIELD_NONE;\n \n \tfor (unsigned int i = 0; i < pix->num_planes; ++i) {\n \t\tpix->plane_fmt[i].bytesperline = format->planes[i].bpl;\n@@ -681,6 +683,7 @@ int V4L2Device::queueBuffer(Buffer *buffer)\n \tbuf.index = buffer->index();\n \tbuf.type = bufferType_;\n \tbuf.memory = memoryType_;\n+\tbuf.field = V4L2_FIELD_NONE;\n \n \tif (V4L2_TYPE_IS_MULTIPLANAR(buf.type)) {\n \t\tbuf.length = buffer->planes().size();\n", "prefixes": [ "libcamera-devel", "v2", "5/8" ] }