Patch Detail
Show a patch.
GET /api/patches/568/?format=api
{ "id": 568, "url": "https://patchwork.libcamera.org/api/patches/568/?format=api", "web_url": "https://patchwork.libcamera.org/patch/568/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190213131130.27388-1-kieran.bingham@ideasonboard.com>", "date": "2019-02-13T13:11:30", "name": "[libcamera-devel] libcamera: v4l2_device: streamOff() when releaseing buffers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eb038516c58b5a3e0f0fdb32d4da44739bff4346", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/568/mbox/", "series": [ { "id": 180, "url": "https://patchwork.libcamera.org/api/series/180/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=180", "date": "2019-02-13T13:11:30", "name": "[libcamera-devel] libcamera: v4l2_device: streamOff() when releaseing buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/180/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/568/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/568/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C1F06101F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 14:11:35 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B08A385;\n\tWed, 13 Feb 2019 14:11:34 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550063494;\n\tbh=x/T6d+T1PpWAj96V+W561Bu8vz2w1aS4EchqNwjjt6s=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Lp3Lnv7YMzVDI8+XwovDB00Y/p+y5gDu60u7Nbyk//8CBLno4SRToy7MPVekjrZsA\n\tgPX3+9Ly90mTpdo0GKMRJtEi5XKkH+/vXYGLuCNxYRGPu+A5TF9bZlz1gjXUkwTKgB\n\tLb4/wirVDVy9Zy+chIw4Yuqfvi7Xwg7a2L7wMmLA=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 13 Feb 2019 13:11:30 +0000", "Message-Id": "<20190213131130.27388-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: v4l2_device: streamOff() when\n\treleaseing buffers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 13 Feb 2019 13:11:35 -0000" }, "content": "We must ensure that the stream is disabled before releasing buffers. It will\nnot hurt to call streamOff() even if it is already off before releasing any\nbuffers back to the device.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/v4l2_device.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex afcdc1ea0161..5c5e95c9c9da 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -673,6 +673,8 @@ int V4L2Device::releaseBuffers()\n {\n \tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n \n+\tstreamOff();\n+\n \trequestBuffers(0);\n \tbufferPool_ = nullptr;\n \n", "prefixes": [ "libcamera-devel" ] }