Patch Detail
Show a patch.
GET /api/patches/560/?format=api
{ "id": 560, "url": "https://patchwork.libcamera.org/api/patches/560/?format=api", "web_url": "https://patchwork.libcamera.org/patch/560/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190212222912.9089-1-laurent.pinchart@ideasonboard.com>", "date": "2019-02-12T22:29:12", "name": "[libcamera-devel] cam: options: Fix coding style issue related to templates", "commit_ref": "0c0b1e4dbe2b436a60c26cbaa68556988bcbf005", "pull_url": null, "state": "accepted", "archived": false, "hash": "f360484a5b5e5342afd7714804f72d67c8f2afcc", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/560/mbox/", "series": [ { "id": 177, "url": "https://patchwork.libcamera.org/api/series/177/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=177", "date": "2019-02-12T22:29:12", "name": "[libcamera-devel] cam: options: Fix coding style issue related to templates", "version": 1, "mbox": "https://patchwork.libcamera.org/series/177/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/560/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/560/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BFC760B21\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Feb 2019 23:29:19 +0100 (CET)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B97785\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Feb 2019 23:29:19 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550010559;\n\tbh=6q4UTKnvDHwKCyEW5sNQ0tRcavxKxkxfJEiSV62CwWs=;\n\th=From:To:Subject:Date:From;\n\tb=RvV7l9JrtDEpOAJ+By2F7QZEMQSLg8RXCdf+1wC5z4RhuO3a/mXYpHcqkca62FKU4\n\tzUAryplDaM1m02Vdv94+x6l2Mff97QHjy9FcItlQ3Rb+sZF3moyqxFCIOfyCd3GowJ\n\tjA6SmslzeqynDm0LhrcuY926RAOfCG1/3jNVbQj4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 13 Feb 2019 00:29:12 +0200", "Message-Id": "<20190212222912.9089-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] cam: options: Fix coding style issue\n\trelated to templates", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 Feb 2019 22:29:19 -0000" }, "content": "Our coding style doesn't add a space after the template keyword. Fix the\nsource code accordingly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.cpp | 10 +++++-----\n src/cam/options.h | 2 +-\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex eb59376fa459..655aa36bb9c9 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -39,25 +39,25 @@ const char *Option::typeName() const\n * OptionBase<T>\n */\n \n-template <typename T>\n+template<typename T>\n bool OptionsBase<T>::valid() const\n {\n \treturn !values_.empty();\n }\n \n-template <typename T>\n+template<typename T>\n bool OptionsBase<T>::isSet(const T &opt) const\n {\n \treturn values_.find(opt) != values_.end();\n }\n \n-template <typename T>\n+template<typename T>\n const OptionValue &OptionsBase<T>::operator[](const T &opt) const\n {\n \treturn values_.find(opt)->second;\n }\n \n-template <typename T>\n+template<typename T>\n bool OptionsBase<T>::parseValue(const T &opt, const Option &option,\n \t\t\t\tconst char *optarg)\n {\n@@ -100,7 +100,7 @@ bool OptionsBase<T>::parseValue(const T &opt, const Option &option,\n \treturn true;\n }\n \n-template <typename T>\n+template<typename T>\n void OptionsBase<T>::clear()\n {\n \tvalues_.clear();\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex 2d3aa50b5051..745f4a4a3a43 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -41,7 +41,7 @@ struct Option {\n \tconst char *typeName() const;\n };\n \n-template <typename T>\n+template<typename T>\n class OptionsBase\n {\n public:\n", "prefixes": [ "libcamera-devel" ] }