Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 549,
    "url": "https://patchwork.libcamera.org/api/patches/549/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/549/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20190208124100.7498-1-niklas.soderlund@ragnatech.se>",
    "date": "2019-02-08T12:41:00",
    "name": "[libcamera-devel] libcamera: pipeline: vimc: fix name of pipeline handler class",
    "commit_ref": "fd38fa66c38e80ca0974ca9aba2a0009f886028f",
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "cc0a66b8f8c9f04cca36364831a73be5d350fa08",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/549/mbox/",
    "series": [
        {
            "id": 172,
            "url": "https://patchwork.libcamera.org/api/series/172/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=172",
            "date": "2019-02-08T12:41:00",
            "name": "[libcamera-devel] libcamera: pipeline: vimc: fix name of pipeline handler class",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/172/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/549/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/549/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3472E60B0E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Feb 2019 13:41:14 +0100 (CET)",
            "from localhost.localdomain (unknown [81.164.19.127])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid cb43267f-2b9e-11e9-b5ae-0050569116f7;\n\tFri, 08 Feb 2019 13:41:08 +0100 (CET)"
        ],
        "X-Halon-ID": "cb43267f-2b9e-11e9-b5ae-0050569116f7",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Fri,  8 Feb 2019 13:41:00 +0100",
        "Message-Id": "<20190208124100.7498-1-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.20.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: vimc: fix name of\n\tpipeline handler class",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.23",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Fri, 08 Feb 2019 12:41:14 -0000"
    },
    "content": "Rename the VIMC pipeline handler to match the naming convection.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/vimc.cpp | 28 ++++++++++++++--------------\n 1 file changed, 14 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 0e9ad7b59ee57574..46840a4f410456d2 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -19,11 +19,11 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(VIMC)\n \n-class PipeHandlerVimc : public PipelineHandler\n+class PipelineHandlerVimc : public PipelineHandler\n {\n public:\n-\tPipeHandlerVimc(CameraManager *manager);\n-\t~PipeHandlerVimc();\n+\tPipelineHandlerVimc(CameraManager *manager);\n+\t~PipelineHandlerVimc();\n \n \tstd::map<Stream *, StreamConfiguration>\n \tstreamConfiguration(Camera *camera,\n@@ -47,12 +47,12 @@ private:\n \tStream stream_;\n };\n \n-PipeHandlerVimc::PipeHandlerVimc(CameraManager *manager)\n+PipelineHandlerVimc::PipelineHandlerVimc(CameraManager *manager)\n \t: PipelineHandler(manager), media_(nullptr), video_(nullptr)\n {\n }\n \n-PipeHandlerVimc::~PipeHandlerVimc()\n+PipelineHandlerVimc::~PipelineHandlerVimc()\n {\n \tdelete video_;\n \n@@ -61,7 +61,7 @@ PipeHandlerVimc::~PipeHandlerVimc()\n }\n \n std::map<Stream *, StreamConfiguration>\n-PipeHandlerVimc::streamConfiguration(Camera *camera,\n+PipelineHandlerVimc::streamConfiguration(Camera *camera,\n \t\t\t\t     std::vector<Stream *> &streams)\n {\n \tstd::map<Stream *, StreamConfiguration> configs;\n@@ -79,7 +79,7 @@ PipeHandlerVimc::streamConfiguration(Camera *camera,\n \treturn configs;\n }\n \n-int PipeHandlerVimc::configureStreams(Camera *camera,\n+int PipelineHandlerVimc::configureStreams(Camera *camera,\n \t\t\t\t      std::map<Stream *, StreamConfiguration> &config)\n {\n \tStreamConfiguration *cfg = &config[&stream_];\n@@ -95,7 +95,7 @@ int PipeHandlerVimc::configureStreams(Camera *camera,\n \treturn video_->setFormat(&format);\n }\n \n-int PipeHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n+int PipelineHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n {\n \tconst StreamConfiguration &cfg = stream->configuration();\n \n@@ -104,22 +104,22 @@ int PipeHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n \treturn video_->exportBuffers(cfg.bufferCount, &stream->bufferPool());\n }\n \n-int PipeHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n+int PipelineHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n {\n \treturn video_->releaseBuffers();\n }\n \n-int PipeHandlerVimc::start(const Camera *camera)\n+int PipelineHandlerVimc::start(const Camera *camera)\n {\n \treturn video_->streamOn();\n }\n \n-void PipeHandlerVimc::stop(const Camera *camera)\n+void PipelineHandlerVimc::stop(const Camera *camera)\n {\n \tvideo_->streamOff();\n }\n \n-int PipeHandlerVimc::queueRequest(const Camera *camera, Request *request)\n+int PipelineHandlerVimc::queueRequest(const Camera *camera, Request *request)\n {\n \tBuffer *buffer = request->findBuffer(&stream_);\n \tif (!buffer) {\n@@ -134,7 +134,7 @@ int PipeHandlerVimc::queueRequest(const Camera *camera, Request *request)\n \treturn 0;\n }\n \n-bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n+bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n {\n \tDeviceMatch dm(\"vimc\");\n \n@@ -169,6 +169,6 @@ bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n \treturn true;\n }\n \n-REGISTER_PIPELINE_HANDLER(PipeHandlerVimc);\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n \n } /* namespace libcamera */\n",
    "prefixes": [
        "libcamera-devel"
    ]
}