Patch Detail
Show a patch.
GET /api/patches/541/?format=api
{ "id": 541, "url": "https://patchwork.libcamera.org/api/patches/541/?format=api", "web_url": "https://patchwork.libcamera.org/patch/541/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190206060818.13907-27-laurent.pinchart@ideasonboard.com>", "date": "2019-02-06T06:08:17", "name": "[libcamera-devel,26/27] cam: Add BufferWriter helper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "34330f9ba8b6eb6263472d3e818a4f7c6db734f2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/541/mbox/", "series": [ { "id": 170, "url": "https://patchwork.libcamera.org/api/series/170/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=170", "date": "2019-02-06T06:07:51", "name": "Capture frames throught requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/170/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/541/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/541/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3BAE6104C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Feb 2019 07:08:29 +0100 (CET)", "from pendragon.ideasonboard.com (d51A4137F.access.telenet.be\n\t[81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7146C2D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Feb 2019 07:08:29 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549433309;\n\tbh=YV6PONACtOw0/26YMEsBf0W+VyGYT+We1vhnqpPw4Ag=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=cyA8wSHf1/mISH5pFB/O9Q6ARYR5YWzh/WjtQlVLQxLo0aQkjTZju1QC6+uK5L2XF\n\tpzyQyKz22yajNQGjj4h2yPUGan9fZqs1ft/X+iWXB8hq/jDMhTDuaS0qdeHuBSC0TA\n\t1mES401DvDhCwsAofjHEvcLRfoSVqqZbSdrESWVM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Feb 2019 08:08:17 +0200", "Message-Id": "<20190206060818.13907-27-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>", "References": "<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 26/27] cam: Add BufferWriter helper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 06 Feb 2019 06:08:30 -0000" }, "content": "From: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nAdd a simpler helper to allow the cam application to write raw captured\nframes to disk.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/buffer_writer.cpp | 63 +++++++++++++++++++++++++++++++++++++++\n src/cam/buffer_writer.h | 25 ++++++++++++++++\n src/cam/meson.build | 1 +\n 3 files changed, 89 insertions(+)\n create mode 100644 src/cam/buffer_writer.cpp\n create mode 100644 src/cam/buffer_writer.h", "diff": "diff --git a/src/cam/buffer_writer.cpp b/src/cam/buffer_writer.cpp\nnew file mode 100644\nindex 000000000000..2d2258b4cd1c\n--- /dev/null\n+++ b/src/cam/buffer_writer.cpp\n@@ -0,0 +1,63 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * buffer_writer.cpp - Buffer writer\n+ */\n+\n+#include <fcntl.h>\n+#include <iomanip>\n+#include <iostream>\n+#include <sstream>\n+#include <string.h>\n+#include <unistd.h>\n+\n+#include \"buffer_writer.h\"\n+\n+BufferWriter::BufferWriter(const std::string &pattern)\n+\t: pattern_(pattern)\n+{\n+}\n+\n+int BufferWriter::write(libcamera::Buffer *buffer)\n+{\n+\tstd::string filename;\n+\tsize_t pos;\n+\tint fd, ret = 0;\n+\n+\tfilename = pattern_;\n+\tpos = filename.find_first_of('#');\n+\tif (pos != std::string::npos) {\n+\t\tstd::stringstream ss;\n+\t\tss << std::setw(6) << std::setfill('0') << buffer->sequence();\n+\t\tfilename.replace(pos, 1, ss.str());\n+\t}\n+\n+\tfd = open(filename.c_str(), O_CREAT | O_WRONLY |\n+\t\t (pos == std::string::npos ? O_APPEND : O_TRUNC),\n+\t\t S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH);\n+\tif (fd == -1)\n+\t\treturn -errno;\n+\n+\tfor (libcamera::Plane &plane : buffer->planes()) {\n+\t\tvoid *data = plane.mem();\n+\t\tunsigned int length = plane.length();\n+\n+\t\tret = ::write(fd, data, length);\n+\t\tif (ret < 0) {\n+\t\t\tret = -errno;\n+\t\t\tstd::cerr << \"write error: \" << strerror(-ret)\n+\t\t\t\t << std::endl;\n+\t\t\tbreak;\n+\t\t} else if (ret != (int)length) {\n+\t\t\tstd::cerr << \"write error: only \" << ret\n+\t\t\t\t << \" bytes written instead of \"\n+\t\t\t\t << length << std::endl;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tclose(fd);\n+\n+\treturn ret;\n+}\ndiff --git a/src/cam/buffer_writer.h b/src/cam/buffer_writer.h\nnew file mode 100644\nindex 000000000000..9705773e0e39\n--- /dev/null\n+++ b/src/cam/buffer_writer.h\n@@ -0,0 +1,25 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * buffer_writer.h - Buffer writer\n+ */\n+#ifndef __LIBCAMERA_BUFFER_WRITER_H__\n+#define __LIBCAMERA_BUFFER_WRITER_H__\n+\n+#include <string>\n+\n+#include <libcamera/buffer.h>\n+\n+class BufferWriter\n+{\n+public:\n+\tBufferWriter(const std::string &pattern = \"frame-#.bin\");\n+\n+\tint write(libcamera::Buffer *buffer);\n+\n+private:\n+\tstd::string pattern_;\n+};\n+\n+#endif /* __LIBCAMERA_BUFFER_WRITER_H__ */\ndiff --git a/src/cam/meson.build b/src/cam/meson.build\nindex cc647523955f..1a1244fe25cd 100644\n--- a/src/cam/meson.build\n+++ b/src/cam/meson.build\n@@ -1,4 +1,5 @@\n cam_sources = files([\n+ 'buffer_writer.cpp',\n 'event_loop.cpp',\n 'main.cpp',\n 'options.cpp',\n", "prefixes": [ "libcamera-devel", "26/27" ] }