Patch Detail
Show a patch.
GET /api/patches/533/?format=api
{ "id": 533, "url": "https://patchwork.libcamera.org/api/patches/533/?format=api", "web_url": "https://patchwork.libcamera.org/patch/533/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190206060818.13907-19-laurent.pinchart@ideasonboard.com>", "date": "2019-02-06T06:08:09", "name": "[libcamera-devel,18/27] libcamera: camera: Cache the stream configuration in the stream object", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0067d295688a3b596cbd8fe4be5a591f828fc533", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/533/mbox/", "series": [ { "id": 170, "url": "https://patchwork.libcamera.org/api/series/170/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=170", "date": "2019-02-06T06:07:51", "name": "Capture frames throught requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/170/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/533/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/533/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA08161047\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Feb 2019 07:08:27 +0100 (CET)", "from pendragon.ideasonboard.com (d51A4137F.access.telenet.be\n\t[81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 865C22D9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Feb 2019 07:08:27 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549433307;\n\tbh=uPiFFS2vvE9G9XTdMsPnGoZdY/fhrPgCLtxrFCH/fBo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=HMLSff5Cbtrg+8dc92xy49Qyl4/bHksRbqWqvSjfIY2QbYVNsi7H/vp9ACXCoSKWQ\n\tRkuRCoG6RqlJ9KSD/vRV0RLUsVtSjgtc2YtCjUFMoTWJJAt+IR3WWhlBd6I7EhfRYJ\n\tZMa4P4rGrMelOcfbOdOZq3FNYsiQieEO+xFdEIao=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Feb 2019 08:08:09 +0200", "Message-Id": "<20190206060818.13907-19-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>", "References": "<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 18/27] libcamera: camera: Cache the stream\n\tconfiguration in the stream object", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 06 Feb 2019 06:08:29 -0000" }, "content": "From: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nThe API towards the application and pipeline handler can be simplified\nif the camera caches which streams have been selected and their\nrespective configuration.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/camera.h | 1 +\n src/libcamera/camera.cpp | 15 ++++++++++++++-\n 2 files changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 36bf1cbb215b..1c0ee07c2a22 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -55,6 +55,7 @@ private:\n \tstd::shared_ptr<PipelineHandler> pipe_;\n \tstd::string name_;\n \tstd::vector<Stream *> streams_;\n+\tstd::vector<Stream *> activeStreams_;\n \n \tbool acquired_;\n \tbool disconnected_;\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 62291d2c9e6c..3f7b805b09a2 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -253,7 +253,20 @@ int Camera::configureStreams(std::map<Stream *, StreamConfiguration> &config)\n \t\treturn -EINVAL;\n \t}\n \n-\treturn pipe_->configureStreams(this, config);\n+\tret = pipe_->configureStreams(this, config);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tactiveStreams_.clear();\n+\tfor (auto const &iter : config) {\n+\t\tStream *stream = iter.first;\n+\t\tconst StreamConfiguration &cfg = iter.second;\n+\n+\t\tstream->configuration_ = cfg;\n+\t\tactiveStreams_.push_back(stream);\n+\t}\n+\n+\treturn 0;\n }\n \n int Camera::exclusiveAccess()\n", "prefixes": [ "libcamera-devel", "18/27" ] }