Patch Detail
Show a patch.
GET /api/patches/519/?format=api
{ "id": 519, "url": "https://patchwork.libcamera.org/api/patches/519/?format=api", "web_url": "https://patchwork.libcamera.org/patch/519/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190206060818.13907-5-laurent.pinchart@ideasonboard.com>", "date": "2019-02-06T06:07:55", "name": "[libcamera-devel,04/27] test: v4l2_device: Add request_buffers test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2f3ac9ac20ec894da6467fdb1c5a26aac90ec789", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/519/mbox/", "series": [ { "id": 170, "url": "https://patchwork.libcamera.org/api/series/170/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=170", "date": "2019-02-06T06:07:51", "name": "Capture frames throught requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/170/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/519/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/519/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5013661022\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Feb 2019 07:08:24 +0100 (CET)", "from pendragon.ideasonboard.com (d51A4137F.access.telenet.be\n\t[81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC8522D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Feb 2019 07:08:23 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549433304;\n\tbh=Pu+ypCssb0+WQtotRHwEBMjRh/ieRz+Jz2FNnrDcU1M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=h6jdEsn9fSCJ+DSOWNznU866qyHnsfoeFRNJ3HjB+NeE8t8/5ucJ/YBkt4zqLEhSA\n\tfQl+6iQttlK3SKOKbvAVyZhsq04wqBdps6lAIQ3n/e8DaufLkjVoGHEuQZE+WsTMSM\n\t1VmRnrA6s0mLNPJr0MR9mXqJio2G8pncJMqTNSRQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Feb 2019 08:07:55 +0200", "Message-Id": "<20190206060818.13907-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>", "References": "<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/27] test: v4l2_device: Add\n\trequest_buffers test", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 06 Feb 2019 06:08:24 -0000" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nAdd a utility to the test suite to request and allocate buffers from\na V4L2Device to ensure it functions correctly.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n test/v4l2_device/meson.build | 1 +\n test/v4l2_device/request_buffers.cpp | 32 ++++++++++++++++++++++++++++\n test/v4l2_device/v4l2_device_test.h | 7 +++++-\n 3 files changed, 39 insertions(+), 1 deletion(-)\n create mode 100644 test/v4l2_device/request_buffers.cpp", "diff": "diff --git a/test/v4l2_device/meson.build b/test/v4l2_device/meson.build\nindex 41675a303498..b6b672611d60 100644\n--- a/test/v4l2_device/meson.build\n+++ b/test/v4l2_device/meson.build\n@@ -2,6 +2,7 @@\n # They are not alphabetically sorted.\n v4l2_device_tests = [\n [ 'double_open', 'double_open.cpp' ],\n+ [ 'request_buffers', 'request_buffers.cpp' ],\n ]\n \n foreach t : v4l2_device_tests\ndiff --git a/test/v4l2_device/request_buffers.cpp b/test/v4l2_device/request_buffers.cpp\nnew file mode 100644\nindex 000000000000..bc6ff2c18a57\n--- /dev/null\n+++ b/test/v4l2_device/request_buffers.cpp\n@@ -0,0 +1,32 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * libcamera V4L2 API tests\n+ */\n+\n+#include \"v4l2_device_test.h\"\n+\n+class RequestBuffersTest : public V4L2DeviceTest\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\t/*\n+\t\t * TODO:\n+\t\t * Test invalid requests\n+\t\t * Test different buffer allocations\n+\t\t */\n+\t\tconst unsigned int bufferCount = 8;\n+\n+\t\tcreateBuffers(bufferCount);\n+\n+\t\tint ret = dev_->exportBuffers(bufferCount, &pool_);\n+\t\tif (ret)\n+\t\t\treturn TestFail;\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(RequestBuffersTest);\ndiff --git a/test/v4l2_device/v4l2_device_test.h b/test/v4l2_device/v4l2_device_test.h\nindex ca231ab47fde..f22f0bb555d8 100644\n--- a/test/v4l2_device/v4l2_device_test.h\n+++ b/test/v4l2_device/v4l2_device_test.h\n@@ -9,6 +9,8 @@\n \n #include <memory>\n \n+#include <libcamera/buffer.h>\n+\n #include \"test.h\"\n \n #include \"device_enumerator.h\"\n@@ -20,7 +22,9 @@ using namespace libcamera;\n class V4L2DeviceTest : public Test\n {\n public:\n-\tV4L2DeviceTest() : dev_(nullptr) { };\n+\tV4L2DeviceTest() : dev_(nullptr){};\n+\n+\tvoid createBuffers(unsigned int qty) { pool_.createBuffers(qty); }\n \n protected:\n \tint init();\n@@ -29,6 +33,7 @@ protected:\n \tstd::unique_ptr<DeviceEnumerator> enumerator_;\n \tstd::shared_ptr<MediaDevice> media_;\n \tV4L2Device *dev_;\n+\tBufferPool pool_;\n };\n \n #endif /* __LIBCAMERA_V4L2_DEVICE_TEST_H_ */\n", "prefixes": [ "libcamera-devel", "04/27" ] }