Patch Detail
Show a patch.
GET /api/patches/46/?format=api
{ "id": 46, "url": "https://patchwork.libcamera.org/api/patches/46/?format=api", "web_url": "https://patchwork.libcamera.org/patch/46/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20181213145313.6754-1-laurent.pinchart@ideasonboard.com>", "date": "2018-12-13T14:53:12", "name": "[libcamera-devel,1/2] Documentation: coding-style: Fix list indentation", "commit_ref": "6f739290ec3bc08317345300c5023692f65e1309", "pull_url": null, "state": "accepted", "archived": false, "hash": "31de42de8170e6729ee9570747f323df85a2cbc7", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/46/mbox/", "series": [ { "id": 22, "url": "https://patchwork.libcamera.org/api/series/22/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=22", "date": "2018-12-13T14:53:12", "name": "[libcamera-devel,1/2] Documentation: coding-style: Fix list indentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/22/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/46/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/46/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD635600CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Dec 2018 15:52:30 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39C42549\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Dec 2018 15:52:30 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544712750;\n\tbh=FsjFBqveTyJXeRnNKT2HsQGgFOx/FlHceMMrALnH8mo=;\n\th=From:To:Subject:Date:From;\n\tb=uhVcnkcj7kFzsNaLjqM636uGREtVRPja8FkTdgd2bE9NlKmpydIWlj/7lL+ULmR1v\n\tF80N9YQxP9prTmEUSixIDjaeDtTihESj1kN/5osYhKRFccde1QdfkNWPFzW4zG/gww\n\tw9rDNpW4fASQvpKKNDdk8mjvl7Mo3nkpp6DF8qfw=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 13 Dec 2018 16:53:12 +0200", "Message-Id": "<20181213145313.6754-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] Documentation: coding-style: Fix list\n\tindentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 13 Dec 2018 14:52:30 -0000" }, "content": "The various lists in the document are not quoted blocks. Don't indent\nthem.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n Documentation/coding-style.rst | 62 +++++++++++++++++-----------------\n 1 file changed, 31 insertions(+), 31 deletions(-)", "diff": "diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\nindex d03eb3d5b96d..1b67abed3a53 100644\n--- a/Documentation/coding-style.rst\n+++ b/Documentation/coding-style.rst\n@@ -26,13 +26,13 @@ Even if the programming language in use is different, the project embraces the\n \n In particular, from the kernel style document, the following section are adopted:\n \n- * 1 \"Indentation\"\n- * 2 \"Breaking Long Lines\" striving to fit code within 80 columns and\n- accepting up to 120 columns when necessary\n- * 3 \"Placing Braces and Spaces\"\n- * 3.1 \"Spaces\"\n- * 8 \"Commenting\" with the exception that in-function comments are not\n- always un-welcome.\n+* 1 \"Indentation\"\n+* 2 \"Breaking Long Lines\" striving to fit code within 80 columns and\n+ accepting up to 120 columns when necessary\n+* 3 \"Placing Braces and Spaces\"\n+* 3.1 \"Spaces\"\n+* 8 \"Commenting\" with the exception that in-function comments are not\n+ always un-welcome.\n \n While libcamera uses the kernel coding style for all typographic matters, the\n project is a user space library, developed in a different programming language,\n@@ -47,19 +47,19 @@ few exceptions and relaxed limitations on some subjects.\n The following exceptions apply to the naming conventions specified in the\n document:\n \n- * File names: libcamera uses the .cpp extensions for C++ source files and\n- the .h extension for header files\n- * Variables, function parameters, function names and class members use\n- camel case style, with the first letter in lower-case (as in 'camelCase'\n- and not 'CamelCase')\n- * Types (classes, structs, type aliases, and type template parameters) use\n- camel case, with the first letter in capital case (as in 'CamelCase' and\n- not 'camelCase')\n- * Enum members use 'CamelCase', while macros are in capital case with\n- underscores in between\n- * All formatting rules specified in the selected sections of the Linux kernel\n- Code Style for indentation, braces, spacing, etc\n- * Header guards are formatted as '__LIBCAMERA_FILE_NAME_H__'\n+* File names: libcamera uses the .cpp extensions for C++ source files and\n+ the .h extension for header files\n+* Variables, function parameters, function names and class members use\n+ camel case style, with the first letter in lower-case (as in 'camelCase'\n+ and not 'CamelCase')\n+* Types (classes, structs, type aliases, and type template parameters) use\n+ camel case, with the first letter in capital case (as in 'CamelCase' and\n+ not 'camelCase')\n+* Enum members use 'CamelCase', while macros are in capital case with\n+ underscores in between\n+* All formatting rules specified in the selected sections of the Linux kernel\n+ Code Style for indentation, braces, spacing, etc\n+* Header guards are formatted as '__LIBCAMERA_FILE_NAME_H__'\n \n \n C++ Specific Rules\n@@ -68,14 +68,14 @@ C++ Specific Rules\n The code shall be implemented in C++03, extended with the following\n C++-11-specific features:\n \n- * Initializer lists\n- * Type inference (auto and decltype)\n- Type inference shall be used with caution, to avoid drifting towards an\n- untyped language.\n- * Range-based for loop\n- * Lambda functions\n- * Explicit overrides and final\n- * Null pointer constant\n- * General-purpose smart pointers (std::unique_ptr), deprecating std::auto_ptr.\n- Smart pointers, as well as shared pointers and weak pointers, shall not be\n- overused.\n+* Initializer lists\n+* Type inference (auto and decltype)\n+ Type inference shall be used with caution, to avoid drifting towards an\n+ untyped language.\n+* Range-based for loop\n+* Lambda functions\n+* Explicit overrides and final\n+* Null pointer constant\n+* General-purpose smart pointers (std::unique_ptr), deprecating std::auto_ptr.\n+ Smart pointers, as well as shared pointers and weak pointers, shall not be\n+ overused.\n", "prefixes": [ "libcamera-devel", "1/2" ] }