Patch Detail
Show a patch.
GET /api/patches/445/?format=api
{ "id": 445, "url": "https://patchwork.libcamera.org/api/patches/445/?format=api", "web_url": "https://patchwork.libcamera.org/patch/445/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190130111349.20891-1-kieran.bingham@ideasonboard.com>", "date": "2019-01-30T11:13:49", "name": "[libcamera-devel] clang-format: Enable BreakBeforeTernaryOperators", "commit_ref": "8400bdd19adfe4f904c971f6ef6ef9499896fa4d", "pull_url": null, "state": "accepted", "archived": false, "hash": "c8f65aaf3b05536a057bcf85e90dea8deab78169", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/445/mbox/", "series": [ { "id": 155, "url": "https://patchwork.libcamera.org/api/series/155/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=155", "date": "2019-01-30T11:13:49", "name": "[libcamera-devel] clang-format: Enable BreakBeforeTernaryOperators", "version": 1, "mbox": "https://patchwork.libcamera.org/series/155/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/445/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/445/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5603D60B2D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Jan 2019 12:13:54 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFC5941;\n\tWed, 30 Jan 2019 12:13:53 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548846833;\n\tbh=ljlP4H82sCmZtXyXQs1VvoT1x+1NFBLpu3jgTmmyi8c=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=a/VgoGQuQVuVKjP4410VOqd9lOfrRHqhOxIOChNNlkWa2mpgjRPvTtQaZS/coxlGN\n\tScINkdswVqilpd8riyE8BpUD4Fg8C0X4/OJwp0reXEqMkDf9wVDKRQY1bMgSndkjqb\n\tT7kjbnnS/XIFU8J13YffzpHFnAZukKWW2VqZRaks=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 30 Jan 2019 11:13:49 +0000", "Message-Id": "<20190130111349.20891-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] clang-format: Enable\n\tBreakBeforeTernaryOperators", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 30 Jan 2019 11:13:54 -0000" }, "content": "This produces code with the ternary operators at the beginning instead of the\nend of the line:\n\n return caps_.isMultiplanar() ? getFormatMultiplane(fmt)\n : getFormatSingleplane(fmt);\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n .clang-format | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/.clang-format b/.clang-format\nindex 59a61d050e3d..d4669dd93f8d 100644\n--- a/.clang-format\n+++ b/.clang-format\n@@ -47,7 +47,7 @@ BraceWrapping:\n BreakBeforeBinaryOperators: None\n BreakBeforeBraces: Custom\n #BreakBeforeInheritanceComma: false # Unknown to clang-format-4.0\n-BreakBeforeTernaryOperators: false\n+BreakBeforeTernaryOperators: true\n BreakConstructorInitializersBeforeComma: false\n #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0\n BreakAfterJavaFieldAnnotations: false\n", "prefixes": [ "libcamera-devel" ] }