Patch Detail
Show a patch.
GET /api/patches/4195/?format=api
{ "id": 4195, "url": "https://patchwork.libcamera.org/api/patches/4195/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4195/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200623190836.53446-22-paul.elder@ideasonboard.com>", "date": "2020-06-23T19:08:35", "name": "[libcamera-devel,v3,21/22] v4l2: v4l2_camera_proxy: Fix buffer flags related to queueing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5c1b7465f61042bb7196996174ea08fc1564e94a", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4195/mbox/", "series": [ { "id": 1034, "url": "https://patchwork.libcamera.org/api/series/1034/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1034", "date": "2020-06-23T19:08:14", "name": "Support v4l2-compliance", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1034/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4195/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4195/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D2B5609A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jun 2020 21:09:52 +0200 (CEST)", "from jade.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:8147:f2a2:a8c6:9087])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5BBA2A9;\n\tTue, 23 Jun 2020 21:09:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"V4YTo6E0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592939392;\n\tbh=YnuCaXsqVm36dOyk1e01v9xta0LWWiU3MS4aW8ZpgyQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=V4YTo6E09VrRIjXUhVsA/eso6iLplNxXMzbo03yc0lw/DOhHxWiPNvyOVc30uigL6\n\tmtfDxW61NRWMEd1HIHTHZ3qElLTzEtYrqUpFtfyArFoSsUNobLmnDyzFatMFEvxSgN\n\ttwCCiqzzAPbD7lUd1dggscuCqzZr6FjnYxmO0Me0=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 24 Jun 2020 04:08:35 +0900", "Message-Id": "<20200623190836.53446-22-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200623190836.53446-1-paul.elder@ideasonboard.com>", "References": "<20200623190836.53446-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 21/22] v4l2: v4l2_camera_proxy: Fix\n\tbuffer flags related to queueing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 23 Jun 2020 19:09:52 -0000" }, "content": "Fix buffer flags related to queueing and dequeueing:\n- don't allow a buffer with the same index that is already in the queue\n to be enqueued again\n- don't set the done flag on dequeueing in\n V4L2CameraProxy::updateBuffers()\n- set the flags in V4L2CameraProxy's internal buffers, and not just in\n the buffers returned from qbuf\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v3:\n- remove \"set the mapped flag on enqueueing\"\n- clean up some logic\n- expand commit message very slightly\n\nNew in v2\n- split from \"Fix v4l2-compliance streaming tests\"\n---\n src/v4l2/v4l2_camera_proxy.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex ce0d755..ed3bcbc 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -219,7 +219,6 @@ void V4L2CameraProxy::updateBuffers()\n \t\t\tbuf.timestamp.tv_usec = fmd.timestamp % 1000000;\n \t\t\tbuf.sequence = fmd.sequence;\n \n-\t\t\tbuf.flags |= V4L2_BUF_FLAG_DONE;\n \t\t\tbreak;\n \t\tcase FrameMetadata::FrameError:\n \t\t\tbuf.flags |= V4L2_BUF_FLAG_ERROR;\n@@ -570,6 +569,9 @@ int V4L2CameraProxy::vidioc_qbuf(V4L2CameraFile *file, struct v4l2_buffer *arg)\n \tif (arg->index >= bufferCount_)\n \t\treturn -EINVAL;\n \n+\tif (buffers_[arg->index].flags & V4L2_BUF_FLAG_QUEUED)\n+\t\treturn -EINVAL;\n+\n \tif (!hasOwnership(file))\n \t\treturn -EBUSY;\n \n@@ -582,8 +584,10 @@ int V4L2CameraProxy::vidioc_qbuf(V4L2CameraFile *file, struct v4l2_buffer *arg)\n \tif (ret < 0)\n \t\treturn ret;\n \n-\targ->flags |= V4L2_BUF_FLAG_QUEUED;\n-\targ->flags &= ~V4L2_BUF_FLAG_DONE;\n+\tbuffers_[arg->index].flags |= V4L2_BUF_FLAG_QUEUED;\n+\tbuffers_[arg->index].flags &= ~V4L2_BUF_FLAG_DONE;\n+\n+\targ->flags = buffers_[arg->index].flags;\n \n \treturn ret;\n }\n", "prefixes": [ "libcamera-devel", "v3", "21/22" ] }