Patch Detail
Show a patch.
GET /api/patches/4178/?format=api
{ "id": 4178, "url": "https://patchwork.libcamera.org/api/patches/4178/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4178/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200623190836.53446-5-paul.elder@ideasonboard.com>", "date": "2020-06-23T19:08:18", "name": "[libcamera-devel,v3,04/22] v4l2: v4l2_camera_proxy: Free old buffers on reqbufs > 0", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "adc01e50f0bb1194220d4058245e06bbedb28bf9", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4178/mbox/", "series": [ { "id": 1034, "url": "https://patchwork.libcamera.org/api/series/1034/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1034", "date": "2020-06-23T19:08:14", "name": "Support v4l2-compliance", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1034/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4178/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4178/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5C18609DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jun 2020 21:09:11 +0200 (CEST)", "from jade.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:8147:f2a2:a8c6:9087])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43DB9329;\n\tTue, 23 Jun 2020 21:09:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IhI9jx0p\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592939351;\n\tbh=6GGe/InUYHXIuZVUMfE7B96sNpqlO57plP/B5g8DYo4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IhI9jx0pUL6O2X488MZ3FjvAnS8gT/ZT8Tqq8tvUVXKo5yxAgVo+KHX9+VBKlqBhz\n\tlQ+vMXxnNsnQrJFAV2x7OKkZbhgN9YiI25tYI2+9//xJo7jt4CjH/eGMElDqqdpQ8E\n\tKW23PlDzWdP7Y62qCKd9YWmYcKndaJGkO61gPfVY=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 24 Jun 2020 04:08:18 +0900", "Message-Id": "<20200623190836.53446-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200623190836.53446-1-paul.elder@ideasonboard.com>", "References": "<20200623190836.53446-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/22] v4l2: v4l2_camera_proxy: Free\n\told buffers on reqbufs > 0", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 23 Jun 2020 19:09:12 -0000" }, "content": "Free buffers if any were previously allocated, at VIDIOC_REQBUFS with\ncount > 0.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v3\n- split from... a conglomerate of v4l2-compliance fixes patch\n---\n src/v4l2/v4l2_camera_proxy.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex eb59d49..7262453 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -361,6 +361,15 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n \t\treturn freeBuffers();\n \t}\n \n+\tif (bufferCount_ > 0) {\n+\t\tint ret = freeBuffers();\n+\t\tif (ret < 0) {\n+\t\t\tLOG(V4L2Compat, Error)\n+\t\t\t\t<< \"Failed to free libcamera buffers for re-reqbufs\";\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n \tSize size(curV4L2Format_.fmt.pix.width, curV4L2Format_.fmt.pix.height);\n \tret = vcam_->configure(&streamConfig_, size,\n \t\t\t v4l2ToDrm(curV4L2Format_.fmt.pix.pixelformat),\n", "prefixes": [ "libcamera-devel", "v3", "04/22" ] }