Patch Detail
Show a patch.
GET /api/patches/4167/?format=api
{ "id": 4167, "url": "https://patchwork.libcamera.org/api/patches/4167/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4167/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200623165550.45835-1-jacopo@jmondi.org>", "date": "2020-06-23T16:55:45", "name": "[libcamera-devel,20/25] media: ov5647: Program mode only if it has changed", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "fbde7fdffd45661b287ea0a390a823a9a0479777", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/4167/mbox/", "series": [ { "id": 1030, "url": "https://patchwork.libcamera.org/api/series/1030/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1030", "date": "2020-06-23T10:07:50", "name": "media: ov5647: Support RaspberryPi Camera Module v1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1030/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4167/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4167/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A62C60103\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jun 2020 18:52:43 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 8EDC4200002;\n\tTue, 23 Jun 2020 16:52:37 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "mchehab@kernel.org, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl,\n\tlaurent.pinchart@ideasonboard.com, roman.kovalivskyi@globallogic.com, \n\tdave.stevenson@raspberrypi.org, naush@raspberrypi.com", "Cc": "mrodin@de.adit-jv.com, hugues.fruchet@st.com, mripard@kernel.org,\n\taford173@gmail.com, sudipi@jp.adit-jv.com, andrew_gabbasov@mentor.com,\n\terosca@de.adit-jv.com, linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org, Jacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 23 Jun 2020 18:55:45 +0200", "Message-Id": "<20200623165550.45835-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200623100815.10674-1-jacopo@jmondi.org>", "References": "<20200623100815.10674-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 20/25] media: ov5647: Program mode only if\n\tit has changed", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 23 Jun 2020 16:52:43 -0000" }, "content": "Store in the driver structure a pointer to the currently applied mode\nand program a new one at s_stream(1) time only if it has changed.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n drivers/media/i2c/ov5647.c | 16 +++++++++++++++-\n 1 file changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c\nindex 39e320f321bd8..ac114269e1c73 100644\n--- a/drivers/media/i2c/ov5647.c\n+++ b/drivers/media/i2c/ov5647.c\n@@ -96,6 +96,7 @@ struct ov5647 {\n \tbool\t\t\t\tclock_ncont;\n \tstruct v4l2_ctrl_handler\tctrls;\n \tstruct ov5647_mode\t\t*mode;\n+\tstruct ov5647_mode\t\t*current_mode;\n };\n \n static inline struct ov5647 *to_sensor(struct v4l2_subdev *sd)\n@@ -750,9 +751,13 @@ static int ov5647_set_virtual_channel(struct v4l2_subdev *sd, int channel)\n static int ov5647_set_mode(struct v4l2_subdev *sd)\n {\n \tstruct i2c_client *client = v4l2_get_subdevdata(sd);\n+\tstruct ov5647 *sensor = to_sensor(sd);\n \tu8 resetval, rdval;\n \tint ret;\n \n+\tif (sensor->mode == sensor->current_mode)\n+\t\treturn 0;\n+\n \tret = ov5647_read(sd, OV5647_SW_STANDBY, &rdval);\n \tif (ret < 0)\n \t\treturn ret;\n@@ -778,6 +783,8 @@ static int ov5647_set_mode(struct v4l2_subdev *sd)\n \t\t\treturn ret;\n \t}\n \n+\tsensor->current_mode = sensor->mode;\n+\n \treturn 0;\n }\n \n@@ -816,6 +823,7 @@ static int ov5647_stream_on(struct v4l2_subdev *sd)\n \n static int ov5647_stream_off(struct v4l2_subdev *sd)\n {\n+\tstruct ov5647 *sensor = to_sensor(sd);\n \tint ret;\n \n \tret = ov5647_write(sd, OV5647_REG_MIPI_CTRL00, MIPI_CTRL00_CLOCK_LANE_GATE |\n@@ -827,7 +835,13 @@ static int ov5647_stream_off(struct v4l2_subdev *sd)\n \tif (ret < 0)\n \t\treturn ret;\n \n-\treturn ov5647_write(sd, OV5640_REG_PAD_OUT, 0x01);\n+\tret = ov5647_write(sd, OV5640_REG_PAD_OUT, 0x01);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tsensor->current_mode = NULL;\n+\n+\treturn 0;\n }\n \n static int set_sw_standby(struct v4l2_subdev *sd, bool standby)\n", "prefixes": [ "libcamera-devel", "20/25" ] }