Patch Detail
Show a patch.
GET /api/patches/4131/?format=api
{ "id": 4131, "url": "https://patchwork.libcamera.org/api/patches/4131/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4131/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200623020930.1781469-5-niklas.soderlund@ragnatech.se>", "date": "2020-06-23T02:09:24", "name": "[libcamera-devel,v3,04/10] libcamera: ipu3: Calculate number of buffers for ImgU", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "73e602414761cd4dbc069e4aabd3b31130a378a3", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4131/mbox/", "series": [ { "id": 1027, "url": "https://patchwork.libcamera.org/api/series/1027/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1027", "date": "2020-06-23T02:09:20", "name": "libcamera: ipu3: Allow zero-copy RAW stream", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1027/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4131/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4131/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59167609C3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jun 2020 04:09:45 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 9b02fbb7-b4f6-11ea-933e-005056917a89;\n\tTue, 23 Jun 2020 04:09:44 +0200 (CEST)" ], "X-Halon-ID": "9b02fbb7-b4f6-11ea-933e-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Jun 2020 04:09:24 +0200", "Message-Id": "<20200623020930.1781469-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200623020930.1781469-1-niklas.soderlund@ragnatech.se>", "References": "<20200623020930.1781469-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/10] libcamera: ipu3: Calculate\n\tnumber of buffers for ImgU", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 23 Jun 2020 02:09:47 -0000" }, "content": "Decouple the number of buffers to allocate for the ImgU from the number\nof buffers allocated for the CIO2. Instead of blindly following the CIO2\npick the maximum number of buffers requested for any stream facing\napplications.\n\nThis is potentially wasteful, as each stream could allocate just as many\nbuffers as requested by the application instead of the maximum from the\nset. But this is not more wasteful than what is already used by the\npipeline and should be fixed on top after the decoupling of the two\nprocessing units.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n* Changes since v1\n- Use std::max({ ... })\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 3b2ec684244881e5..7967fde9c39b1547 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -735,7 +735,11 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera)\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tbufferCount = ret;\n+\tbufferCount = std::max({\n+\t\tdata->outStream_.configuration().bufferCount,\n+\t\tdata->vfStream_.configuration().bufferCount,\n+\t\tdata->rawStream_.configuration().bufferCount,\n+\t});\n \n \tret = imgu->allocateBuffers(data, bufferCount);\n \tif (ret < 0) {\n", "prefixes": [ "libcamera-devel", "v3", "04/10" ] }