Patch Detail
Show a patch.
GET /api/patches/410/?format=api
{ "id": 410, "url": "https://patchwork.libcamera.org/api/patches/410/?format=api", "web_url": "https://patchwork.libcamera.org/patch/410/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190127002208.18913-3-niklas.soderlund@ragnatech.se>", "date": "2019-01-27T00:22:04", "name": "[libcamera-devel,v3,2/6] libcamera: stream: add initial StreamConfiguration class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "757c81d5d2f698dce8a9f8467f7f3d2b9d2138a3", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/410/mbox/", "series": [ { "id": 144, "url": "https://patchwork.libcamera.org/api/series/144/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=144", "date": "2019-01-27T00:22:04", "name": "libcamera: add basic support for streams and format configuration", "version": 3, "mbox": "https://patchwork.libcamera.org/series/144/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/410/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/410/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77C4260C7D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 27 Jan 2019 01:22:51 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid ae178ff2-21c9-11e9-874f-005056917f90;\n\tSun, 27 Jan 2019 01:22:50 +0100 (CET)" ], "X-Halon-ID": "ae178ff2-21c9-11e9-874f-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 27 Jan 2019 01:22:04 +0100", "Message-Id": "<20190127002208.18913-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190127002208.18913-1-niklas.soderlund@ragnatech.se>", "References": "<20190127002208.18913-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/6] libcamera: stream: add initial\n\tStreamConfiguration class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 27 Jan 2019 00:22:52 -0000" }, "content": "Add an initial StreamConfiguration implementation to hold configuration\ndata for a single stream of a Camera. In its current form not many\nconfiguration parameters are supported but it's expected the number of\noptions will grow over time.\n\nAt this stage the pixel format is represented as an unsigned int to\nallow for easy mapping to the V4L2 API. This might be subject to change\nin the future as we finalize how libcamera shall represent pixel\nformats.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/stream.h | 10 ++++++++++\n src/libcamera/stream.cpp | 31 +++++++++++++++++++++++++++++++\n 2 files changed, 41 insertions(+)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 580f2cc8d3a3ad59..e7597dd5a9492c2a 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -20,6 +20,16 @@ private:\n \tunsigned int id_;\n };\n \n+class StreamConfiguration final\n+{\n+public:\n+\tStreamConfiguration();\n+\n+\tunsigned int width;\n+\tunsigned int height;\n+\tunsigned int pixelFormat;\n+};\n+\n } /* namespace libcamera */\n \n #endif /* __LIBCAMERA_STREAM_H__ */\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 307de3710d0ac6b1..530668a478a79c94 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -64,4 +64,35 @@ Stream::Stream(unsigned int id)\n * \\return The stream ID\n */\n \n+/**\n+ * \\class StreamConfiguration\n+ * \\brief Configuration parameters for a stream\n+ *\n+ * The StreamConfiguration class is a model of all information which can be\n+ * configured for a single video stream.\n+ */\n+\n+StreamConfiguration::StreamConfiguration()\n+\t: width(0), height(0), pixelFormat(0)\n+{\n+}\n+\n+/**\n+ * \\var StreamConfiguration::width\n+ * \\brief Stream width in pixels\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::height\n+ * \\brief Stream height in pixels\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::pixelFormat\n+ * \\brief Stream pixel format or type of compression\n+ *\n+ * This is a little endian four character code representation of the pixel\n+ * format described in V4L2 using the V4L2_PIX_FMT_* definitions.\n+ */\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v3", "2/6" ] }