Patch Detail
Show a patch.
GET /api/patches/4096/?format=api
{ "id": 4096, "url": "https://patchwork.libcamera.org/api/patches/4096/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4096/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200619054123.19052-17-paul.elder@ideasonboard.com>", "date": "2020-06-19T05:41:22", "name": "[libcamera-devel,v2,16/17] v4l2: v4l2_camera_proxy: Don't allow buffers to be freed if still mmaped", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2bf72cad53fa690fd7ff44435b7d61d024cac5b1", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4096/mbox/", "series": [ { "id": 1017, "url": "https://patchwork.libcamera.org/api/series/1017/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1017", "date": "2020-06-19T05:41:06", "name": "Support v4l2-compliance", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1017/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4096/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4096/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23CB1609A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Jun 2020 07:42:10 +0200 (CEST)", "from jade.flets-east.jp (unknown\n\t[IPv6:2400:4051:61:600:e972:d773:e99a:4f79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B543556;\n\tFri, 19 Jun 2020 07:42:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"K2fxGWdo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592545329;\n\tbh=LGblM1q/cDUOsGiN3Djel4GcaxzFDP6hIhNGvI3NTEc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=K2fxGWdoJyfLe2JzuThUu0YiLVuDsMUaKVAi59Wk7FpQ5/mWIy6QYGpW4h+MlxE7k\n\tWg/M42uOgj5ydLGpigsJZg/oQ2rcqBt497iUygKNOIaiyHyZ26gdL7A52qL3QC2rmK\n\tN8stgV/EUjpbDiCiQGWbi+9lJ5P1ZTP/mMNd9q0I=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Jun 2020 14:41:22 +0900", "Message-Id": "<20200619054123.19052-17-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200619054123.19052-1-paul.elder@ideasonboard.com>", "References": "<20200619054123.19052-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 16/17] v4l2: v4l2_camera_proxy: Don't\n\tallow buffers to be freed if still mmaped", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 19 Jun 2020 05:42:10 -0000" }, "content": "In VIDIOC_REQBUFS with count = 0, if the buffers are still mmaped, they\nshould not be allowed to be freed. Add a check for this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v2\n- split from \"Fix v4l2-compliance streaming tests\"\n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex a7f987a..2eb2fcc 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -467,6 +467,9 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *cf, struct v4l2_requestbuffe\n \tmemset(arg->reserved, 0, sizeof(arg->reserved));\n \n \tif (arg->count == 0) {\n+\t\tif (!mmaps_.empty())\n+\t\t\treturn -EBUSY;\n+\n \t\tif (vcam_->isRunning()) {\n \t\t\tfor (struct v4l2_buffer &buf : buffers_)\n \t\t\t\tbuf.flags &= ~(V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE);\n", "prefixes": [ "libcamera-devel", "v2", "16/17" ] }