Patch Detail
Show a patch.
GET /api/patches/4043/?format=api
{ "id": 4043, "url": "https://patchwork.libcamera.org/api/patches/4043/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4043/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200616105633.57717-2-paul.elder@ideasonboard.com>", "date": "2020-06-16T10:56:33", "name": "[libcamera-devel,2/2] v4l2: v4l2_compat_manager: Use openat64 and mmap64", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "32168d0a5b929e8d0d08887c297a639fcefe06e5", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4043/mbox/", "series": [ { "id": 1005, "url": "https://patchwork.libcamera.org/api/series/1005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1005", "date": "2020-06-16T10:56:32", "name": "[libcamera-devel,1/2] v4l2: v4l2_compat: Intercept open64, openat64, and mmap64", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4043/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4043/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 275E660103\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jun 2020 12:56:52 +0200 (CEST)", "from jade.flets-east.jp (unknown\n\t[IPv6:2400:4051:61:600:2807:bdfa:f6a:8e53])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96956F9;\n\tTue, 16 Jun 2020 12:56:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"d3odiuhH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592305011;\n\tbh=B+xZnD39s/MFSH130yxagRP+sRVFl6+vwgXpUMBW8ts=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=d3odiuhHgqb4RRPen4s8uAdr1wsZNsF97zHFbCTDIljRDb3KI46nQRX91ubdsh6Qi\n\tcOpEbFs1lXBCpBf2IbqzAtlBj9lTR1uspxcuC1ULpapBiPjwynUf9B5ATrnHWKu8rv\n\tDa+vgbBqVL87WBWgkFN5s11SfUJhCKEOo4BqkVhY=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Jun 2020 19:56:33 +0900", "Message-Id": "<20200616105633.57717-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200616105633.57717-1-paul.elder@ideasonboard.com>", "References": "<20200616105633.57717-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] v4l2: v4l2_compat_manager: Use\n\topenat64 and mmap64", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 16 Jun 2020 10:56:52 -0000" }, "content": "Since we set _FILE_OFFSET_BITS to 32 to force the various open and mmap\nsymbols that we export to not be the 64-bit versions, our dlsym to get\nthe original open and mmap calls will not automatically be converted to\ntheir 64-bit versions. Since we intercept both 32-bit and 64-bit\nversions of open and mmap, we should be using the 64-bit version to\nservice both. Fetch the 64-bit versions of openat and mmap directly.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/v4l2/v4l2_compat_manager.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\nindex f928760..9298c0f 100644\n--- a/src/v4l2/v4l2_compat_manager.cpp\n+++ b/src/v4l2/v4l2_compat_manager.cpp\n@@ -39,11 +39,11 @@ void get_symbol(T &func, const char *name)\n V4L2CompatManager::V4L2CompatManager()\n \t: cm_(nullptr)\n {\n-\tget_symbol(fops_.openat, \"openat\");\n+\tget_symbol(fops_.openat, \"openat64\");\n \tget_symbol(fops_.dup, \"dup\");\n \tget_symbol(fops_.close, \"close\");\n \tget_symbol(fops_.ioctl, \"ioctl\");\n-\tget_symbol(fops_.mmap, \"mmap\");\n+\tget_symbol(fops_.mmap, \"mmap64\");\n \tget_symbol(fops_.munmap, \"munmap\");\n }\n \n", "prefixes": [ "libcamera-devel", "2/2" ] }