Patch Detail
Show a patch.
GET /api/patches/3992/?format=api
{ "id": 3992, "url": "https://patchwork.libcamera.org/api/patches/3992/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3992/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200608142912.3162375-1-kieran.bingham@ideasonboard.com>", "date": "2020-06-08T14:29:12", "name": "[libcamera-devel] v4l2: v4l2_camera_proxy: Fix NV24 subsampling", "commit_ref": "cd1f258af90a58be5cc96c45113e78bb1da235ee", "pull_url": null, "state": "accepted", "archived": false, "hash": "94da262c7c0a137b4611ff591e4a67154b0a690a", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3992/mbox/", "series": [ { "id": 976, "url": "https://patchwork.libcamera.org/api/series/976/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=976", "date": "2020-06-08T14:29:12", "name": "[libcamera-devel] v4l2: v4l2_camera_proxy: Fix NV24 subsampling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/976/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3992/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3992/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8A0761027\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Jun 2020 16:29:16 +0200 (CEST)", "from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E87424F;\n\tMon, 8 Jun 2020 16:29:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DTs/gkBc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591626556;\n\tbh=f40JSj6tYuxVzsNMdcOh5zgKeApL7W/wHcoj879j+4U=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DTs/gkBcGdCQP7m6kD60kMxX6optGTmhgJHC7xgAAgtI63tZ2lz7HnFYqK90JJorw\n\tiPvnjs2ZQmZHDs7WlxXHqjYxsIrGz0G/Hkx1gggtnD3Es0vZW+Lt9jV9eH2kX5d4YG\n\t5S/AWVfNrQ4mMtDG1Fm04i/Qnw7P/CCcTYSz+334=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 8 Jun 2020 15:29:12 +0100", "Message-Id": "<20200608142912.3162375-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix NV24\n\tsubsampling", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 08 Jun 2020 14:29:17 -0000" }, "content": "The NV24 pixelFormatInfo table entry defines an incorrect horizontal\nsub-sampling.\n\nUpdate to the correct value.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 059f3cbee999..852cca03a020 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -571,7 +571,7 @@ static const std::array<PixelFormatInfo, 13> pixelFormatInfo = {{\n \t{ PixelFormat(DRM_FORMAT_NV21),\t\tV4L2_PIX_FMT_NV21,\t2, {{ { 8, 1, 1 }, { 16, 2, 2 }, { 0, 0, 0 } }} },\n \t{ PixelFormat(DRM_FORMAT_NV16),\t\tV4L2_PIX_FMT_NV16,\t2, {{ { 8, 1, 1 }, { 16, 2, 1 }, { 0, 0, 0 } }} },\n \t{ PixelFormat(DRM_FORMAT_NV61),\t\tV4L2_PIX_FMT_NV61,\t2, {{ { 8, 1, 1 }, { 16, 2, 1 }, { 0, 0, 0 } }} },\n-\t{ PixelFormat(DRM_FORMAT_NV24),\t\tV4L2_PIX_FMT_NV24,\t2, {{ { 8, 1, 1 }, { 16, 2, 1 }, { 0, 0, 0 } }} },\n+\t{ PixelFormat(DRM_FORMAT_NV24),\t\tV4L2_PIX_FMT_NV24,\t2, {{ { 8, 1, 1 }, { 16, 1, 1 }, { 0, 0, 0 } }} },\n \t{ PixelFormat(DRM_FORMAT_NV42),\t\tV4L2_PIX_FMT_NV42,\t2, {{ { 8, 1, 1 }, { 16, 1, 1 }, { 0, 0, 0 } }} },\n }};\n \n", "prefixes": [ "libcamera-devel" ] }