Patch Detail
Show a patch.
GET /api/patches/3983/?format=api
{ "id": 3983, "url": "https://patchwork.libcamera.org/api/patches/3983/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3983/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200608023234.7533-1-laurent.pinchart@ideasonboard.com>", "date": "2020-06-08T02:32:34", "name": "[libcamera-devel] libcamera: pipeline: rkisp1: Avoid usage of dynamic_cast<>", "commit_ref": "33d71af84e64d28be278234bf5a152aee67c9013", "pull_url": null, "state": "accepted", "archived": false, "hash": "bfbe88b8b85e57f416d6e8d3081f339872510f87", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3983/mbox/", "series": [ { "id": 970, "url": "https://patchwork.libcamera.org/api/series/970/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=970", "date": "2020-06-08T02:32:34", "name": "[libcamera-devel] libcamera: pipeline: rkisp1: Avoid usage of dynamic_cast<>", "version": 1, "mbox": "https://patchwork.libcamera.org/series/970/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3983/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3983/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BD916002E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Jun 2020 04:32:57 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 847752C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Jun 2020 04:32:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AMtrJSAj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591583576;\n\tbh=lmjKETXqODtjNLvuPl03/BAqxwL5L/BPDpyHzKOosIA=;\n\th=From:To:Subject:Date:From;\n\tb=AMtrJSAj6RBoRapNG7f8a0YlwYnxttpVK+iIELoWeb/vweDILLQSXIrjk3rfxrp82\n\t3o15ROgYgftoHmYgSIu0ecLhSAiG11jTsdQ801la9JAXBc/sNIpPqECowqC5kH0+gh\n\t1x/fPhgBOa0tSQo3A1XBQ5hNW8rcXeQ4dyuGoCsA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 Jun 2020 05:32:34 +0300", "Message-Id": "<20200608023234.7533-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Avoid usage\n\tof dynamic_cast<>", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 08 Jun 2020 02:32:57 -0000" }, "content": "The logic of the code guarantees that the PipelineHandler pointer passed\nto the RkISP1Frames constructor is an instance of PipelineHandlerRkISP1.\nWe can thus use static_cast<> instead of dynamic_cast<>.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex d807fc2cf535..094362bb0e4f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -221,7 +221,7 @@ private:\n };\n \n RkISP1Frames::RkISP1Frames(PipelineHandler *pipe)\n-\t: pipe_(dynamic_cast<PipelineHandlerRkISP1 *>(pipe))\n+\t: pipe_(static_cast<PipelineHandlerRkISP1 *>(pipe))\n {\n }\n \n", "prefixes": [ "libcamera-devel" ] }