Patch Detail
Show a patch.
GET /api/patches/3938/?format=api
{ "id": 3938, "url": "https://patchwork.libcamera.org/api/patches/3938/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3938/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200605090106.15424-4-paul.elder@ideasonboard.com>", "date": "2020-06-05T09:01:02", "name": "[libcamera-devel,v2,3/7] v4l2: v4l2_camera_proxy: Fix bounds check for VIDIOC_ENUM_FMT", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6b56e1f90501bea50aedd2ea9a527952b808e1b4", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3938/mbox/", "series": [ { "id": 956, "url": "https://patchwork.libcamera.org/api/series/956/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=956", "date": "2020-06-05T09:00:59", "name": "Support qv4l2 with v4l2-compat", "version": 2, "mbox": "https://patchwork.libcamera.org/series/956/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3938/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3938/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 103A761167\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Jun 2020 11:01:21 +0200 (CEST)", "from emerald.amanokami.net (fs76eef344.knge213.ap.nuro.jp\n\t[118.238.243.68])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D8CD27C;\n\tFri, 5 Jun 2020 11:01:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rSipi9ye\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591347680;\n\tbh=whVEwgtlX/iSVJrGUco2WPc9k7dIH3q1tfmlXsWDbyo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rSipi9yec82ESskSp9RLLQ517tjclg83QZTFdgJsJuDLVEpUXtTkzvmKBXt2Devgk\n\tFn12z1gOXwWKD+SWW1gzuWqKILb6aOFDxrm2DDaUZnS1MujH4EwSrP8Vd2EoaC5nB1\n\tp24CD1mLGQSPvedmmu3isx2eail9DtKP0998WoVE=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 5 Jun 2020 18:01:02 +0900", "Message-Id": "<20200605090106.15424-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200605090106.15424-1-paul.elder@ideasonboard.com>", "References": "<20200605090106.15424-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/7] v4l2: v4l2_camera_proxy: Fix\n\tbounds check for VIDIOC_ENUM_FMT", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 05 Jun 2020 09:01:21 -0000" }, "content": "VIDIOC_ENUM_FMT is meant to return -EINVAL if the requested index is out\nof bounds. This bounds is obtained from the libcamera Camera's list of\nformats. The bounds check for this list was incorrect; fix it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v2\n---\n src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 3df4d42b..ec6d265d 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -224,7 +224,7 @@ int V4L2CameraProxy::vidioc_enum_fmt(struct v4l2_fmtdesc *arg)\n \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_enum_fmt\";\n \n \tif (!validateBufferType(arg->type) ||\n-\t arg->index > streamConfig_.formats().pixelformats().size())\n+\t arg->index >= streamConfig_.formats().pixelformats().size())\n \t\treturn -EINVAL;\n \n \t/* \\todo Add map from format to description. */\n", "prefixes": [ "libcamera-devel", "v2", "3/7" ] }