Patch Detail
Show a patch.
GET /api/patches/3891/?format=api
{ "id": 3891, "url": "https://patchwork.libcamera.org/api/patches/3891/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3891/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200602013909.3170593-3-niklas.soderlund@ragnatech.se>", "date": "2020-06-02T01:39:01", "name": "[libcamera-devel,02/10] libcamera: ipu3: Remove id from camera names", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8e4ccfe907fac7a1e43172b08a214e5295041970", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3891/mbox/", "series": [ { "id": 943, "url": "https://patchwork.libcamera.org/api/series/943/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=943", "date": "2020-06-02T01:38:59", "name": "libcamera: ipu3: Allow zero-copy RAW stream", "version": 1, "mbox": "https://patchwork.libcamera.org/series/943/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3891/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3891/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9044461027\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Jun 2020 03:39:28 +0200 (CEST)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid d4899f0a-a471-11ea-a73e-0050569116f7;\n\tTue, 02 Jun 2020 03:38:59 +0200 (CEST)" ], "X-Halon-ID": "d4899f0a-a471-11ea-a73e-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 2 Jun 2020 03:39:01 +0200", "Message-Id": "<20200602013909.3170593-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>", "References": "<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 02/10] libcamera: ipu3: Remove id from\n\tcamera names", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 02 Jun 2020 01:39:28 -0000" }, "content": "The id in the camera name is confusing and is of little use for users.\nCamera names are not (yet) required to be unique and appending which\nnumerical CIO2 unit the sensor is attached to is just as good as\ndepending on the i2c bus information already present in the entity name.\n\nBefore this change,\n\n $ cam -l\n Available cameras:\n 1: ov13858 2-0010 0\n 2: ov5670 4-0036 1\n\nAfter this change,\n\n $ cam -l\n Available cameras:\n 1: ov13858 2-0010\n 2: ov5670 4-0036\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex b805fea71c2d812d..6df1e29281941ebf 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -949,8 +949,7 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n \n \t\t/* Create and register the Camera instance. */\n-\t\tstd::string cameraName = cio2->sensor_->entity()->name() + \" \"\n-\t\t\t\t + std::to_string(id);\n+\t\tstd::string cameraName = cio2->sensor_->entity()->name();\n \t\tstd::shared_ptr<Camera> camera = Camera::create(this,\n \t\t\t\t\t\t\t\tcameraName,\n \t\t\t\t\t\t\t\tstreams);\n", "prefixes": [ "libcamera-devel", "02/10" ] }