Patch Detail
Show a patch.
GET /api/patches/3888/?format=api
{ "id": 3888, "url": "https://patchwork.libcamera.org/api/patches/3888/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3888/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200601185233.GA26406@kaaira-HP-Pavilion-Notebook>", "date": "2020-06-01T18:52:33", "name": "[libcamera-devel,v3] libcamera: v4l2subdev: Print mbus string instead of code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0a6ca115ab2e3e5c79aa8383b27d81d956fd5f24", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3888/mbox/", "series": [ { "id": 942, "url": "https://patchwork.libcamera.org/api/series/942/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=942", "date": "2020-06-01T18:52:33", "name": "[libcamera-devel,v3] libcamera: v4l2subdev: Print mbus string instead of code", "version": 3, "mbox": "https://patchwork.libcamera.org/series/942/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3888/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3888/checks/", "tags": {}, "headers": { "Return-Path": "<kgupta@es.iitr.ac.in>", "Received": [ "from mail-pl1-x644.google.com (mail-pl1-x644.google.com\n\t[IPv6:2607:f8b0:4864:20::644])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9130603CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Jun 2020 20:52:41 +0200 (CEST)", "by mail-pl1-x644.google.com with SMTP id x11so301039plv.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 01 Jun 2020 11:52:41 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.174])\n\tby smtp.gmail.com with ESMTPSA id e1sm202373pgj.0.2020.06.01.11.52.37\n\t(version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 01 Jun 2020 11:52:39 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=es-iitr-ac-in.20150623.gappssmtp.com\n\theader.i=@es-iitr-ac-in.20150623.gappssmtp.com header.b=\"tIUPhx50\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:mime-version:content-disposition\n\t:user-agent; bh=NgddyykCe8XX7oARe181wLutApW0ZspaG7EFqCjkrAY=;\n\tb=tIUPhx50aVOU4s7NOUkzzikS6iisSzM0bsDoE9AnwFcwd6SlxGQhYvKKJLSQRHRLIi\n\tDbizi0rizGkWsYEfALDaKvtxGiAx7x7uCH7NaQ7pZmiHxCbjac2FBZoO2Zuw/t0gMayP\n\tgAH9+66VA7I0H15dXY8miSRGv1C14WMPaD7Y9tsfth0IJ+i5qX1XUpn0VXcpHblC1L+H\n\t7co9aa1WzR7HNdfQiNgqMlb8zwI+69zP0l6t81taG976OEogiS5zdgo2QojmwNTvOkDy\n\tnvJWXL0JbJtqoN7U2Nj9HsURnpmlaGqcMYpOOmkfdpfpmFqtfjIK/9hKK1TaOsJ2Rd6l\n\tQW6A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:mime-version\n\t:content-disposition:user-agent;\n\tbh=NgddyykCe8XX7oARe181wLutApW0ZspaG7EFqCjkrAY=;\n\tb=CvzfJ1qAyFRmKFg7fwp9J3xv2jikNN9J1X2Fo86VgKfnoo25vFh+brdcV2DNhtjP6b\n\tpby9vL2gm+/0lzrHOjbKigxUzbMBDvAkrVfJ6KFFcodPSSzYj5Bx7WY/QctZ85sctxzb\n\tTjnxMOYDIT3xFH1AePurPqD4cq+fyZ5J020LJcq47RHzohXfGeYDrukaoNCx6gS4UddX\n\t564jkpwHG7Q/Gp3o3/a6a3jMbXrAqmz7XF/Tqje2OM5HMPAYVE/gFd0qhaBX0OG82Tq9\n\tlHOBGC/86SdsPWJtuhMfCV2pHRv+/jWt6BW15Pdn4xpHMer5TbuuePaeV6wZUbFND+Ez\n\t409Q==", "X-Gm-Message-State": "AOAM532OldlyxTiRP99esLqtPdMBIIS9V6EPcl03+ynZFntMKLzwXzCj\n\t5+jWAu+eWnxd+vv2KmTMP/D6B7n20BxKNQ==", "X-Google-Smtp-Source": "ABdhPJysyR8bFZtdER5LjPQNVyofHpztGeIXQfuAR7fGaZhR/WkAyNaOUijPikvmPorHIqTjwDee3Q==", "X-Received": "by 2002:a17:90b:28d:: with SMTP id\n\taz13mr877291pjb.67.1591037559844; \n\tMon, 01 Jun 2020 11:52:39 -0700 (PDT)", "Date": "Tue, 2 Jun 2020 00:22:33 +0530", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Message-ID": "<20200601185233.GA26406@kaaira-HP-Pavilion-Notebook>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "User-Agent": "Mutt/1.9.4 (2018-02-28)", "Subject": "[libcamera-devel] [PATCH v3] libcamera: v4l2subdev: Print mbus\n\tstring instead of code", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 01 Jun 2020 18:52:42 -0000" }, "content": "Modify toString() to print mbus format string instead of its hex code as\nthe string is easier to understand.\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nAcked-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n\n(sending again because I missed the tags in the previous patch)\n\nChanges since V2:\n Re-formatted the code.\n\nChanges since v1:\n Add check for unsupported format.\n Rename struct\n\n\n src/libcamera/v4l2_subdevice.cpp | 175 +++++++++++++++++--------------\n 1 file changed, 96 insertions(+), 79 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 7aefc1b..f3cd04b 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -35,84 +35,93 @@ LOG_DECLARE_CATEGORY(V4L2)\n \n namespace {\n \n+/*\n+ * \\struct mbusFormatInfo\n+ * \\brief Bits per pixel and mbus format\n+ */\n+struct mbusFormatInfo {\n+\tunsigned int bits;\n+\tstd::string format;\n+};\n+\n /*\n * \\var formatInfoMap\n- * \\brief A map that associates bits per pixel to V4L2 media bus codes\n+ * \\brief A map that associates mbusFormatInfo struct to V4L2 media bus codes\n */\n-const std::map<uint32_t, unsigned int> formatInfoMap = {\n-\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, 16 },\n-\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, 16 },\n-\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, 16 },\n-\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, 16 },\n-\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, 16 },\n-\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, 16 },\n-\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, 16 },\n-\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, 16 },\n-\t{ V4L2_MBUS_FMT_RGB666_1X18, 18 },\n-\t{ V4L2_MBUS_FMT_RGB888_1X24, 24 },\n-\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, 24 },\n-\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, 24 },\n-\t{ V4L2_MBUS_FMT_ARGB8888_1X32, 32 },\n-\t{ V4L2_MBUS_FMT_Y8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_UV8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, 12 },\n-\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, 12 },\n-\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, 12 },\n-\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, 12 },\n-\t{ V4L2_MBUS_FMT_UYVY8_2X8, 16 },\n-\t{ V4L2_MBUS_FMT_VYUY8_2X8, 16 },\n-\t{ V4L2_MBUS_FMT_YUYV8_2X8, 16 },\n-\t{ V4L2_MBUS_FMT_YVYU8_2X8, 16 },\n-\t{ V4L2_MBUS_FMT_Y10_1X10, 10 },\n-\t{ V4L2_MBUS_FMT_UYVY10_2X10, 20 },\n-\t{ V4L2_MBUS_FMT_VYUY10_2X10, 20 },\n-\t{ V4L2_MBUS_FMT_YUYV10_2X10, 20 },\n-\t{ V4L2_MBUS_FMT_YVYU10_2X10, 20 },\n-\t{ V4L2_MBUS_FMT_Y12_1X12, 12 },\n-\t{ V4L2_MBUS_FMT_UYVY8_1X16, 16 },\n-\t{ V4L2_MBUS_FMT_VYUY8_1X16, 16 },\n-\t{ V4L2_MBUS_FMT_YUYV8_1X16, 16 },\n-\t{ V4L2_MBUS_FMT_YVYU8_1X16, 16 },\n-\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, 16 },\n-\t{ V4L2_MBUS_FMT_UYVY10_1X20, 20 },\n-\t{ V4L2_MBUS_FMT_VYUY10_1X20, 20 },\n-\t{ V4L2_MBUS_FMT_YUYV10_1X20, 20 },\n-\t{ V4L2_MBUS_FMT_YVYU10_1X20, 20 },\n-\t{ V4L2_MBUS_FMT_YUV10_1X30, 30 },\n-\t{ V4L2_MBUS_FMT_AYUV8_1X32, 32 },\n-\t{ V4L2_MBUS_FMT_UYVY12_2X12, 24 },\n-\t{ V4L2_MBUS_FMT_VYUY12_2X12, 24 },\n-\t{ V4L2_MBUS_FMT_YUYV12_2X12, 24 },\n-\t{ V4L2_MBUS_FMT_YVYU12_2X12, 24 },\n-\t{ V4L2_MBUS_FMT_UYVY12_1X24, 24 },\n-\t{ V4L2_MBUS_FMT_VYUY12_1X24, 24 },\n-\t{ V4L2_MBUS_FMT_YUYV12_1X24, 24 },\n-\t{ V4L2_MBUS_FMT_YVYU12_1X24, 24 },\n-\t{ V4L2_MBUS_FMT_SBGGR8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SGBRG8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SGRBG8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SRGGB8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, 8 },\n-\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, 16 },\n-\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, 16 },\n-\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, 16 },\n-\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, 16 },\n-\t{ V4L2_MBUS_FMT_SBGGR10_1X10, 10 },\n-\t{ V4L2_MBUS_FMT_SGBRG10_1X10, 10 },\n-\t{ V4L2_MBUS_FMT_SGRBG10_1X10, 10 },\n-\t{ V4L2_MBUS_FMT_SRGGB10_1X10, 10 },\n-\t{ V4L2_MBUS_FMT_SBGGR12_1X12, 12 },\n-\t{ V4L2_MBUS_FMT_SGBRG12_1X12, 12 },\n-\t{ V4L2_MBUS_FMT_SGRBG12_1X12, 12 },\n-\t{ V4L2_MBUS_FMT_SRGGB12_1X12, 12 },\n-\t{ V4L2_MBUS_FMT_AHSV8888_1X32, 32 },\n+const std::map<uint32_t, mbusFormatInfo> formatInfoMap = {\n+\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\" } },\n+\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\" } },\n+\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, { 16, \"RGB555_2X8_PADHI_BE\" } },\n+\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, { 16, \"RGB555_2X8_PADHI_LE\" } },\n+\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, { 16, \"BGR565_2X8_BE\" } },\n+\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, { 16, \"BGR565_2X8_LE\" } },\n+\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, { 16, \"RGB565_2X8_BE\" } },\n+\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\" } },\n+\t{ V4L2_MBUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\" } },\n+\t{ V4L2_MBUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\" } },\n+\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\" } },\n+\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\" } },\n+\t{ V4L2_MBUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\" } },\n+\t{ V4L2_MBUS_FMT_Y8_1X8, { 8, \"Y8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_UV8_1X8, { 8, \"UV8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, { 12, \"UYVY8_1_5X8\" } },\n+\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, { 12, \"VYUY8_1_5X8\" } },\n+\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, { 12, \"YUYV8_1_5X8\" } },\n+\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, { 12, \"YVYU8_1_5X8\" } },\n+\t{ V4L2_MBUS_FMT_UYVY8_2X8, { 16, \"UYVY8_2X8\" } },\n+\t{ V4L2_MBUS_FMT_VYUY8_2X8, { 16, \"VYUY8_2X8\" } },\n+\t{ V4L2_MBUS_FMT_YUYV8_2X8, { 16, \"YUYV8_2X8\" } },\n+\t{ V4L2_MBUS_FMT_YVYU8_2X8, { 16, \"YVYU8_2X8\" } },\n+\t{ V4L2_MBUS_FMT_Y10_1X10, { 10, \"Y10_1X10\" } },\n+\t{ V4L2_MBUS_FMT_UYVY10_2X10, { 20, \"UYVY10_2X10\" } },\n+\t{ V4L2_MBUS_FMT_VYUY10_2X10, { 20, \"VYUY10_2X10\" } },\n+\t{ V4L2_MBUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\" } },\n+\t{ V4L2_MBUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\" } },\n+\t{ V4L2_MBUS_FMT_Y12_1X12, { 12, \"Y12_1X12\" } },\n+\t{ V4L2_MBUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\" } },\n+\t{ V4L2_MBUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\" } },\n+\t{ V4L2_MBUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\" } },\n+\t{ V4L2_MBUS_FMT_YVYU8_1X16, { 16, \"YVYU8_1X16\" } },\n+\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, { 16, \"YDYUYDYV8_1X16\" } },\n+\t{ V4L2_MBUS_FMT_UYVY10_1X20, { 20, \"UYVY10_1X20\" } },\n+\t{ V4L2_MBUS_FMT_VYUY10_1X20, { 20, \"VYUY10_1X20\" } },\n+\t{ V4L2_MBUS_FMT_YUYV10_1X20, { 20, \"YUYV10_1X20\" } },\n+\t{ V4L2_MBUS_FMT_YVYU10_1X20, { 20, \"YVYU10_1X20\" } },\n+\t{ V4L2_MBUS_FMT_YUV10_1X30, { 30, \"YUV10_1X30\" } },\n+\t{ V4L2_MBUS_FMT_AYUV8_1X32, { 32, \"AYUV8_1X32\" } },\n+\t{ V4L2_MBUS_FMT_UYVY12_2X12, { 24, \"UYVY12_2X12\" } },\n+\t{ V4L2_MBUS_FMT_VYUY12_2X12, { 24, \"VYUY12_2X12\" } },\n+\t{ V4L2_MBUS_FMT_YUYV12_2X12, { 24, \"YUYV12_2X12\" } },\n+\t{ V4L2_MBUS_FMT_YVYU12_2X12, { 24, \"YVYU12_2X12\" } },\n+\t{ V4L2_MBUS_FMT_UYVY12_1X24, { 24, \"UYVY12_1X24\" } },\n+\t{ V4L2_MBUS_FMT_VYUY12_1X24, { 24, \"VYUY12_1X24\" } },\n+\t{ V4L2_MBUS_FMT_YUYV12_1X24, { 24, \"YUYV12_1X24\" } },\n+\t{ V4L2_MBUS_FMT_YVYU12_1X24, { 24, \"YVYU12_1X24\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR8_1X8, { 8, \"SBGGR8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SGBRG8_1X8, { 8, \"SGBRG8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SGRBG8_1X8, { 8, \"SGRBG8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SRGGB8_1X8, { 8, \"SRGGB8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, { 8, \"SBGGR10_ALAW8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, { 8, \"SGBRG10_ALAW8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, { 8, \"SGRBG10_ALAW8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, { 8, \"SRGGB10_ALAW8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, { 8, \"SBGGR10_DPCM8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, { 8, \"SGBRG10_DPCM8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, { 8, \"SGRBG10_DPCM8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, { 8, \"SRGGB10_DPCM8_1X8\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, { 16, \"SBGGR10_2X8_PADHI_BE\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, { 16, \"SBGGR10_2X8_PADHI_LE\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, { 16, \"SBGGR10_2X8_PADLO_BE\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, { 16, \"SBGGR10_2X8_PADLO_LE\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR10_1X10, { 10, \"SBGGR10_1X10\" } },\n+\t{ V4L2_MBUS_FMT_SGBRG10_1X10, { 10, \"SGBRG10_1X10\" } },\n+\t{ V4L2_MBUS_FMT_SGRBG10_1X10, { 10, \"SGRBG10_1X10\" } },\n+\t{ V4L2_MBUS_FMT_SRGGB10_1X10, { 10, \"SRGGB10_1X10\" } },\n+\t{ V4L2_MBUS_FMT_SBGGR12_1X12, { 12, \"SBGGR12_1X12\" } },\n+\t{ V4L2_MBUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\" } },\n+\t{ V4L2_MBUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\" } },\n+\t{ V4L2_MBUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\" } },\n+\t{ V4L2_MBUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\" } },\n };\n \n } /* namespace */\n@@ -161,9 +170,17 @@ const std::map<uint32_t, unsigned int> formatInfoMap = {\n */\n const std::string V4L2SubdeviceFormat::toString() const\n {\n-\tstd::stringstream ss;\n-\tss << size.toString() << \"-\" << utils::hex(mbus_code, 4);\n-\treturn ss.str();\n+\tstd::stringstream mbus;\n+\tmbus << size.toString() << \"-\";\n+\n+\tconst auto it = formatInfoMap.find(mbus_code);\n+\n+\tif (it == formatInfoMap.end())\n+\t\tmbus << utils::hex(mbus_code, 4);\n+\telse\n+\t\tmbus << it->second.format;\n+\n+\treturn mbus.str();\n }\n \n /**\n@@ -180,7 +197,7 @@ uint8_t V4L2SubdeviceFormat::bitsPerPixel() const\n \t\treturn 0;\n \t}\n \n-\treturn it->second;\n+\treturn it->second.bits;\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v3" ] }