Patch Detail
Show a patch.
GET /api/patches/3876/?format=api
{ "id": 3876, "url": "https://patchwork.libcamera.org/api/patches/3876/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3876/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200529071646.123149-1-naush@raspberrypi.com>", "date": "2020-05-29T07:16:46", "name": "[libcamera-devel,v2] pipeline: raspberrypi: Fix for staggered write on reset", "commit_ref": "5dfd2bfc0dff958394bf08de104384c56a65f626", "pull_url": null, "state": "accepted", "archived": false, "hash": "f676fcaea56b1bc111f0265f4e84d7eb7551c712", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3876/mbox/", "series": [ { "id": 937, "url": "https://patchwork.libcamera.org/api/series/937/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=937", "date": "2020-05-29T07:16:46", "name": "[libcamera-devel,v2] pipeline: raspberrypi: Fix for staggered write on reset", "version": 2, "mbox": "https://patchwork.libcamera.org/series/937/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3876/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3876/checks/", "tags": {}, "headers": { "Return-Path": "<naush@raspberrypi.com>", "Received": [ "from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEADB603CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 May 2020 09:16:59 +0200 (CEST)", "by mail-wm1-x343.google.com with SMTP id h4so2002063wmb.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 May 2020 00:16:59 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tr4sm8668849wro.32.2020.05.29.00.16.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 May 2020 00:16:57 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Ghfv5oMv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=soaHbx0SRnNGamhNaO3oA35SUJCWpzFvTUZjcj5xtmY=;\n\tb=Ghfv5oMvROnQGYKXgq6ZQ/9i27EO05AQS63wxVt691HaGA2UZRxIFnzI6O5oZDdZ9K\n\tzLuZEu769Qg0XrNrhHOZ8MIZOkFinVEt46ezhGSaU75K3ineKjkJS4q2n40ERKgRKl09\n\tLNkoV99WK/+8hUTc1qr08FNsnIrPK4UjStge6iyOqJze2dJr5Ua/vE9MbxA29lRmSPFf\n\tB6Z1/Uf13tkox6Jx6J48FhDwyJdtRnBz3yHKvufl4x+ALyEnr0NqyEPHSmSFXqbg/mrR\n\tOqTuhmPIxQaSLue5W4Bwp4mnQ5ptaKXyefBNXbA3h9f6WU6DQg2MsW24ahgtNSF5TLa0\n\tuGfg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=soaHbx0SRnNGamhNaO3oA35SUJCWpzFvTUZjcj5xtmY=;\n\tb=e3vwIk40AFrU7VAJSUjbUpussOOTZoOWwl3yWRV4yzkHYKvDlmxgHUP+BUAbwDac1s\n\tp2Zzv/2LYvP8kd3iOZ5c/Kzo2S5Q3Bn7aLW2xOB66tzD9wwgPYy7hWYVS+5gDpiNZFyF\n\tXv0TE+Kqg6SqUjKFJkGPdCEJwRxp+ldQLXAoWF7nceyzMU1y2BoukG2AiofR2vSjfs4z\n\tzi+ifzlG5VSGhfkGexPzdz8pRGMvoY1ILwWMSRlTISZzg5s2vWtkTX4XVMdy62ODXQPX\n\t9YBbu0RXkUVo2rSHXQpXpevWqYkRnWJQcDyoBS8O+WH7DxKBKqhWfrhZ3z8Qi3LmrB5w\n\tUOxg==", "X-Gm-Message-State": "AOAM531GaczZicOW3Ly9XXYFPT96iyYWmnhcPTF6VjYqLlZwORepOJVf\n\t4fV211RStBTEAZ/5vwMDdjR4tgWtB1pF1g==", "X-Google-Smtp-Source": "ABdhPJwZ9QhXoFJ4xNkLN6qQYEsFt86/jBc66/uANWpHAlBSNVTVyPIwzPFt7GeHa4CqIJxfPRk6YQ==", "X-Received": "by 2002:a1c:810a:: with SMTP id\n\tc10mr7080798wmd.107.1590736618094; \n\tFri, 29 May 2020 00:16:58 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 May 2020 08:16:46 +0100", "Message-Id": "<20200529071646.123149-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] pipeline: raspberrypi: Fix for\n\tstaggered write on reset", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 29 May 2020 07:17:00 -0000" }, "content": "The reset function in staggered write was using the wrong index when\nlooking for the last updated camera parameters. This would cause\npossibly stale exposure values to be written to the camera on a\nmode switch for captures.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\nindex 391e13f5..5ed63a8e 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n@@ -46,7 +46,7 @@ void StaggeredCtrl::reset()\n {\n \tstd::lock_guard<std::mutex> lock(lock_);\n \n-\tint lastSetCount = std::max<int>(0, setCount_ - 1);\n+\tint lastSetCount = setCount_;\n \tstd::unordered_map<uint32_t, int32_t> lastVal;\n \n \t/* Reset the counters. */\n", "prefixes": [ "libcamera-devel", "v2" ] }