Patch Detail
Show a patch.
GET /api/patches/3873/?format=api
{ "id": 3873, "url": "https://patchwork.libcamera.org/api/patches/3873/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3873/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200528145610.96585-1-naush@raspberrypi.com>", "date": "2020-05-28T14:56:10", "name": "[libcamera-devel] pipeline: raspberrypi: Fix for staggered write on reset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d9e4532b37f292bd8461694e5bf422b590ce4c00", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3873/mbox/", "series": [ { "id": 935, "url": "https://patchwork.libcamera.org/api/series/935/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=935", "date": "2020-05-28T14:56:10", "name": "[libcamera-devel] pipeline: raspberrypi: Fix for staggered write on reset", "version": 1, "mbox": "https://patchwork.libcamera.org/series/935/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3873/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3873/checks/", "tags": {}, "headers": { "Return-Path": "<naush@raspberrypi.com>", "Received": [ "from mail-wm1-x344.google.com (mail-wm1-x344.google.com\n\t[IPv6:2a00:1450:4864:20::344])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F13F7603D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 May 2020 16:56:58 +0200 (CEST)", "by mail-wm1-x344.google.com with SMTP id k26so3504583wmi.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 May 2020 07:56:58 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tn1sm6148786wrp.10.2020.05.28.07.56.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 May 2020 07:56:56 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Cjg72J38\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ID/1DFSPVuzcaftDoa7/nRMLlBxQx2xZ8JyhKbsf0d8=;\n\tb=Cjg72J38xO7Tn2Ef5ukrQbUtQoQNZNjvdUE78fwWTGP3hSU+g+0tBSzGB+JOS59mPM\n\tZFuQXiysRk7WGrKkBBQFD32FItSfvndqCapyxXroO2Ur+tuSIp154qhAUwH6xDHUedUS\n\tGDXBzLUjPlq7AdukhVmVPli+PDY9OBvFsBRRuVLlf2fCKH5wOrx4HpA99aJh1EXax1F+\n\tVMjtszU4crXr49hD2amPmvZzvEtax80i1ZG68pjoYN/YnBQ11vTGwuxTjdqqF8NsQi/L\n\tGXPE0i/UP15LT9e4ShFd2X9HTncPFxz+2tyQN28DxOGly8qKroEimu6KIGTdrXMkLbZh\n\t34aQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ID/1DFSPVuzcaftDoa7/nRMLlBxQx2xZ8JyhKbsf0d8=;\n\tb=USyjno7Gi6FJEb4eWEm8yrmMwxEaew4u2XBjsQpMwKE8Urr1dcw5E1MZ+cjuof4rx9\n\tzG6pYy7Vk1+w3I27qmqVVRFQ8lbMVnZK58Fv6HaR9WShLXtTeIrGZXwkD7nMsxTeIF74\n\tZjx2F4RfNALRxtXd73VvyrNizM8sZpCWiIhktXxELqN6XNZpLjafi3EGBWGwtMilPQ28\n\tuj535EnzsiXSmQBKix6uneZWeitg9I7lQv1BHB0r0EOs8lQGwWSIxD5CrcTJgM8jYloI\n\t+49NDe8mPz2evzyLz+ONZbsCX2mgAPYb3Nu3I0Yl99+vVC3HMGG0bqOuvxmzx4XosNca\n\tnlfw==", "X-Gm-Message-State": "AOAM5337M3CxzCDFU4G2CvwaaejxkAUW8IafeV7OgAqMt64Fwo2WFVqY\n\tEpvxU5tvvIBOPL5eKAZwQZZ9CRFjJP59rA==", "X-Google-Smtp-Source": "ABdhPJzQnIFcz5rW04hMGTScPeOwa6LHlufIyaniGxk5XKzWaC4Z7Z7g1c03Cg05PyqqV7Qt3WGuAA==", "X-Received": "by 2002:a1c:7e43:: with SMTP id z64mr3660868wmc.72.1590677818248;\n\tThu, 28 May 2020 07:56:58 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 28 May 2020 15:56:10 +0100", "Message-Id": "<20200528145610.96585-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] pipeline: raspberrypi: Fix for staggered\n\twrite on reset", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 May 2020 14:56:59 -0000" }, "content": "The reset function in staggered write was using the wrong index when\nlooking for the last updated camera parameters. This would cause\npossibly stale exposure values to be written to the camera on a\nmode switch for captures.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\nindex 391e13f5..b26fa63d 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n@@ -46,7 +46,7 @@ void StaggeredCtrl::reset()\n {\n \tstd::lock_guard<std::mutex> lock(lock_);\n \n-\tint lastSetCount = std::max<int>(0, setCount_ - 1);\n+\tint lastSetCount = std::max<int>(0, setCount_);\n \tstd::unordered_map<uint32_t, int32_t> lastVal;\n \n \t/* Reset the counters. */\n", "prefixes": [ "libcamera-devel" ] }