Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 3858,
    "url": "https://patchwork.libcamera.org/api/patches/3858/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/3858/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200526133105.3289924-1-niklas.soderlund@ragnatech.se>",
    "date": "2020-05-26T13:31:05",
    "name": "[libcamera-devel] libcamera: raspberry: Align include guard",
    "commit_ref": "c6e9c750f63bbfcd323287854513d967c57fe0b2",
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "5cbb59857b0fb4651f2c0784d88f8c6093f95151",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/3858/mbox/",
    "series": [
        {
            "id": 929,
            "url": "https://patchwork.libcamera.org/api/series/929/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=929",
            "date": "2020-05-26T13:31:05",
            "name": "[libcamera-devel] libcamera: raspberry: Align include guard",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/929/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/3858/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/3858/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C9F060E08\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 May 2020 15:31:22 +0200 (CEST)",
            "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 21719927-9f55-11ea-80f7-005056917a89;\n\tTue, 26 May 2020 15:31:10 +0200 (CEST)"
        ],
        "X-Halon-ID": "21719927-9f55-11ea-80f7-005056917a89",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Tue, 26 May 2020 15:31:05 +0200",
        "Message-Id": "<20200526133105.3289924-1-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.26.2",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH] libcamera: raspberry: Align include guard",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Tue, 26 May 2020 13:31:22 -0000"
    },
    "content": "The preprocessor directive '#pragma once' is non-standard, replace it\nwith the include guard used elsewhere in libcamera.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.h | 5 ++++-\n src/libcamera/pipeline/raspberrypi/vcsm.h           | 5 ++++-\n 2 files changed, 8 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\nindex eef16eaac235093c..1076fde3e9ee5d74 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n@@ -4,7 +4,8 @@\n  *\n  * staggered_ctrl.h - Helper for writing staggered ctrls to a V4L2 device.\n  */\n-#pragma once\n+#ifndef __LIBCAMERA_PIPELINE_RASPBERRYPI_STAGGERED_CTRL_H__\n+#define __LIBCAMERA_PIPELINE_RASPBERRYPI_STAGGERED_CTRL_H__\n \n #include <array>\n #include <initializer_list>\n@@ -91,3 +92,5 @@ private:\n } /* namespace RPi */\n \n } /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_PIPELINE_RASPBERRYPI_STAGGERED_CTRL_H__ */\ndiff --git a/src/libcamera/pipeline/raspberrypi/vcsm.h b/src/libcamera/pipeline/raspberrypi/vcsm.h\nindex daa06961e0571e35..e32c258809b7100c 100644\n--- a/src/libcamera/pipeline/raspberrypi/vcsm.h\n+++ b/src/libcamera/pipeline/raspberrypi/vcsm.h\n@@ -4,7 +4,8 @@\n  *\n  * vcsm.h - Helper class for vcsm allocations.\n  */\n-#pragma once\n+#ifndef __LIBCAMERA_PIPELINE_RASPBERRYPI_VCSM_H__\n+#define __LIBCAMERA_PIPELINE_RASPBERRYPI_VCSM_H__\n \n #include <iostream>\n #include <mutex>\n@@ -144,3 +145,5 @@ private:\n };\n \n } /* namespace RPi */\n+\n+#endif /* __LIBCAMERA_PIPELINE_RASPBERRYPI_VCSM_H__ */\n",
    "prefixes": [
        "libcamera-devel"
    ]
}