Patch Detail
Show a patch.
GET /api/patches/3844/?format=api
{ "id": 3844, "url": "https://patchwork.libcamera.org/api/patches/3844/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3844/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200522145459.16836-6-laurent.pinchart@ideasonboard.com>", "date": "2020-05-22T14:54:52", "name": "[libcamera-devel,PATCH/RFC,04/11] libcamera: pixel_format: Make PixelFormat usable as a constexpr", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "086c7f43a856bd1a281566b7a2650a71ac009074", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3844/mbox/", "series": [ { "id": 923, "url": "https://patchwork.libcamera.org/api/series/923/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=923", "date": "2020-05-22T14:54:47", "name": "Introduce formats:: namespace for libcamera pixel formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/923/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3844/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3844/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D026261093\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 May 2020 16:55:20 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 65EC5528\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 May 2020 16:55:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"c+cmQMQB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590159320;\n\tbh=EjaHA3mCUC1q9lumqgXwfmJ5iTZYRoYKvTME5PCWUtk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=c+cmQMQBkzGBSdWJzD9AkdBoLq8+tEiZvZ71h7GGhVxEejSYRL4K+I1iC6HyEBywf\n\t3dIiG8o2BRlY1NVeHDNs8m07qiuB7wO1wPpUqVJbrCZlkVmffi1cVW0sbVYF3XMGVd\n\tTJrwMoD8tfBr2Y8vHvz93LCpLBLcsrD9Q7Wk6Oco=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 May 2020 17:54:52 +0300", "Message-Id": "<20200522145459.16836-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>", "References": "<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH/RFC 04/11] libcamera: pixel_format: Make\n\tPixelFormat usable as a constexpr", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 22 May 2020 14:55:24 -0000" }, "content": "The PixelFormat class is a lightweight wrapper around a 32-bit FourCC\nand a 64-bit modifier. Make is usable as a constexpr.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/pixel_format.h | 19 +++++++++++++------\n src/libcamera/pixel_format.cpp | 10 ++--------\n 2 files changed, 15 insertions(+), 14 deletions(-)", "diff": "diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\nindex e3b371ef92bb..8dfeb8922418 100644\n--- a/include/libcamera/pixel_format.h\n+++ b/include/libcamera/pixel_format.h\n@@ -18,18 +18,25 @@ namespace libcamera {\n class PixelFormat\n {\n public:\n-\tPixelFormat();\n-\texplicit PixelFormat(uint32_t fourcc, uint64_t modifier = 0);\n+\tconstexpr PixelFormat()\n+\t\t: fourcc_(0), modifier_(0)\n+\t{\n+\t}\n+\n+\texplicit constexpr PixelFormat(uint32_t fourcc, uint64_t modifier = 0)\n+\t\t: fourcc_(fourcc), modifier_(modifier)\n+\t{\n+\t}\n \n \tbool operator==(const PixelFormat &other) const;\n \tbool operator!=(const PixelFormat &other) const { return !(*this == other); }\n \tbool operator<(const PixelFormat &other) const;\n \n-\tbool isValid() const { return fourcc_ != 0; }\n+\tconstexpr bool isValid() const { return fourcc_ != 0; }\n \n-\toperator uint32_t() const { return fourcc_; }\n-\tuint32_t fourcc() const { return fourcc_; }\n-\tuint64_t modifier() const { return modifier_; }\n+\tconstexpr operator uint32_t() const { return fourcc_; }\n+\tconstexpr uint32_t fourcc() const { return fourcc_; }\n+\tconstexpr uint64_t modifier() const { return modifier_; }\n \n \tstd::string toString() const;\n \ndiff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\nindex d8718739152d..d501c5f09c6b 100644\n--- a/src/libcamera/pixel_format.cpp\n+++ b/src/libcamera/pixel_format.cpp\n@@ -25,25 +25,19 @@ namespace libcamera {\n */\n \n /**\n+ * \\fn PixelFormat::PixelFormat()\n * \\brief Construct a PixelFormat with an invalid format\n *\n * PixelFormat instances constructed with the default constructor are\n * invalid, calling the isValid() function returns false.\n */\n-PixelFormat::PixelFormat()\n-\t: fourcc_(0)\n-{\n-}\n \n /**\n+ * \\fn PixelFormat::PixelFormat(uint32_t fourcc, uint64_t modifier)\n * \\brief Construct a PixelFormat from a DRM FourCC and a modifier\n * \\param[in] fourcc A DRM FourCC\n * \\param[in] modifier A DRM FourCC modifier\n */\n-PixelFormat::PixelFormat(uint32_t fourcc, uint64_t modifier)\n-\t: fourcc_(fourcc), modifier_(modifier)\n-{\n-}\n \n /**\n * \\brief Compare pixel formats for equality\n", "prefixes": [ "libcamera-devel", "PATCH/RFC", "04/11" ] }