Patch Detail
Show a patch.
GET /api/patches/378/?format=api
{ "id": 378, "url": "https://patchwork.libcamera.org/api/patches/378/?format=api", "web_url": "https://patchwork.libcamera.org/patch/378/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190125145417.5384-1-laurent.pinchart@ideasonboard.com>", "date": "2019-01-25T14:54:17", "name": "[libcamera-devel] cam: Add event loop", "commit_ref": "71ef5532d9777e9511bc982cab33e3d2d95cf4be", "pull_url": null, "state": "accepted", "archived": false, "hash": "858b03f09e5cf63d765482be03da3b90081eb373", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/378/mbox/", "series": [ { "id": 131, "url": "https://patchwork.libcamera.org/api/series/131/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=131", "date": "2019-01-25T14:54:17", "name": "[libcamera-devel] cam: Add event loop", "version": 1, "mbox": "https://patchwork.libcamera.org/series/131/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/378/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/378/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75D9660B1D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jan 2019 15:54:24 +0100 (CET)", "from pendragon.home (unknown\n\t[IPv6:2a02:a03f:4499:2700:1060:1d4c:d6a:8e80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ECA13325\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jan 2019 15:54:20 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548428061;\n\tbh=WgJyvxZAT4V1OiJYdki6SXSK3lNV1pqyRymoATteDt0=;\n\th=From:To:Subject:Date:From;\n\tb=UdcSnmizGRVL6OlF0gLHjoZdG+HDtQV6W1CRcSVpoqIgHx+itO9y2Ne4osbD194PK\n\tQzaYnXAZPes+btFooIxDbxZDrt+eWvEcNDq1S8JMIWo2exmrUEkxxQhp2QS4ls+9x0\n\t7QCas92td1+xPToiHFo9aOEXbfc/K/Xx7b7j3Rig=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 25 Jan 2019 16:54:17 +0200", "Message-Id": "<20190125145417.5384-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] cam: Add event loop", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 25 Jan 2019 14:54:24 -0000" }, "content": "Add a simple event loop to the cam application and use it in the main()\nfunction, with an example of how to handle SIGINT to gracefully stop the\nloop.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/event_loop.cpp | 39 +++++++++++++++++++++++++++++++++++++++\n src/cam/event_loop.h | 34 ++++++++++++++++++++++++++++++++++\n src/cam/main.cpp | 22 +++++++++++++++++++++-\n src/cam/meson.build | 1 +\n 4 files changed, 95 insertions(+), 1 deletion(-)\n create mode 100644 src/cam/event_loop.cpp\n create mode 100644 src/cam/event_loop.h", "diff": "diff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\nnew file mode 100644\nindex 000000000000..e8ab861790ed\n--- /dev/null\n+++ b/src/cam/event_loop.cpp\n@@ -0,0 +1,39 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * event_loop.cpp - cam - Event loop\n+ */\n+\n+#include <libcamera/event_dispatcher.h>\n+\n+#include \"event_loop.h\"\n+\n+using namespace libcamera;\n+\n+EventLoop::EventLoop(EventDispatcher *dispatcher)\n+\t: dispatcher_(dispatcher)\n+{\n+}\n+\n+EventLoop::~EventLoop()\n+{\n+}\n+\n+int EventLoop::exec()\n+{\n+\texitCode_ = -1;\n+\texit_.store(false, std::memory_order_release);\n+\n+\twhile (!exit_.load(std::memory_order_acquire))\n+\t\tdispatcher_->processEvents();\n+\n+\treturn exitCode_;\n+}\n+\n+void EventLoop::exit(int code)\n+{\n+\texitCode_ = code;\n+\texit_.store(true, std::memory_order_release);\n+\tdispatcher_->interrupt();\n+}\ndiff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\nnew file mode 100644\nindex 000000000000..aaca5838f979\n--- /dev/null\n+++ b/src/cam/event_loop.h\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * event_loop.h - cam - Event loop\n+ */\n+#ifndef __CAM_EVENT_LOOP_H__\n+#define __CAM_EVENT_LOOP_H__\n+\n+#include <atomic>\n+\n+#include <libcamera/event_notifier.h>\n+\n+namespace libcamera {\n+class EventDispatcher;\n+};\n+\n+class EventLoop\n+{\n+public:\n+\tEventLoop(libcamera::EventDispatcher *dispatcher);\n+\t~EventLoop();\n+\n+\tint exec();\n+\tvoid exit(int code = 0);\n+\n+private:\n+\tlibcamera::EventDispatcher *dispatcher_;\n+\n+\tstd::atomic<bool> exit_;\n+\tint exitCode_;\n+};\n+\n+#endif /* __CAM_EVENT_LOOP_H__ */\ndiff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 0d37039f5349..cb98d302dcf3 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -7,10 +7,12 @@\n \n #include <iostream>\n #include <map>\n+#include <signal.h>\n #include <string.h>\n \n #include <libcamera/libcamera.h>\n \n+#include \"event_loop.h\"\n #include \"options.h\"\n \n using namespace libcamera;\n@@ -23,6 +25,14 @@ enum {\n \tOptList = 'l',\n };\n \n+EventLoop *loop;\n+\n+void signalHandler(int signal)\n+{\n+\tstd::cout << \"Exiting\" << std::endl;\n+\tloop->exit();\n+}\n+\n static int parseOptions(int argc, char *argv[])\n {\n \tOptionsParser parser;\n@@ -79,7 +89,17 @@ int main(int argc, char **argv)\n \t\t}\n \t}\n \n+\tloop = new EventLoop(cm->eventDispatcher());\n+\n+\tstruct sigaction sa = {};\n+\tsa.sa_handler = &signalHandler;\n+\tsigaction(SIGINT, &sa, nullptr);\n+\n+\tret = loop->exec();\n+\n+\tdelete loop;\n+\n \tcm->stop();\n \n-\treturn 0;\n+\treturn ret;\n }\ndiff --git a/src/cam/meson.build b/src/cam/meson.build\nindex e45e5391f679..cc647523955f 100644\n--- a/src/cam/meson.build\n+++ b/src/cam/meson.build\n@@ -1,4 +1,5 @@\n cam_sources = files([\n+ 'event_loop.cpp',\n 'main.cpp',\n 'options.cpp',\n ])\n", "prefixes": [ "libcamera-devel" ] }