Patch Detail
Show a patch.
GET /api/patches/3776/?format=api
{ "id": 3776, "url": "https://patchwork.libcamera.org/api/patches/3776/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3776/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200512000322.11753-23-laurent.pinchart@ideasonboard.com>", "date": "2020-05-12T00:03:20", "name": "[libcamera-devel,22/24] utils: raspberrypi: ctt: Fix pycodestyle E741", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7748547ca55d0b0af9be3b2b913896ce24ee0fd3", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3776/mbox/", "series": [ { "id": 897, "url": "https://patchwork.libcamera.org/api/series/897/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=897", "date": "2020-05-12T00:02:58", "name": "utils: raspberrypi: ctt: Comply with pycodestyle", "version": 1, "mbox": "https://patchwork.libcamera.org/series/897/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3776/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3776/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E09B360E38\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2020 02:03:47 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D8FD33E;\n\tTue, 12 May 2020 02:03:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YjYdc/qa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589241827;\n\tbh=rgsOsGt+tVmmcbA4kGLjwqlo/Ju4yD6IKzXoFCF0zfs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YjYdc/qaYtQiksGStpBCKNXYipOriSZNyH9Nkb5r/bzGey1tb0lEFkgyuqBuEwSLF\n\tsUp9LMPI/BZSPhKvZQEdp/hT+dOAzaDqGMZD7qki6HvPlK7oNfDgCYNYSGYlnAHjde\n\tgLJBwHgKa9Th2ZY4oBHZ4iQiBr9hlGLTI1ArxvyU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 May 2020 03:03:20 +0300", "Message-Id": "<20200512000322.11753-23-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>", "References": "<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 22/24] utils: raspberrypi: ctt: Fix\n\tpycodestyle E741", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 May 2020 00:03:48 -0000" }, "content": "E741 ambiguous variable name 'l'\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/raspberrypi/ctt/ctt.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\nindex cb01a517e8bc..8f8e06f069df 100755\n--- a/utils/raspberrypi/ctt/ctt.py\n+++ b/utils/raspberrypi/ctt/ctt.py\n@@ -478,8 +478,8 @@ class Camera:\n \"\"\"\n take the average of the interquartile\n \"\"\"\n- l = len(noise_out)\n- noise_out = np.mean(noise_out[l//4:1+3*l//4], axis=0)\n+ length = len(noise_out)\n+ noise_out = np.mean(noise_out[length//4:1+3*length//4], axis=0)\n self.log += '\\nAverage noise profile: constant = {} '.format(int(noise_out[1]))\n self.log += 'slope = {:.3f}'.format(noise_out[0])\n \"\"\"\n", "prefixes": [ "libcamera-devel", "22/24" ] }