Patch Detail
Show a patch.
GET /api/patches/3772/?format=api
{ "id": 3772, "url": "https://patchwork.libcamera.org/api/patches/3772/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3772/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200512000322.11753-19-laurent.pinchart@ideasonboard.com>", "date": "2020-05-12T00:03:16", "name": "[libcamera-devel,18/24] utils: raspberrypi: ctt: Fix pycodestyle E713", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "75f0f23edb6e5bd4da069dbe1c06d6de0f5c6196", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3772/mbox/", "series": [ { "id": 897, "url": "https://patchwork.libcamera.org/api/series/897/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=897", "date": "2020-05-12T00:02:58", "name": "utils: raspberrypi: ctt: Comply with pycodestyle", "version": 1, "mbox": "https://patchwork.libcamera.org/series/897/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3772/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3772/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8813060DF9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2020 02:03:45 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8C3211F6;\n\tTue, 12 May 2020 02:03:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gsIQvt8X\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589241825;\n\tbh=4IZZdoN0Og6HNynzINvU4JR3yEDmfU1J2rOMd6jYbuY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gsIQvt8XFlEgafrPnbjFAnEVuB3NipFAF7YXDRdHz3HHpSV3RcxL7ZlWFyYNG9IB5\n\tunhRMKFlgCABYhK+3pcNntd0LqodiGODbmD+cPNO/S29saKn1GFZpE1SrFaxOMpMAR\n\tZCxcgnI+B7vBWYpDRRCXdlP9bJEyORcsaGVo4+T8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 May 2020 03:03:16 +0300", "Message-Id": "<20200512000322.11753-19-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>", "References": "<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 18/24] utils: raspberrypi: ctt: Fix\n\tpycodestyle E713", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 May 2020 00:03:45 -0000" }, "content": "E713 test for membership should be 'not in'\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/raspberrypi/ctt/ctt.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\nindex 3ebd10711d94..6caa5a552230 100755\n--- a/utils/raspberrypi/ctt/ctt.py\n+++ b/utils/raspberrypi/ctt/ctt.py\n@@ -216,7 +216,7 @@ class Camera:\n Check if alsc tables have been generated, if not then do ccm without\n alsc\n \"\"\"\n- if (not \"rpi.alsc\" in self.disable) and do_alsc_colour:\n+ if (\"rpi.alsc\" not in self.disable) and do_alsc_colour:\n \"\"\"\n case where ALSC colour has been done, so no errors should be\n expected...\n@@ -285,7 +285,7 @@ class Camera:\n Check if alsc tables have been generated, if not then do awb without\n alsc correction\n \"\"\"\n- if (not \"rpi.alsc\" in self.disable) and do_alsc_colour:\n+ if (\"rpi.alsc\" not in self.disable) and do_alsc_colour:\n try:\n cal_cr_list = self.json['rpi.alsc']['calibrations_Cr']\n cal_cb_list = self.json['rpi.alsc']['calibrations_Cb']\n", "prefixes": [ "libcamera-devel", "18/24" ] }