Patch Detail
Show a patch.
GET /api/patches/3765/?format=api
{ "id": 3765, "url": "https://patchwork.libcamera.org/api/patches/3765/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3765/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200512000322.11753-12-laurent.pinchart@ideasonboard.com>", "date": "2020-05-12T00:03:09", "name": "[libcamera-devel,11/24] utils: raspberrypi: ctt: Fix pycodestyle E303", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ab0dbefd8be0fe30a9ddf75ca5b6044642d30341", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3765/mbox/", "series": [ { "id": 897, "url": "https://patchwork.libcamera.org/api/series/897/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=897", "date": "2020-05-12T00:02:58", "name": "utils: raspberrypi: ctt: Comply with pycodestyle", "version": 1, "mbox": "https://patchwork.libcamera.org/series/897/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3765/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3765/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 337D760E17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2020 02:03:38 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6B3533E;\n\tTue, 12 May 2020 02:03:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ovsoo5wx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589241817;\n\tbh=UIRyqIApbSZYzAzjBh2jBmdAR79VG0JLcD9zJTA12z8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ovsoo5wxVgpm36Yrt/cfjeAxUteCXkS+LjoDrU0LIBj06IVaey48VpqDH+5rnZ6fF\n\tYY0+2IMq4IxzxtcgDyr0wqTHPx8lqmrbaKiDBrfcY10W4EBBTGU5DLV4aDjW1XOTH0\n\tzWxXDg8JtyKaTG9yPsdjUvdY7lGbn5osuWEUFoVM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 May 2020 03:03:09 +0300", "Message-Id": "<20200512000322.11753-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>", "References": "<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 11/24] utils: raspberrypi: ctt: Fix\n\tpycodestyle E303", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 May 2020 00:03:39 -0000" }, "content": "E303 too many blank lines\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/raspberrypi/ctt/ctt.py | 2 --\n utils/raspberrypi/ctt/ctt_alsc.py | 1 -\n utils/raspberrypi/ctt/ctt_macbeth_locator.py | 3 ---\n utils/raspberrypi/ctt/ctt_noise.py | 1 -\n 4 files changed, 7 deletions(-)", "diff": "diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\nindex 07230fe3f709..ff264176f040 100755\n--- a/utils/raspberrypi/ctt/ctt.py\n+++ b/utils/raspberrypi/ctt/ctt.py\n@@ -193,7 +193,6 @@ class Camera:\n }\n }\n \n-\n \"\"\"\n Perform colour correction calibrations by comparing macbeth patch colours\n to standard macbeth chart colours.\n@@ -770,7 +769,6 @@ def run_ctt(json_output, directory, config, log_output):\n except FileNotFoundError:\n raise ArgError('\\n\\nError: Input image directory not found!')\n \n-\n \"\"\"\n preform calibrations as long as check_imgs returns True\n If alsc is activated then it must be done before awb and ccm since the alsc\ndiff --git a/utils/raspberrypi/ctt/ctt_alsc.py b/utils/raspberrypi/ctt/ctt_alsc.py\nindex e768f8d648a1..b697ed3e22b4 100644\n--- a/utils/raspberrypi/ctt/ctt_alsc.py\n+++ b/utils/raspberrypi/ctt/ctt_alsc.py\n@@ -253,7 +253,6 @@ def get_sigma(Cam, cal_cr_list, cal_cb_list):\n sigma_b = max(sigma_bs) if sigma_bs else 0.005\n Cam.log += '\\nMaximum sigmas: Red = {} Blue = {}'.format(sigma_r, sigma_b)\n \n-\n # print(sigma_rs, sigma_bs)\n # print(sigma_r, sigma_b)\n return sigma_r, sigma_b\ndiff --git a/utils/raspberrypi/ctt/ctt_macbeth_locator.py b/utils/raspberrypi/ctt/ctt_macbeth_locator.py\nindex c3016f9a3c1d..94bbf580db84 100644\n--- a/utils/raspberrypi/ctt/ctt_macbeth_locator.py\n+++ b/utils/raspberrypi/ctt/ctt_macbeth_locator.py\n@@ -144,7 +144,6 @@ def find_macbeth(Cam, img, mac_config=(0, 0)):\n w_best, h_best = w_inc, h_inc\n d_best = 1\n \n-\n \"\"\"\n scale 2\n \"\"\"\n@@ -697,7 +696,6 @@ def get_macbeth_chart(img, ref_data):\n Following code is mostly representation for debugging purposes\n \"\"\"\n \n-\n \"\"\"\n draw macbeth corners and centres on image\n \"\"\"\n@@ -731,7 +729,6 @@ def get_macbeth_chart(img, ref_data):\n # cv2.imshow('Macbeth', best_map_col)\n # represent(copy)\n \n-\n \"\"\"\n rescale coordinates to original image size\n \"\"\"\ndiff --git a/utils/raspberrypi/ctt/ctt_noise.py b/utils/raspberrypi/ctt/ctt_noise.py\nindex 2d021e550f85..ba57f1d1d2c5 100644\n--- a/utils/raspberrypi/ctt/ctt_noise.py\n+++ b/utils/raspberrypi/ctt/ctt_noise.py\n@@ -39,7 +39,6 @@ def noise(Cam, Img, plot):\n means = np.clip(np.array(means), 0, None)\n sq_means = np.sqrt(means)\n \n-\n \"\"\"\n least squares fit model\n \"\"\"\n", "prefixes": [ "libcamera-devel", "11/24" ] }