Patch Detail
Show a patch.
GET /api/patches/3753/?format=api
{ "id": 3753, "url": "https://patchwork.libcamera.org/api/patches/3753/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3753/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200511233923.10107-1-laurent.pinchart@ideasonboard.com>", "date": "2020-05-11T23:39:23", "name": "[libcamera-devel] ipa: Drop v4l2_controls.h from ipa_interface.h", "commit_ref": "49295e549e471429afdd2cbf3bafa77b4284d830", "pull_url": null, "state": "accepted", "archived": false, "hash": "8f37eba847efc368e02e66791109c25f652536e4", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3753/mbox/", "series": [ { "id": 896, "url": "https://patchwork.libcamera.org/api/series/896/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=896", "date": "2020-05-11T23:39:23", "name": "[libcamera-devel] ipa: Drop v4l2_controls.h from ipa_interface.h", "version": 1, "mbox": "https://patchwork.libcamera.org/series/896/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3753/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3753/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15679603DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2020 01:39:34 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 859E933E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2020 01:39:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vYlXhh++\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589240373;\n\tbh=+Tp+1rffBhu/rgBdQcEs3fX+5WFuj38qzEziuJMgJC4=;\n\th=From:To:Subject:Date:From;\n\tb=vYlXhh++3Pldy25zMrV7uR0HEvmjyZpeFrPA2rcA5FRd0a9bD16S4FRWJNHH7VJaD\n\tJuvFQFXxmPj2B4wONP2DXFj1bgbV/B6IT04qqYLo1aLDWqWJv1ZezEDBGn4q9NpKlO\n\t8F/tRwWxz7SY+lfk9x2YmpPQlC5tD9WW7NoS6SZs=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 May 2020 02:39:23 +0300", "Message-Id": "<20200511233923.10107-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: Drop v4l2_controls.h from\n\tipa_interface.h", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 11 May 2020 23:39:34 -0000" }, "content": "The v4l2_controls.h header is internal, and isn't needed by\nipa_interface.h. It originates from the days when V4L2 controls were\nhandled through a different API. Drop it.\n\nFixes: 319d6ae8e3ad (\"libcamera: controls: Merge ControlInfoMap and V4L2ControlInfoMap\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/ipa/ipa_interface.h | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h\nindex a2d5e3dd1f51..dc9fc714d564 100644\n--- a/include/ipa/ipa_interface.h\n+++ b/include/ipa/ipa_interface.h\n@@ -123,8 +123,6 @@ struct ipa_context *ipaCreate();\n #include <libcamera/geometry.h>\n #include <libcamera/signal.h>\n \n-#include \"v4l2_controls.h\"\n-\n namespace libcamera {\n \n struct IPASettings {\n", "prefixes": [ "libcamera-devel" ] }