Patch Detail
Show a patch.
GET /api/patches/3746/?format=api
{ "id": 3746, "url": "https://patchwork.libcamera.org/api/patches/3746/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3746/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200510212636.13017-1-laurent.pinchart@ideasonboard.com>", "date": "2020-05-10T21:26:36", "name": "[libcamera-devel] meson: Use files() instead of find_program() for internal scripts", "commit_ref": "019a145068b714482bbf791c0f296abd06ec0dc1", "pull_url": null, "state": "accepted", "archived": false, "hash": "81260868187e220ede5b5f015582d8666d5fdd93", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3746/mbox/", "series": [ { "id": 891, "url": "https://patchwork.libcamera.org/api/series/891/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=891", "date": "2020-05-10T21:26:36", "name": "[libcamera-devel] meson: Use files() instead of find_program() for internal scripts", "version": 1, "mbox": "https://patchwork.libcamera.org/series/891/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3746/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3746/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6D31603F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 10 May 2020 23:26:49 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 095DF304\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 10 May 2020 23:26:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vCTjvoZW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589146009;\n\tbh=FuU4uPDiKOXvWhAGRI2eIsvQt7QFoHw6cCM+4NNWTW4=;\n\th=From:To:Subject:Date:From;\n\tb=vCTjvoZWA/Jqd65gAViEW1KpK86/eEyx5jTNLTShG2lwxmYbs+ZfkIudCUq8c9XKW\n\t7W3+CEaFiS46Re5beaDNcd0Rz7bkTLW+f3T/rJ28ZDGAzn5S58/4Q7uxMpJdXlNsdY\n\tGpBRXjLMGgiRNMHoaovdW475wzC97ylIED4HAagI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 11 May 2020 00:26:36 +0300", "Message-Id": "<20200510212636.13017-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] meson: Use files() instead of\n\tfind_program() for internal scripts", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 10 May 2020 21:26:49 -0000" }, "content": "Using find_program() to locate scripts part of the source tree causes\nmeson to print messages at setup time for each of those scripts:\n\nProgram ipa-sign.sh found: YES (/home/user/src/libcamera/src/ipa/ipa-sign.sh)\n\nThis polutes the meson setup log with useless messages, as we know the\nscripts are present. Use files() instead to avoid this.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/meson.build | 2 +-\n src/meson.build | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex 56e65eaa7426..cc3837ab8525 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -16,7 +16,7 @@ config_h.set('IPA_MODULE_DIR',\n \n subdir('libipa')\n \n-ipa_sign = find_program('ipa-sign.sh')\n+ipa_sign = files('ipa-sign.sh')\n \n ipas = ['rkisp1', 'vimc']\n \ndiff --git a/src/meson.build b/src/meson.build\nindex f605a420c3ee..c9c1008562b1 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -4,7 +4,7 @@ endif\n \n openssl = find_program('openssl', required : true)\n if openssl.found()\n- ipa_gen_priv_key = find_program('ipa/gen-ipa-priv-key.sh')\n+ ipa_gen_priv_key = files('ipa/gen-ipa-priv-key.sh')\n ipa_priv_key = custom_target('ipa-priv-key',\n output : [ 'ipa-priv-key.pem' ],\n command : [ ipa_gen_priv_key, '@OUTPUT@' ])\n", "prefixes": [ "libcamera-devel" ] }