Patch Detail
Show a patch.
GET /api/patches/3713/?format=api
{ "id": 3713, "url": "https://patchwork.libcamera.org/api/patches/3713/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3713/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200508100158.3437161-3-jacopo@jmondi.org>", "date": "2020-05-08T10:01:47", "name": "[libcamera-devel,v10,02/13] dt-bindings: video-interface: Replace 'rotation' description", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3af61ff1886333f79d7e861fa4bc24fe5eb6a4f7", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3713/mbox/", "series": [ { "id": 888, "url": "https://patchwork.libcamera.org/api/series/888/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=888", "date": "2020-05-08T10:01:45", "name": "media: report camera properties", "version": 10, "mbox": "https://patchwork.libcamera.org/series/888/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3713/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3713/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F8FF603E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 May 2020 11:59:06 +0200 (CEST)", "from localhost.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 1C11AFF804;\n\tFri, 8 May 2020 09:59:00 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE\n\t(V4L/DVB)), libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab <mchehab@kernel.org>,\n\tHans Verkuil <hverkuil-cisco@xs4all.nl>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tRob Herring <robh@kernel.org>", "Cc": "Jacopo Mondi <jacopo@jmondi.org>, tfiga@google.com, pavel@ucw.cz,\n\tdevicetree@vger.kernel.org", "Date": "Fri, 8 May 2020 12:01:47 +0200", "Message-Id": "<20200508100158.3437161-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.26.1", "In-Reply-To": "<20200508100158.3437161-1-jacopo@jmondi.org>", "References": "<20200508100158.3437161-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v10 02/13] dt-bindings: video-interface:\n\tReplace 'rotation' description", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 08 May 2020 09:59:06 -0000" }, "content": "Replace the 'rotation' property description by providing a definition\nrelative to the camera sensor pixel array coordinate system and the\ncaptured scene.\n\nAcked-by: Rob Herring <robh@kernel.org>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n .../bindings/media/video-interfaces.txt | 359 +++++++++++++++++-\n 1 file changed, 356 insertions(+), 3 deletions(-)\n\n--\n2.26.1", "diff": "diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt\nindex b1ff492c7da7a..3920f25a91235 100644\n--- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n+++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n@@ -85,9 +85,362 @@ Optional properties\n\n - lens-focus: A phandle to the node of the focus lens controller.\n\n-- rotation: The device, typically an image sensor, is not mounted upright,\n- but a number of degrees counter clockwise. Typical values are 0 and 180\n- (upside down).\n+- rotation: The camera rotation is expressed as the angular difference in\n+ degrees between two reference systems, one relative to the camera module, and\n+ one defined on the external world scene to be captured when projected on the\n+ image sensor pixel array.\n+\n+ A camera sensor has a 2-dimensional reference system 'Rc' defined by\n+ its pixel array read-out order. The origin is set to the first pixel\n+ being read out, the X-axis points along the column read-out direction\n+ towards the last columns, and the Y-axis along the row read-out\n+ direction towards the last row.\n+\n+ A typical example for a sensor with a 2592x1944 pixel array matrix\n+ observed from the front is:\n+\n+ 2591 X-axis 0\n+ <------------------------+ 0\n+ .......... ... ..........!\n+ .......... ... ..........! Y-axis\n+ ... !\n+ .......... ... ..........!\n+ .......... ... ..........! 1943\n+ V\n+\n+ The external world scene reference system 'Rs' is a 2-dimensional\n+ reference system on the focal plane of the camera module. The origin is\n+ placed on the top-left corner of the visible scene, the X-axis points\n+ towards the right, and the Y-axis points towards the bottom of the\n+ scene. The top, bottom, left and right directions are intentionally not\n+ defined and depend on the environment in which the camera is used.\n+\n+ A typical example of a (very common) picture of a shark swimming from\n+ left to right, as seen from the camera, is:\n+\n+ 0 X-axis\n+ 0 +------------------------------------->\n+ !\n+ !\n+ !\n+ ! |\\____)\\___\n+ ! ) _____ __`<\n+ ! |/ )/\n+ !\n+ !\n+ !\n+ V\n+ Y-axis\n+\n+ with the reference system 'Rs' placed on the camera focal plane:\n+\n+ ¸.·˙!\n+ ¸.·˙ !\n+ _ ¸.·˙ !\n+ +-/ \\-+¸.·˙ !\n+ | (o) | ! Camera focal plane\n+ +-----+˙·.¸ !\n+ ˙·.¸ !\n+ ˙·.¸ !\n+ ˙·.¸!\n+\n+ When projected on the sensor's pixel array, the image and the associated\n+ reference system 'Rs' are typically (but not always) inverted, due to\n+ the camera module's lens optical inversion effect.\n+\n+ Assuming the above represented scene of the swimming shark, the lens\n+ inversion projects the scene and its reference system onto the sensor\n+ pixel array, seen from the front of the camera sensor, as follows:\n+\n+ Y-axis\n+ ^\n+ !\n+ !\n+ !\n+ ! |\\_____)\\__\n+ ! ) ____ ___.<\n+ ! |/ )/\n+ !\n+ !\n+ !\n+ 0 +------------------------------------->\n+ 0 X-axis\n+\n+ Note the shark being upside-down.\n+\n+ The resulting projected reference system is named 'Rp'.\n+\n+ The camera rotation property is then defined as the angular difference\n+ in the counter-clockwise direction between the camera reference system\n+ 'Rc' and the projected scene reference system 'Rp'. It is expressed in\n+ degrees as a number in the range [0, 360[.\n+\n+ Examples\n+\n+ 0 degrees camera rotation:\n+\n+\n+ Y-Rp\n+ ^\n+ Y-Rc !\n+ ^ !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! 0 +------------------------------------->\n+ ! 0 X-Rp\n+ 0 +------------------------------------->\n+ 0 X-Rc\n+\n+\n+ X-Rc 0\n+ <------------------------------------+ 0\n+ X-Rp 0 !\n+ <------------------------------------+ 0 !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! V\n+ ! Y-Rc\n+ V\n+ Y-Rp\n+\n+ 90 degrees camera rotation:\n+\n+ 0 Y-Rc\n+ 0 +-------------------->\n+ ! Y-Rp\n+ ! ^\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! 0 +------------------------------------->\n+ ! 0 X-Rp\n+ !\n+ !\n+ !\n+ !\n+ V\n+ X-Rc\n+\n+ 180 degrees camera rotation:\n+\n+ 0\n+ <------------------------------------+ 0\n+ X-Rc !\n+ Y-Rp !\n+ ^ !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! V\n+ ! Y-Rc\n+ 0 +------------------------------------->\n+ 0 X-Rp\n+\n+ 270 degrees camera rotation:\n+\n+ 0 Y-Rc\n+ 0 +-------------------->\n+ ! 0\n+ ! <-----------------------------------+ 0\n+ ! X-Rp !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! V\n+ ! Y-Rp\n+ !\n+ !\n+ !\n+ !\n+ V\n+ X-Rc\n+\n+\n+ Example one - Webcam\n+\n+ A camera module installed on the user facing part of a laptop screen\n+ casing used for video calls. The captured images are meant to be\n+ displayed in landscape mode (width > height) on the laptop screen.\n+\n+ The camera is typically mounted upside-down to compensate the lens\n+ optical inversion effect:\n+\n+ Y-Rp\n+ Y-Rc ^\n+ ^ !\n+ ! !\n+ ! ! |\\_____)\\__\n+ ! ! ) ____ ___.<\n+ ! ! |/ )/\n+ ! !\n+ ! !\n+ ! !\n+ ! 0 +------------------------------------->\n+ ! 0 X-Rp\n+ 0 +------------------------------------->\n+ 0 X-Rc\n+\n+ The two reference systems are aligned, the resulting camera rotation is\n+ 0 degrees, no rotation correction needs to be applied to the resulting\n+ image once captured to memory buffers to correctly display it to users:\n+\n+ +--------------------------------------+\n+ ! !\n+ ! !\n+ ! !\n+ ! |\\____)\\___ !\n+ ! ) _____ __`< !\n+ ! |/ )/ !\n+ ! !\n+ ! !\n+ ! !\n+ +--------------------------------------+\n+\n+ If the camera sensor is not mounted upside-down to compensate for the\n+ lens optical inversion, the two reference systems will not be aligned,\n+ with 'Rp' being rotated 180 degrees relatively to 'Rc':\n+\n+\n+ X-Rc 0\n+ <------------------------------------+ 0\n+ !\n+ Y-Rp !\n+ ^ !\n+ ! !\n+ ! |\\_____)\\__ !\n+ ! ) ____ ___.< !\n+ ! |/ )/ !\n+ ! !\n+ ! !\n+ ! V\n+ ! Y-Rc\n+ 0 +------------------------------------->\n+ 0 X-Rp\n+\n+ The image once captured to memory will then be rotated by 180 degrees:\n+\n+ +--------------------------------------+\n+ ! !\n+ ! !\n+ ! !\n+ ! __/(_____/| !\n+ ! >.___ ____ ( !\n+ ! \\( \\| !\n+ ! !\n+ ! !\n+ ! !\n+ +--------------------------------------+\n+\n+ A software rotation correction of 180 degrees should be applied to\n+ correctly display the image:\n+\n+ +--------------------------------------+\n+ ! !\n+ ! !\n+ ! !\n+ ! |\\____)\\___ !\n+ ! ) _____ __`< !\n+ ! |/ )/ !\n+ ! !\n+ ! !\n+ ! !\n+ +--------------------------------------+\n+\n+ Example two - Phone camera\n+\n+ A camera installed on the back side of a mobile device facing away from\n+ the user. The captured images are meant to be displayed in portrait mode\n+ (height > width) to match the device screen orientation and the device\n+ usage orientation used when taking the picture.\n+\n+ The camera sensor is typically mounted with its pixel array longer side\n+ aligned to the device longer side, upside-down mounted to compensate for\n+ the lens optical inversion effect:\n+\n+ 0 Y-Rc\n+ 0 +-------------------->\n+ ! Y-Rp\n+ ! ^\n+ ! !\n+ ! !\n+ ! !\n+ ! ! |\\_____)\\__\n+ ! ! ) ____ ___.<\n+ ! ! |/ )/\n+ ! !\n+ ! !\n+ ! !\n+ ! 0 +------------------------------------->\n+ ! 0 X-Rp\n+ !\n+ !\n+ !\n+ !\n+ V\n+ X-Rc\n+\n+ The two reference systems are not aligned and the 'Rp' reference\n+ system is rotated by 90 degrees in the counter-clockwise direction\n+ relatively to the 'Rc' reference system.\n+\n+ The image once captured to memory will be rotated:\n+\n+ +-------------------------------------+\n+ | _ _ |\n+ | \\ / |\n+ | | | |\n+ | | | |\n+ | | > |\n+ | < | |\n+ | | | |\n+ | . |\n+ | V |\n+ +-------------------------------------+\n+\n+ A correction of 90 degrees in counter-clockwise direction has to be\n+ applied to correctly display the image in portrait mode on the device\n+ screen:\n+\n+ +--------------------+\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\\____)\\___ |\n+ | ) _____ __`< |\n+ | |/ )/ |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ +--------------------+\n\n - orientation: The orientation of a device (typically an image sensor or a flash\n LED) describing its mounting position relative to the usage orientation of the\n", "prefixes": [ "libcamera-devel", "v10", "02/13" ] }