Patch Detail
Show a patch.
GET /api/patches/367/?format=api
{ "id": 367, "url": "https://patchwork.libcamera.org/api/patches/367/?format=api", "web_url": "https://patchwork.libcamera.org/patch/367/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190124113000.7142-2-jacopo@jmondi.org>", "date": "2019-01-24T11:29:59", "name": "[libcamera-devel,v2,1/2] libcamera: v4l2_device: Identify multiplanar formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a7b8677d52837dc8b21cd670ddec4ade422af70a", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/367/mbox/", "series": [ { "id": 126, "url": "https://patchwork.libcamera.org/api/series/126/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=126", "date": "2019-01-24T11:29:58", "name": "Add mplane support to V4L2 device", "version": 2, "mbox": "https://patchwork.libcamera.org/series/126/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/367/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/367/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E8DB60C81\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Jan 2019 12:29:52 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B9E83E0015;\n\tThu, 24 Jan 2019 11:29:51 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Jan 2019 12:29:59 +0100", "Message-Id": "<20190124113000.7142-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190124113000.7142-1-jacopo@jmondi.org>", "References": "<20190124113000.7142-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] libcamera: v4l2_device: Identify\n\tmultiplanar formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jan 2019 11:29:52 -0000" }, "content": "Add functions to V4L2Capability to identify if a V4L2 device supports\nmultiplanar V4L2 APIs.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/include/v4l2_device.h | 23 +++++++++++++++++++----\n src/libcamera/v4l2_device.cpp | 6 ++++++\n 2 files changed, 25 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h\nindex cb3601c..413bb7f 100644\n--- a/src/libcamera/include/v4l2_device.h\n+++ b/src/libcamera/include/v4l2_device.h\n@@ -32,10 +32,25 @@ struct V4L2Capability final : v4l2_capability {\n \t\t\t\t ? v4l2_capability::device_caps\n \t\t\t\t : v4l2_capability::capabilities;\n \t}\n-\n-\tbool isCapture() const { return device_caps() & V4L2_CAP_VIDEO_CAPTURE; }\n-\tbool isOutput() const { return device_caps() & V4L2_CAP_VIDEO_OUTPUT; }\n-\tbool hasStreaming() const { return device_caps() & V4L2_CAP_STREAMING; }\n+\tbool isMultiplanar() const\n+\t{\n+\t\treturn device_caps() & (V4L2_CAP_VIDEO_CAPTURE_MPLANE |\n+\t\t\t\t\tV4L2_CAP_VIDEO_OUTPUT_MPLANE);\n+\t}\n+\tbool isCapture() const\n+\t{\n+\t\treturn device_caps() & (V4L2_CAP_VIDEO_CAPTURE |\n+\t\t\t\t\tV4L2_CAP_VIDEO_CAPTURE_MPLANE);\n+\t}\n+\tbool isOutput() const\n+\t{\n+\t\treturn device_caps() & (V4L2_CAP_VIDEO_OUTPUT |\n+\t\t\t\t\tV4L2_CAP_VIDEO_OUTPUT_MPLANE);\n+\t}\n+\tbool hasStreaming() const\n+\t{\n+\t\treturn device_caps() & V4L2_CAP_STREAMING;\n+\t}\n };\n \n class MediaEntity;\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 0ce2b18..9cb504d 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -56,6 +56,12 @@ LOG_DEFINE_CATEGORY(V4L2)\n * \t driver capabilities otherwise\n */\n \n+/**\n+ * \\fn bool V4L2Capability::isMultiplanar()\n+ * \\brief Identify if the device implement V4L2 multiplanar APIs\n+ * \\return True if the device supports multiplanar APIs\n+ */\n+\n /**\n * \\fn bool V4L2Capability::isCapture()\n * \\brief Identify if the device is capable of capturing video\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }