Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 3642,
    "url": "https://patchwork.libcamera.org/api/patches/3642/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/3642/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200501023432.90032-2-niklas.soderlund@ragnatech.se>",
    "date": "2020-05-01T02:34:27",
    "name": "[libcamera-devel,v3,1/6] cam: options: Make KeyValueParser::parse() virtual",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "9d0d28529741f88aaa5301090b915f6802fe8286",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/3642/mbox/",
    "series": [
        {
            "id": 864,
            "url": "https://patchwork.libcamera.org/api/series/864/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=864",
            "date": "2020-05-01T02:34:27",
            "name": "{cam, qcam}: Unify stream option parsing",
            "version": 3,
            "mbox": "https://patchwork.libcamera.org/series/864/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/3642/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/3642/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2683361469\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  1 May 2020 04:34:43 +0200 (CEST)",
            "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 4f0d3510-8b54-11ea-89d0-0050569116f7;\n\tFri, 01 May 2020 04:34:41 +0200 (CEST)"
        ],
        "X-Halon-ID": "4f0d3510-8b54-11ea-89d0-0050569116f7",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Fri,  1 May 2020 04:34:27 +0200",
        "Message-Id": "<20200501023432.90032-2-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.26.2",
        "In-Reply-To": "<20200501023432.90032-1-niklas.soderlund@ragnatech.se>",
        "References": "<20200501023432.90032-1-niklas.soderlund@ragnatech.se>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v3 1/6] cam: options: Make\n\tKeyValueParser::parse() virtual",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Fri, 01 May 2020 02:34:43 -0000"
    },
    "content": "Prepare for sub-classing of the KeyValueParser by making the parse()\nmethod virtual.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/src/cam/options.h b/src/cam/options.h\nindex 5e346b474f765841..ad5c93a4fabd089f 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -71,10 +71,12 @@ public:\n \t{\n \t};\n \n+\tvirtual ~KeyValueParser() {}\n+\n \tbool addOption(const char *name, OptionType type, const char *help,\n \t\t       OptionArgument argument = ArgumentNone);\n \n-\tOptions parse(const char *arguments);\n+\tvirtual Options parse(const char *arguments);\n \tvoid usage(int indent);\n \n private:\n",
    "prefixes": [
        "libcamera-devel",
        "v3",
        "1/6"
    ]
}